From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49CACC352A1 for ; Tue, 6 Dec 2022 08:50:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233991AbiLFIu0 (ORCPT ); Tue, 6 Dec 2022 03:50:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232046AbiLFIuY (ORCPT ); Tue, 6 Dec 2022 03:50:24 -0500 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5DD3767E for ; Tue, 6 Dec 2022 00:50:22 -0800 (PST) Received: by mail-wm1-x32a.google.com with SMTP id r7-20020a1c4407000000b003d1e906ca23so179182wma.3 for ; Tue, 06 Dec 2022 00:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6MLEMifrOrAUJyiSNGyAY6fT78MNUKLEB+8w+o7FY90=; b=YlErl1grOuPOm9ucyT+J7AqqdsFweAD5LdsekbhpKGbraE4N5YdAqg8rSYajR0ljUM +64umJysE99/JVhfURudPQE6FyhU/VqRjGCUYExvh6QLrmD9m+VYn91GnDq5zBVHxwAi nofeqbvzdVvdZgHYUT3CT+0J2Z05qs4hgpOgaNw4YRwhAbc+UYPPIK8vb36R/HZUoYvt vJS5QUnj7NG7nY1rL3p1FKJPlURrxdY0hdvfeJwpxzuymq1QPC51O1nHrocX8zjEQS+Z Z9wgpYzP+nV14U91RpkJQrfvjiPX6AiuWOJRdEd/nUyzukEDKwA0GOXMBtwLiR8GrF4N kySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6MLEMifrOrAUJyiSNGyAY6fT78MNUKLEB+8w+o7FY90=; b=ZPS4MBNAit53anbcY5ZSC26veilTOI3JTlsBq9j9owXcFCMx6MwOdK8aV/qcogqQg+ xixIJMdzjGkxSWz27ZXKEkIOFSsrK1nFpnYptsnjYCmU99jg6Qqt9y8lnavrwZLaz1Qz BylQ6QDQ/9gzsFlY4l57Prt33aB9BqgqXJlTJABhpgRt/gxW4GhKmHPGV/GNCmzi9Zfr rASAPiLyutT0p2mh4G+i0RDWF2xT2Dz/DdqQmd177YrSjyGAwz10V97sqjDKEqUu2MNT ZrJg0p7A4zLCGDifV1OQp3ydbHJ+F3R0YyD/GcEV8R5Sr3Rfcc/Xhp0DmlAH9KHMHR8P 0iWQ== X-Gm-Message-State: ANoB5pnDJhC3Y291NJJzkN92xYlEzk3HQw+TNlieyO28LUBFK5kpGHm9 HABTW/RXvwoLNs+2P8ks0tnfdQ== X-Google-Smtp-Source: AA0mqf79OI9dXCe3xYaQOVHi0Mcw3RUmVy3FxZc4HYB3KfTJSvGj1hBcHzNQ5QzTmm11mjMaKGIl/A== X-Received: by 2002:a05:600c:3d98:b0:3cf:e9a4:325f with SMTP id bi24-20020a05600c3d9800b003cfe9a4325fmr61498931wmb.98.1670316621409; Tue, 06 Dec 2022 00:50:21 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id i15-20020a05600011cf00b002366e3f1497sm16065586wrx.6.2022.12.06.00.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 00:50:20 -0800 (PST) Date: Tue, 6 Dec 2022 09:50:19 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-3-vfedorenko@novek.ru> <20221202212206.3619bd5f@kernel.org> <20221205161933.663ea611@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221205161933.663ea611@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Dec 06, 2022 at 01:19:33AM CET, kuba@kernel.org wrote: >On Mon, 5 Dec 2022 11:32:04 +0100 Jiri Pirko wrote: >> >> I believe we should do it only the other way around. Assign >> >> dpll_pin pointer to struct net_device and expose this over new attr >> >> IFLA_DPLL_PIN over RT netlink. >> > >> >The ID table is global, what's the relationship between DPLLs >> >and net namespaces? We tie DPLLs to a devlink instance which >> >has a namespace? We pretend namespaces don't exist? :S >> >> Well, if would be odd to put dpll itself into a namespace. It might not >> have anything to do with networking, for example in case of ptp_ocp. >> What would mean for a dpll to be in a net namespace? > >Yeah, that's a slightly tricky one. We'd probably need some form >of second order association. Easiest if we link it to a devlink >instance, I reckon. The OCP clock card does not have netdevs so we >can't follow the namespace of netdevs (which would be the second >option). Why do we need this association at all? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C16DFC3A5A7 for ; Tue, 6 Dec 2022 08:51:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/TeWnYeoy/VlJOV6O7eZuT7mL2xEZltqgjFn/kNUROQ=; b=EJPWmXhUxvijNb 55mN+jrQntj7riW6zNutyFlmxPHQzF/2fStoGrGQruQoMXzCx4igv0RIOjonbDmCQeXXrDjC8Og5D HfgaISMZ0llEVEaxwlu9DkvlQ/an8MVnZa3k8QB+BgkCsmW2ObvdenarnvP5YAMNnLsiDXwJSXTda g89/r/m5wA79A4E/Sq3OAyYj1+WihXARVIQtA7d0MCpCbwol0XzD6vDvwziW70aSnyH+0UwB8cj4W rSaamuwYpEwKaB8kzMZIYSy40MUMIBwTKb0Un/TmZUioHiRtIZOH3kRIOR+Zt1zX9DmcQria+JGFn vD5n7hs19BqUfZHHuGJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Ten-005DnV-QW; Tue, 06 Dec 2022 08:50:29 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2Tej-005DbX-C6 for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 08:50:28 +0000 Received: by mail-wm1-x32b.google.com with SMTP id h8-20020a1c2108000000b003d1efd60b65so295466wmh.0 for ; Tue, 06 Dec 2022 00:50:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=6MLEMifrOrAUJyiSNGyAY6fT78MNUKLEB+8w+o7FY90=; b=YlErl1grOuPOm9ucyT+J7AqqdsFweAD5LdsekbhpKGbraE4N5YdAqg8rSYajR0ljUM +64umJysE99/JVhfURudPQE6FyhU/VqRjGCUYExvh6QLrmD9m+VYn91GnDq5zBVHxwAi nofeqbvzdVvdZgHYUT3CT+0J2Z05qs4hgpOgaNw4YRwhAbc+UYPPIK8vb36R/HZUoYvt vJS5QUnj7NG7nY1rL3p1FKJPlURrxdY0hdvfeJwpxzuymq1QPC51O1nHrocX8zjEQS+Z Z9wgpYzP+nV14U91RpkJQrfvjiPX6AiuWOJRdEd/nUyzukEDKwA0GOXMBtwLiR8GrF4N kySA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6MLEMifrOrAUJyiSNGyAY6fT78MNUKLEB+8w+o7FY90=; b=cOS09j3Z3hyVx/GvqRNnZ48LzLpXCRpLbTClnqkrwv1W0+aNXCWN4yWE/iY/Z7f5dX +1gXIh/nxGK+RbTM6vIc3LTiRzRiIFMIeZcRtNQF1IzQLwNr9dcO7URV3P7/lXAF4Y7h 9hwIy9xGlXa376LzkFynf2JzfujLuebX/iy0rwl2E4QVusmym6oQw15oDd5hR7s32+ad WX7eaRfvPf/piLLiI1jI2Ov0mDkZZ51bhjDQ1BtGd6Pfqf3ItCHr18hQe90fliId5nJU GKg2pxT/C+SFz3D3CKBkrep1rX3hT81UjtT+nG+1/Bjcm/NdaMi3aAy6IiEQJMdT+hl1 0PoQ== X-Gm-Message-State: ANoB5pmp0aPxh/zTOEi9a3gyIeteiY7INC5ViRm92J+4n5BJapig70Hz K6+9tLS/xMyBwkQNyQkw6UVbdg== X-Google-Smtp-Source: AA0mqf79OI9dXCe3xYaQOVHi0Mcw3RUmVy3FxZc4HYB3KfTJSvGj1hBcHzNQ5QzTmm11mjMaKGIl/A== X-Received: by 2002:a05:600c:3d98:b0:3cf:e9a4:325f with SMTP id bi24-20020a05600c3d9800b003cfe9a4325fmr61498931wmb.98.1670316621409; Tue, 06 Dec 2022 00:50:21 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id i15-20020a05600011cf00b002366e3f1497sm16065586wrx.6.2022.12.06.00.50.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Dec 2022 00:50:20 -0800 (PST) Date: Tue, 6 Dec 2022 09:50:19 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-3-vfedorenko@novek.ru> <20221202212206.3619bd5f@kernel.org> <20221205161933.663ea611@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221205161933.663ea611@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_005025_644045_540DBB6B X-CRM114-Status: GOOD ( 11.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tue, Dec 06, 2022 at 01:19:33AM CET, kuba@kernel.org wrote: >On Mon, 5 Dec 2022 11:32:04 +0100 Jiri Pirko wrote: >> >> I believe we should do it only the other way around. Assign >> >> dpll_pin pointer to struct net_device and expose this over new attr >> >> IFLA_DPLL_PIN over RT netlink. >> > >> >The ID table is global, what's the relationship between DPLLs >> >and net namespaces? We tie DPLLs to a devlink instance which >> >has a namespace? We pretend namespaces don't exist? :S >> >> Well, if would be odd to put dpll itself into a namespace. It might not >> have anything to do with networking, for example in case of ptp_ocp. >> What would mean for a dpll to be in a net namespace? > >Yeah, that's a slightly tricky one. We'd probably need some form >of second order association. Easiest if we link it to a devlink >instance, I reckon. The OCP clock card does not have netdevs so we >can't follow the namespace of netdevs (which would be the second >option). Why do we need this association at all? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel