From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440EDC4332F for ; Fri, 25 Nov 2022 12:25:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbiKYMZE (ORCPT ); Fri, 25 Nov 2022 07:25:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229743AbiKYMYt (ORCPT ); Fri, 25 Nov 2022 07:24:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8EDF74C273; Fri, 25 Nov 2022 04:24:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2911C62371; Fri, 25 Nov 2022 12:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41C99C433C1; Fri, 25 Nov 2022 12:24:34 +0000 (UTC) Date: Fri, 25 Nov 2022 12:24:31 +0000 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Fri, Nov 25, 2022 at 12:36:33PM +0800, Herbert Xu wrote: > diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h > index d482017f3e20..cd8cb1e921b7 100644 > --- a/include/crypto/internal/aead.h > +++ b/include/crypto/internal/aead.h > @@ -39,6 +39,11 @@ static inline void *crypto_aead_ctx(struct crypto_aead *tfm) > return crypto_tfm_ctx(&tfm->base); > } > > +static inline void *crypto_aead_ctx_dma(struct crypto_aead *tfm) > +{ > + return crypto_tfm_ctx_dma(&tfm->base); > +} I wonder, if drivers end up calling this, isn't it easier to do the alignment in crypto_aead_ctx() directly? There are over 300 callers (not sure about the padding though, it may need still driver changes unless we can add it to something like crypto_tfm_alg_alignmask()). Or is the expectation that not all drivers need a DMA alignment? -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D24DC4332F for ; Fri, 25 Nov 2022 12:25:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=reWUAhx9r/JMx2lFDyTJLaB+ZjctIucMnCSpn6Q0+eQ=; b=jgAiCSInQbZ/zk rQ1PvpLOTIcfWGYYcRlCAeqxZvaU30z/+GAvNCLiPovwhUiBdB+iN/Jqvf6moEn+vDqWyo4QxsTei 0Sg6Rbsg1GY2qDCcnZzMxnEIihhYrm98K+9PoV9yLjOzaCcDOGSuhlc7c07XDgy2yap/+SU6dHcA9 Zplrd7ju9ZVBU61fC7qhLgKu+FeRSXvZN/MyVsP9kbDxtSbh9uFWEqAERI5CHxJUOwAYzQogac+Gd IEj/Vcn+q2Wl2vPia2M8wkF6yhWdfzpJKwRbxC94SOOZutkw+CbkDy7B3J5pDo9B1Id04HZW3mneC 8kh0NHLFkYckH0oYlWNA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyXl4-00GOaN-4p; Fri, 25 Nov 2022 12:24:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oyXl1-00GOYr-8G for linux-arm-kernel@lists.infradead.org; Fri, 25 Nov 2022 12:24:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id F00D362369; Fri, 25 Nov 2022 12:24:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 41C99C433C1; Fri, 25 Nov 2022 12:24:34 +0000 (UTC) Date: Fri, 25 Nov 2022 12:24:31 +0000 From: Catalin Marinas To: Herbert Xu Cc: Ard Biesheuvel , Will Deacon , Marc Zyngier , Arnd Bergmann , Greg Kroah-Hartman , Andrew Morton , Linus Torvalds , Linux Memory Management List , Linux ARM , Linux Kernel Mailing List , "David S. Miller" , Linux Crypto Mailing List Subject: Re: [v2 PATCH 3/9] crypto: aead - Add ctx helpers with DMA alignment Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221125_042439_372728_FB631C30 X-CRM114-Status: GOOD ( 16.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Nov 25, 2022 at 12:36:33PM +0800, Herbert Xu wrote: > diff --git a/include/crypto/internal/aead.h b/include/crypto/internal/aead.h > index d482017f3e20..cd8cb1e921b7 100644 > --- a/include/crypto/internal/aead.h > +++ b/include/crypto/internal/aead.h > @@ -39,6 +39,11 @@ static inline void *crypto_aead_ctx(struct crypto_aead *tfm) > return crypto_tfm_ctx(&tfm->base); > } > > +static inline void *crypto_aead_ctx_dma(struct crypto_aead *tfm) > +{ > + return crypto_tfm_ctx_dma(&tfm->base); > +} I wonder, if drivers end up calling this, isn't it easier to do the alignment in crypto_aead_ctx() directly? There are over 300 callers (not sure about the padding though, it may need still driver changes unless we can add it to something like crypto_tfm_alg_alignmask()). Or is the expectation that not all drivers need a DMA alignment? -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel