From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82731C43217 for ; Mon, 28 Nov 2022 23:30:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234691AbiK1XaI (ORCPT ); Mon, 28 Nov 2022 18:30:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234651AbiK1XaF (ORCPT ); Mon, 28 Nov 2022 18:30:05 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E5AE5317D0; Mon, 28 Nov 2022 15:30:04 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 72720614F0; Mon, 28 Nov 2022 23:30:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DA60C433C1; Mon, 28 Nov 2022 23:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669678203; bh=oQ1NXyRzlFb173JCqIW8f1hvYKMUAyVNiwLTT7sk8vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K4aplWhPIs7iqJ6AIaWGsS/0dP/m7uG+YwVnF6ol5zTqZJGcZ61WOk4Lbhse0+rUJ Gcs7nZFG2URkBSY7k4TT0AiQCdsKU9Q+PIQSUvBLVNnw9RCJlg6tXpSPctOSf3qqN4 LDuASRQC7uXiqM6eRsR3yw6eFizPwXCl2GAYZT/SkRYAya3BKcnCV7co0wljbK+r1I s6rzLM6xdc6wB/JllmnInmwYBJz5kVfzB2DYK5zqKRReTfy0g3k3t75UmDZjJZupxf +NuTw3SKSvHwghFW8SyjnGlnFPAb6GzK+Dgp8h4qcj3zDULS1uCqNUaYVXucpNY++/ Pvz2hWUzApaQQ== Date: Tue, 29 Nov 2022 07:20:09 +0800 From: Jisheng Zhang To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Jiri Slaby , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Kroah-Hartman , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, LKML , linux-serial Subject: Re: [PATCH v2 2/9] serial: bflb_uart: add Bouffalolab UART Driver Message-ID: References: <20221127132448.4034-1-jszhang@kernel.org> <20221127132448.4034-3-jszhang@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 28, 2022 at 06:01:28PM +0200, Ilpo Järvinen wrote: > On Mon, 28 Nov 2022, Jisheng Zhang wrote: > > > On Mon, Nov 28, 2022 at 07:10:41AM +0100, Jiri Slaby wrote: > > > On 27. 11. 22, 14:24, Jisheng Zhang wrote: > > > > +static void bflb_uart_tx_chars(struct uart_port *port) > > > > > > Again: > > > > > > Are you unable to use the TX helper? If so: > > > > You know serial subsystem better than me, may I ask for more > > details? For example, > > Besides uart_xmit_advance(), do you expect other TX helpers? If yes, > > can you please list them? > > Please take on look on commit 8275b48b278096edc1e3ea5aa9cf946a10022f79. > The changes following that commit convert some drivers to use the tx > helper so you can look into them to see examples. Thanks a lot for the hint. Will those tx helpers(uart_port_tx, uart_port_tx_limited etc.) be in v6.2-rc1? Or I need to patch based on Jiri's devel branch? Aha, Jiri says "at least uart_xmit_advance > > > > * why? > > > * use uart_advance_xmit() at least. > > > > Do you mean uart_xmit_advance()? in the do while loop below? > > Yes, Jiri had the name wrong. But your code looked like it could use > the tx helper instead. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2BA8DC43217 for ; Mon, 28 Nov 2022 23:30:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XD54prb1uxOb31egbg4qvqnLrZvjzp9ubm7KrZwZ9SQ=; b=j/dnrq/NGMUqCv 2CLWFrHcdn0ZFvgcrxrFie9qxyulSplEqWIic5FJfIdIcdqV1RUo2Vyrcezsyc1RPnZZBwMrYrxmP tcZJqKXze5TGfV5/uSMrCpWuRKY5/IyyBHNQlJtc6DfMA9dx0729usdGaOnWnkn6CeyKFolQBy8Aq ZGYSGYfy72+jO0ThYN8lH9lbWvb8gd649jN2eERcsrJ/wSSK6zIUQydxZ12U+Vmp7hZHtTJmOQBdV n4hwyuuvy0+Ds0yf4tadiKTIqmlwNV+wE6f7sxx1/M+dyHm/hJ/h0vINQErTl0YfcmoL5dES+y8Z0 J6zJm340fe584EbAAd8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oznZi-004mSF-0W; Mon, 28 Nov 2022 23:30:10 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oznZg-004mRE-4J for linux-riscv@lists.infradead.org; Mon, 28 Nov 2022 23:30:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6EB0D614E7; Mon, 28 Nov 2022 23:30:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DA60C433C1; Mon, 28 Nov 2022 23:30:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669678203; bh=oQ1NXyRzlFb173JCqIW8f1hvYKMUAyVNiwLTT7sk8vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K4aplWhPIs7iqJ6AIaWGsS/0dP/m7uG+YwVnF6ol5zTqZJGcZ61WOk4Lbhse0+rUJ Gcs7nZFG2URkBSY7k4TT0AiQCdsKU9Q+PIQSUvBLVNnw9RCJlg6tXpSPctOSf3qqN4 LDuASRQC7uXiqM6eRsR3yw6eFizPwXCl2GAYZT/SkRYAya3BKcnCV7co0wljbK+r1I s6rzLM6xdc6wB/JllmnInmwYBJz5kVfzB2DYK5zqKRReTfy0g3k3t75UmDZjJZupxf +NuTw3SKSvHwghFW8SyjnGlnFPAb6GzK+Dgp8h4qcj3zDULS1uCqNUaYVXucpNY++/ Pvz2hWUzApaQQ== Date: Tue, 29 Nov 2022 07:20:09 +0800 From: Jisheng Zhang To: Ilpo =?utf-8?B?SsOkcnZpbmVu?= Cc: Jiri Slaby , Rob Herring , Conor Dooley , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Greg Kroah-Hartman , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, LKML , linux-serial Subject: Re: [PATCH v2 2/9] serial: bflb_uart: add Bouffalolab UART Driver Message-ID: References: <20221127132448.4034-1-jszhang@kernel.org> <20221127132448.4034-3-jszhang@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221128_153008_237043_C1E5392E X-CRM114-Status: GOOD ( 18.09 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMjgsIDIwMjIgYXQgMDY6MDE6MjhQTSArMDIwMCwgSWxwbyBKw6RydmluZW4g d3JvdGU6Cj4gT24gTW9uLCAyOCBOb3YgMjAyMiwgSmlzaGVuZyBaaGFuZyB3cm90ZToKPiAKPiA+ IE9uIE1vbiwgTm92IDI4LCAyMDIyIGF0IDA3OjEwOjQxQU0gKzAxMDAsIEppcmkgU2xhYnkgd3Jv dGU6Cj4gPiA+IE9uIDI3LiAxMS4gMjIsIDE0OjI0LCBKaXNoZW5nIFpoYW5nIHdyb3RlOgo+ID4g PiA+ICtzdGF0aWMgdm9pZCBiZmxiX3VhcnRfdHhfY2hhcnMoc3RydWN0IHVhcnRfcG9ydCAqcG9y dCkKPiA+ID4gCj4gPiA+IEFnYWluOgo+ID4gPiAKPiA+ID4gQXJlIHlvdSB1bmFibGUgdG8gdXNl IHRoZSBUWCBoZWxwZXI/IElmIHNvOgo+ID4gCj4gPiBZb3Uga25vdyBzZXJpYWwgc3Vic3lzdGVt IGJldHRlciB0aGFuIG1lLCBtYXkgSSBhc2sgZm9yIG1vcmUKPiA+IGRldGFpbHM/IEZvciBleGFt cGxlLAo+ID4gQmVzaWRlcyB1YXJ0X3htaXRfYWR2YW5jZSgpLCBkbyB5b3UgZXhwZWN0IG90aGVy IFRYIGhlbHBlcnM/IElmIHllcywKPiA+IGNhbiB5b3UgcGxlYXNlIGxpc3QgdGhlbT8KPiAKPiBQ bGVhc2UgdGFrZSBvbiBsb29rIG9uIGNvbW1pdCA4Mjc1YjQ4YjI3ODA5NmVkYzFlM2VhNWFhOWNm OTQ2YTEwMDIyZjc5Lgo+IFRoZSBjaGFuZ2VzIGZvbGxvd2luZyB0aGF0IGNvbW1pdCBjb252ZXJ0 IHNvbWUgZHJpdmVycyB0byB1c2UgdGhlIHR4IAo+IGhlbHBlciBzbyB5b3UgY2FuIGxvb2sgaW50 byB0aGVtIHRvIHNlZSBleGFtcGxlcy4KClRoYW5rcyBhIGxvdCBmb3IgdGhlIGhpbnQuIFdpbGwg dGhvc2UgdHggaGVscGVycyh1YXJ0X3BvcnRfdHgsCnVhcnRfcG9ydF90eF9saW1pdGVkIGV0Yy4p IGJlIGluIHY2LjItcmMxPyBPciBJIG5lZWQgdG8gcGF0Y2gKYmFzZWQgb24gSmlyaSdzIGRldmVs IGJyYW5jaD8gQWhhLCBKaXJpIHNheXMgImF0IGxlYXN0IHVhcnRfeG1pdF9hZHZhbmNlCgo+IAo+ ID4gPiAqIHdoeT8KPiA+ID4gKiB1c2UgdWFydF9hZHZhbmNlX3htaXQoKSBhdCBsZWFzdC4KPiA+ IAo+ID4gRG8geW91IG1lYW4gdWFydF94bWl0X2FkdmFuY2UoKT8gaW4gdGhlIGRvIHdoaWxlIGxv b3AgYmVsb3c/Cj4gCj4gWWVzLCBKaXJpIGhhZCB0aGUgbmFtZSB3cm9uZy4gQnV0IHlvdXIgY29k ZSBsb29rZWQgbGlrZSBpdCBjb3VsZCB1c2UgCj4gdGhlIHR4IGhlbHBlciBpbnN0ZWFkLgoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3Yg bWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3Rz LmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo=