All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the usb tree
Date: Wed, 30 Nov 2022 12:58:43 +0200	[thread overview]
Message-ID: <Y4c3YwZqFGhJZN1L@smile.fi.intel.com> (raw)
In-Reply-To: <Y4c11VtMQ64W1U+i@kroah.com>

On Wed, Nov 30, 2022 at 11:52:05AM +0100, Greg KH wrote:
> On Wed, Nov 30, 2022 at 01:18:54PM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> > After merging the usb tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > drivers/xen/unpopulated-alloc.c:17:21: error: 'list_count' redeclared as different kind of symbol
> >    17 | static unsigned int list_count;
> >       |                     ^~~~~~~~~~
> > In file included from include/linux/preempt.h:11,
> >                  from include/linux/spinlock.h:56,
> >                  from include/linux/mmzone.h:8,
> >                  from include/linux/gfp.h:7,
> >                  from drivers/xen/unpopulated-alloc.c:3:
> > include/linux/list.h:662:22: note: previous definition of 'list_count' with type 'size_t(struct list_head *)' {aka 'long unsigned int(struct list_head *)'}
> >   662 | static inline size_t list_count(struct list_head *head)
> >       |                      ^~~~~~~~~~
> > 
> > Caused by commit
> > 
> >   a9efc04cfd05 ("i915: Move list_count() to list.h for broader use")
> > 
> > I have used the usb tree from next-20221129 for today.
> 
> Odd, there is also one in the z2ram.c code but that isn't breaking :(
> 
> Andy, I'm going to revert this series from the USB tree now, please fix
> it up and resend.

Sure. I think I will rename in my series list_count() to list_count_nodes().
This will be less invasive and should solve the issue(s).

$ git grep -n -lw list_count
drivers/block/z2ram.c
drivers/gpu/drm/i915/gt/intel_engine_cs.c
drivers/scsi/hptiop.c
drivers/scsi/hptiop.h
drivers/xen/unpopulated-alloc.c

$ git grep -n -lw list_count_nodes

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2022-11-30 10:58 UTC|newest]

Thread overview: 111+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-30  2:18 linux-next: build failure after merge of the usb tree Stephen Rothwell
2022-11-30 10:52 ` Greg KH
2022-11-30 10:58   ` Andy Shevchenko [this message]
2022-11-30 17:43     ` Andy Shevchenko
2022-11-30 17:46       ` Greg KH
2022-11-30 10:53 ` Andy Shevchenko
  -- strict thread matches above, loose matches on Subject: below --
2023-10-04  2:22 Stephen Rothwell
2023-10-04  6:43 ` Greg KH
2023-10-04  6:47   ` Rohit Agarwal
2023-10-04 12:46     ` Greg KH
2023-10-09  9:18       ` Rohit Agarwal
2023-10-09  9:48         ` Greg KH
2023-10-09  9:49           ` Dmitry Baryshkov
2023-10-12 17:03             ` Rohit Agarwal
2023-10-16 18:43               ` Greg KH
2023-03-27  5:02 Stephen Rothwell
2023-03-27  7:37 ` Greg KH
2022-07-18  6:31 Stephen Rothwell
2022-07-18 20:43 ` Greg KH
2022-07-18 21:41   ` Prashant Malani
2022-07-18 22:08     ` Prashant Malani
2022-07-19  6:50     ` Greg KH
2022-07-19 12:01       ` Greg KH
2022-07-19 17:11         ` Prashant Malani
2022-07-19  6:08   ` Stephen Rothwell
2022-06-14  2:08 Stephen Rothwell
2022-06-14  2:41 ` Neal Liu
2022-06-14  6:30   ` Stephen Rothwell
2022-06-14  6:41 ` Greg KH
2022-06-14  7:52   ` Stephen Rothwell
2022-06-14  8:10     ` Bagas Sanjaya
2022-06-14  9:28       ` Greg KH
2022-06-14 11:11       ` Stephen Rothwell
2022-05-02 11:07 Stephen Rothwell
2022-05-02 11:40 ` Greg KH
2022-05-02 17:09   ` Matthias Kaehlcke
2022-05-02 17:32     ` Greg KH
2022-05-02 17:49       ` Matthias Kaehlcke
2022-05-03 14:49 ` Greg KH
2021-04-12 11:36 Stephen Rothwell
2021-04-12 12:35 ` Greg KH
2021-04-12 12:41   ` Heikki Krogerus
2020-03-16  3:10 Stephen Rothwell
2020-03-16 11:30 ` Thierry Reding
2020-03-16 13:28   ` Greg KH
2020-03-16 13:44     ` Thierry Reding
2019-06-19  6:43 Stephen Rothwell
2019-06-19 14:56 ` Greg KH
2014-12-01  8:19 Stephen Rothwell
2014-12-02 18:12 ` Greg KH
2014-12-03  5:57   ` Kishon Vijay Abraham I
2014-12-03  5:57     ` Kishon Vijay Abraham I
2014-07-24  7:07 Stephen Rothwell
2014-07-24  7:07 ` Stephen Rothwell
2014-07-24  7:07 ` Stephen Rothwell
2014-07-24  7:44 ` Greg KH
2014-07-24  7:44   ` Greg KH
2014-08-06  1:39   ` Stephen Rothwell
2014-08-06  1:39     ` Stephen Rothwell
2014-08-06  4:04     ` Greg KH
2014-08-06  4:04       ` Greg KH
2014-05-29  9:01 Stephen Rothwell
2014-05-29 18:18 ` Greg KH
2014-05-29 18:40   ` Dan Williams
2013-04-18  6:05 Stephen Rothwell
2013-04-18 16:06 ` Joe Perches
2013-03-27  3:41 Stephen Rothwell
2013-03-27  3:51 ` Ming Lei
2013-03-27  4:20   ` Greg KH
2013-03-28 18:04 ` Greg KH
2013-01-28 10:46 Stephen Rothwell
2013-01-28 14:45 ` Greg KH
2013-01-28 14:50   ` Lan Tianyu
2013-01-28 15:28   ` Lan Tianyu
2013-01-28 16:03   ` Lan, Tianyu
2013-01-29 13:41     ` Greg KH
2013-01-29 13:51       ` Lan, Tianyu
2013-01-29 14:59         ` Greg KH
2013-01-21  4:21 Stephen Rothwell
2013-01-21  8:37 ` Lan, Tianyu
2013-01-21  8:37   ` Lan, Tianyu
2012-09-19  4:31 Stephen Rothwell
2012-09-19  7:17 ` Greg KH
2012-09-19 13:59 ` Alan Cox
2012-09-19 14:13   ` Greg KH
2012-05-21  6:22 Stephen Rothwell
2012-05-21 12:56 ` Sarah Sharp
2012-04-27  4:12 Stephen Rothwell
2012-04-27 18:25 ` Greg KH
2010-11-17  2:14 Stephen Rothwell
2010-11-17  4:20 ` Greg KH
2010-11-17 15:56   ` Alan Stern
2010-11-17 15:56     ` Alan Stern
2010-11-17 21:25     ` Greg KH
2010-09-14  2:54 Stephen Rothwell
2010-09-14  4:03 ` Greg KH
2010-09-14  4:08 ` Greg KH
2010-09-14  4:25   ` Stephen Rothwell
2010-09-14 13:26     ` Greg KH
2010-09-15 13:21     ` Mihai Donțu
2010-09-02  3:54 Stephen Rothwell
2010-09-02  4:32 ` Greg KH
2010-09-02  4:36   ` Michał Nazarewicz
2010-09-02  4:51   ` Stephen Rothwell
2010-05-18  7:42 Stephen Rothwell
2010-05-18 13:54 ` Alan Stern
2010-05-18 14:08   ` Greg KH
2010-05-18 21:11   ` Greg KH
2010-05-19 22:49     ` Stephen Rothwell
2010-05-20  6:39       ` Greg KH
2010-05-18 14:00 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4c3YwZqFGhJZN1L@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.