From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16E01C4321E for ; Wed, 30 Nov 2022 17:17:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230433AbiK3RRr (ORCPT ); Wed, 30 Nov 2022 12:17:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45756 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbiK3RR0 (ORCPT ); Wed, 30 Nov 2022 12:17:26 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE31578E1; Wed, 30 Nov 2022 09:16:19 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BB0761D1D; Wed, 30 Nov 2022 17:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2955C433D6; Wed, 30 Nov 2022 17:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669828578; bh=yyriOptA5RWxFE38x5xxIOr09IYVT+AppLmF6+AlJsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iLna48rhaHtiXHKuJdHhpAsQJCkScar0R0IKfCommkdtCEofbO762Dlh5m8nqx5O+ XXzjbc/lT/F4r3Dp1sM+Byeje/txzqS4EqGRaXoSBilQSLWb/nG1HoD24ZkV32EYKQ zUwyUQm4GNoRnZOZiKjPpXaTpB+X97mjqaakC8cwoWGeLO8lcm9feZe0+xEDkrBxup 39NsZSUS1JSRjP6ZV0wYmAFYYMQ7o+17T+w2KeuQCDgr5nDCZ7okdbDF4dhMnXKB0s 3mjTr2VnMqrBRvSaBRUEFSmkphzQO+30ac77g1Xiqh5s9YbyuEYhlgIB/tZy4nWlIN 61YV+oqNT1DaA== Date: Wed, 30 Nov 2022 17:16:11 +0000 From: Mark Brown To: Matthias Kaehlcke Cc: Srinivasa Rao Mandadapu , agross@kernel.org, andersson@kernel.org, lgirdwood@gmail.com, robh+dt@kernel.org, quic_plai@quicinc.com, bgoswami@quicinc.com, perex@perex.cz, tiwai@suse.com, srinivas.kandagatla@linaro.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, swboyd@chromium.org, judyhsiao@chromium.org, devicetree@vger.kernel.org Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops Message-ID: References: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6SJAvmLG8+E8QRmv" Content-Disposition: inline In-Reply-To: X-Cookie: Jesus is my POSTMASTER GENERAL ... Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org --6SJAvmLG8+E8QRmv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 30, 2022 at 05:07:46PM +0000, Matthias Kaehlcke wrote: > On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote: > > Add __maybe_unused tag for system PM ops suspend and resume. > > This is required to fix allmodconfig compilation issue. > > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") > This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add > system suspend/resume PM ops")'. I see you fixed that in v2, but this patch > has already been applied ... with the fixes tag already updated as I was applying it. > Mark, I appreciate you being responsive and picking patches quickly, it might > help though to leave 'external' reviewers at least some time to provide their > feedback :) There's a balance with hanging on for utterly trivial patches to get reviewed, especially in areas where reviews aren't relaible or consistent. --6SJAvmLG8+E8QRmv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOHj9oACgkQJNaLcl1U h9CVTgf/Yk6JQALmBhkO871ntVkBaSxGqlp+3vln0kZMki5ZCf9OWnSUtXUmaUk/ Vmk6rTe1hZ7fKFIcV1q1D6y8OnlRPFTBbCZl8OwPBESHXxFm3kWkiBpReuEr4Lzl x9H399V3j+XaqQH2a7a08ls4Xr+L7pcnP6jIqmTp2H0axiGSWoxxBbIBeNO/BSoF nYuaDojavoLEjR4LOyCgzGu1+E+NFeqrE2lkdlhc9KWObJ5a2iaRgCkXq6SdYJmH wcqu9ldjoiWBJElKShLPW/2OKS2ADP7IVNi8QngsYt6iYO8p58lCOnfI58vhpdwR /LsOtpk0Wtk94W2lYsNxwf3TYWQQbg== =0l3+ -----END PGP SIGNATURE----- --6SJAvmLG8+E8QRmv-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5DB2FC433FE for ; Wed, 30 Nov 2022 17:17:22 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BD03716FD; Wed, 30 Nov 2022 18:16:29 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BD03716FD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1669828639; bh=yyriOptA5RWxFE38x5xxIOr09IYVT+AppLmF6+AlJsU=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=fypm0zikUNYzOK59L0jr6gWevN6Um3Cx4co42u4nDydMlhRq5LG/VYrkGBqqiPZBP InCMonaSRMncYcI3S8fe7t3IoHwC2Qm9ouIWRKYldKvJAmy+93WMNWWVHC5JEmumUn tB6J2eWikODlsi34Z/GI9lEJulilwqkH4F+LLSt4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 49315F80166; Wed, 30 Nov 2022 18:16:29 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id E3C2FF8023A; Wed, 30 Nov 2022 18:16:27 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 96887F80166 for ; Wed, 30 Nov 2022 18:16:21 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 96887F80166 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="iLna48rh" Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1BE4C61D1F; Wed, 30 Nov 2022 17:16:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2955C433D6; Wed, 30 Nov 2022 17:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669828578; bh=yyriOptA5RWxFE38x5xxIOr09IYVT+AppLmF6+AlJsU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iLna48rhaHtiXHKuJdHhpAsQJCkScar0R0IKfCommkdtCEofbO762Dlh5m8nqx5O+ XXzjbc/lT/F4r3Dp1sM+Byeje/txzqS4EqGRaXoSBilQSLWb/nG1HoD24ZkV32EYKQ zUwyUQm4GNoRnZOZiKjPpXaTpB+X97mjqaakC8cwoWGeLO8lcm9feZe0+xEDkrBxup 39NsZSUS1JSRjP6ZV0wYmAFYYMQ7o+17T+w2KeuQCDgr5nDCZ7okdbDF4dhMnXKB0s 3mjTr2VnMqrBRvSaBRUEFSmkphzQO+30ac77g1Xiqh5s9YbyuEYhlgIB/tZy4nWlIN 61YV+oqNT1DaA== Date: Wed, 30 Nov 2022 17:16:11 +0000 From: Mark Brown To: Matthias Kaehlcke Subject: Re: [PATCH] ASoC: qcom: lpass-sc7180: Add maybe_unused tag for system PM ops Message-ID: References: <1669726428-3140-1-git-send-email-quic_srivasam@quicinc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="6SJAvmLG8+E8QRmv" Content-Disposition: inline In-Reply-To: X-Cookie: Jesus is my POSTMASTER GENERAL ... Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, quic_rohkumar@quicinc.com, linux-arm-msm@vger.kernel.org, andersson@kernel.org, tiwai@suse.com, lgirdwood@gmail.com, robh+dt@kernel.org, agross@kernel.org, srinivas.kandagatla@linaro.org, bgoswami@quicinc.com, quic_plai@quicinc.com, swboyd@chromium.org, judyhsiao@chromium.org, linux-kernel@vger.kernel.org, Srinivasa Rao Mandadapu X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --6SJAvmLG8+E8QRmv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Nov 30, 2022 at 05:07:46PM +0000, Matthias Kaehlcke wrote: > On Tue, Nov 29, 2022 at 06:23:48PM +0530, Srinivasa Rao Mandadapu wrote: > > Add __maybe_unused tag for system PM ops suspend and resume. > > This is required to fix allmodconfig compilation issue. > > Fixes: c3bf7699747c ("ASoC: qcom: lpass-sc7280: Add system suspend/resume PM ops") > This is incorrect, it should be '2d68148f8f85 ("ASoC: qcom: lpass-sc7180: Add > system suspend/resume PM ops")'. I see you fixed that in v2, but this patch > has already been applied ... with the fixes tag already updated as I was applying it. > Mark, I appreciate you being responsive and picking patches quickly, it might > help though to leave 'external' reviewers at least some time to provide their > feedback :) There's a balance with hanging on for utterly trivial patches to get reviewed, especially in areas where reviews aren't relaible or consistent. --6SJAvmLG8+E8QRmv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmOHj9oACgkQJNaLcl1U h9CVTgf/Yk6JQALmBhkO871ntVkBaSxGqlp+3vln0kZMki5ZCf9OWnSUtXUmaUk/ Vmk6rTe1hZ7fKFIcV1q1D6y8OnlRPFTBbCZl8OwPBESHXxFm3kWkiBpReuEr4Lzl x9H399V3j+XaqQH2a7a08ls4Xr+L7pcnP6jIqmTp2H0axiGSWoxxBbIBeNO/BSoF nYuaDojavoLEjR4LOyCgzGu1+E+NFeqrE2lkdlhc9KWObJ5a2iaRgCkXq6SdYJmH wcqu9ldjoiWBJElKShLPW/2OKS2ADP7IVNi8QngsYt6iYO8p58lCOnfI58vhpdwR /LsOtpk0Wtk94W2lYsNxwf3TYWQQbg== =0l3+ -----END PGP SIGNATURE----- --6SJAvmLG8+E8QRmv--