All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com, dgilbert@redhat.com
Subject: Re: [PATCH 2/9] ui: Fix silent truncation of numeric keys in HMP sendkey
Date: Thu, 1 Dec 2022 08:14:17 +0000	[thread overview]
Message-ID: <Y4hiWcYyWpZN01st@redhat.com> (raw)
In-Reply-To: <20221201061311.3619052-3-armbru@redhat.com>

On Thu, Dec 01, 2022 at 07:13:04AM +0100, Markus Armbruster wrote:
> Keys are int.  HMP sendkey assigns them from the value strtoul(),
> silently truncating values greater than INT_MAX.  Fix to reject them.
> 
> While there, use qemu_strtoul() instead of strtoul() so checkpatch.pl
> won't complain.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  monitor/hmp-cmds.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>


With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



  reply	other threads:[~2022-12-01  8:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01  6:13 [PATCH 0/9] ui: Move and clean up monitor command code Markus Armbruster
2022-12-01  6:13 ` [PATCH 1/9] ui: Check numeric part of expire_password argument @time properly Markus Armbruster
2022-12-01  8:13   ` Daniel P. Berrangé
2022-12-01  6:13 ` [PATCH 2/9] ui: Fix silent truncation of numeric keys in HMP sendkey Markus Armbruster
2022-12-01  8:14   ` Daniel P. Berrangé [this message]
2022-12-01  6:13 ` [PATCH 3/9] ui: Drop disabled code for SPICE_CHANNEL_WEBDAV Markus Armbruster
2022-12-01  8:49   ` Daniel P. Berrangé
2022-12-01 10:25     ` Markus Armbruster
2022-12-01 12:39     ` Markus Armbruster
2022-12-01 14:34       ` Daniel P. Berrangé
2022-12-01 15:49         ` Markus Armbruster
2022-12-01 18:34           ` Daniel P. Berrangé
2022-12-02  6:52             ` Markus Armbruster
2022-12-01  6:13 ` [PATCH 4/9] ui: Clean up a few things checkpatch.pl would flag later on Markus Armbruster
2022-12-01  8:50   ` Daniel P. Berrangé
2022-12-01  6:13 ` [PATCH 5/9] ui: Move QMP commands from monitor to new ui/ui-qmp-cmds.c Markus Armbruster
2022-12-01  6:38   ` Markus Armbruster
2022-12-11 16:48     ` Markus Armbruster
2022-12-01  8:51   ` Daniel P. Berrangé
2022-12-01  6:13 ` [PATCH 6/9] ui: Move HMP commands from monitor to new ui/ui-hmp-cmds.c Markus Armbruster
2022-12-01  7:14   ` Philippe Mathieu-Daudé
2022-12-01 10:26     ` Markus Armbruster
2022-12-01  8:53   ` Daniel P. Berrangé
2022-12-01  6:13 ` [PATCH 7/9] ui: Improve "change vnc" error reporting Markus Armbruster
2022-12-01  8:56   ` Daniel P. Berrangé
2022-12-01 10:27     ` Markus Armbruster
2022-12-01  6:13 ` [PATCH 8/9] ui: Factor out hmp_change_vnc(), and move to ui/ui-hmp-cmds.c Markus Armbruster
2022-12-01  8:57   ` Daniel P. Berrangé
2022-12-01  6:13 ` [PATCH 9/9] ui: Reduce nesting in hmp_change_vnc() slightly Markus Armbruster
2022-12-01  7:19   ` Philippe Mathieu-Daudé
2022-12-01  8:58   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y4hiWcYyWpZN01st@redhat.com \
    --to=berrange@redhat.com \
    --cc=armbru@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.