From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBF4C4708E for ; Wed, 7 Dec 2022 13:10:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229853AbiLGNKt (ORCPT ); Wed, 7 Dec 2022 08:10:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229850AbiLGNKr (ORCPT ); Wed, 7 Dec 2022 08:10:47 -0500 Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0121C56543 for ; Wed, 7 Dec 2022 05:10:45 -0800 (PST) Received: by mail-ej1-x635.google.com with SMTP id x22so13810540ejs.11 for ; Wed, 07 Dec 2022 05:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ou3Fk2Irg7eK6b3UgZwKC8kZv42UyPRCF5b6cACD0ek=; b=EOcoZ2gqOYri3OdNf2eWcBugPym4istQe0643ZN2qwHGnqbETuuiTVNmINAfKvTCAq +bDAXaLNv7TsiPwYbOLR2UJBEm9gFa9eXl+NP+KWr5NaS/hUrKHZMfHBRQBaseneJRL8 yJLmPKL3nt4+fS0kqHPKwIqyN1kXr8OQCEjjcrslq9b331+DsFCgwFxsSaiTzGGUuJzN qVLohUxswngg5r4Px4ggawMda66lbEyfSz3BDmQQ5j6XAiOVHtfv3TDLToZNUkGFI21L zEHiHNG17eoWeLIZdp1VUcwGX2Z/31FqfO/t7QXvC793WwnmWVDX0+TzAPvd0i+fxtw2 eaBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ou3Fk2Irg7eK6b3UgZwKC8kZv42UyPRCF5b6cACD0ek=; b=iktguCycWSe5UvnPH5GdQGuxWprnZ2ZjXytZgqN0qbEblgWjYOZU0nfdSdY21g8+Su lML+QPp1kug84rl0zSqYpub9pqmo0Lx7Dg1PRCiM8HuOI8jIVve+OqhW756vdHbpPzcI F9Xi5i232M0Lwo4Z9j/fa3Jwkp4K0wZG/z3xh3albdEkpFLqhYDIrwznbvdR7pLGWrt3 zpQmc7koKwA7wHenytgTKBw/Qy7jwTWwBOktHpujfUSJUoSCVf1Env7ouBRE3F1PXSoO 06uZwlnxg/BVqAKw5hSyezg0lVNvh7oP35NDCB9dmhwEweZeuIeH0CN0zp8v2GMUqfU/ z0wg== X-Gm-Message-State: ANoB5pnQlMxxDF+vyc+Wj9KGTV3rwxRphrqV31HOt0YzqDlJJFdH3JXT Hj2EXlSJgef+FP6af/VPrYILHg== X-Google-Smtp-Source: AA0mqf4C2loeS6wG8nSTXbNYNX13ovAzfSYxgB9gpooa66WdeXRavQ7+9LKyrDQmomGPeGEgLzuLaQ== X-Received: by 2002:a17:906:bc4a:b0:7c0:eb36:5225 with SMTP id s10-20020a170906bc4a00b007c0eb365225mr12713164ejv.229.1670418644424; Wed, 07 Dec 2022 05:10:44 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id r1-20020a1709061ba100b00779a605c777sm8488129ejg.192.2022.12.07.05.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 05:10:43 -0800 (PST) Date: Wed, 7 Dec 2022 14:10:42 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: References: <20221202212206.3619bd5f@kernel.org> <20221205161933.663ea611@kernel.org> <20221206092705.108ded86@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221206092705.108ded86@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tue, Dec 06, 2022 at 06:27:05PM CET, kuba@kernel.org wrote: >On Tue, 6 Dec 2022 09:50:19 +0100 Jiri Pirko wrote: >>> Yeah, that's a slightly tricky one. We'd probably need some form >>> of second order association. Easiest if we link it to a devlink >>> instance, I reckon. The OCP clock card does not have netdevs so we >>> can't follow the namespace of netdevs (which would be the second >>> option). >> >> Why do we need this association at all? > >Someone someday may want netns delegation and if we don't have the >support from the start we may break backward compat introducing it. Hmm. Can you imagine a usecase? Link to devlink instance btw might be a problem. In case of mlx5, one dpll instance is going to be created for 2 (or more) PFs. 1 per ConnectX ASIC as there is only 1 clock there. And PF devlinks can come and go, does not make sense to link it to any of them. Thinking about it a bit more, DPLL itself has no network notion. The special case is SyncE pin, which is linked to netdevice. Just a small part of dpll device. And the netdevice already has notion of netns. Isn't that enough? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3C504C4708E for ; Wed, 7 Dec 2022 13:12:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iFcgUIonKIkPcPEvyOQTCjbuRvl1iK0WcD++VkZckCI=; b=BgNNDS7/B65j3u NHTKw1+YZKJJCDrVEkn2NxwrDMwVWDKn+PYzm+b4pVMgZ4K9q3xEILHuo/TpbTsLAZ3HT/BaoaSpa Dlv/g3tbS5oCiIbxVrJ3NAzIZhpptpzr0K6EL2VnowFZp/MfQBaVz+JryKqB95LdonEdFs8VTFFyk lXAhwYe3WI7Cz0k3ghlcYGVSxmfIXXHhSLW1p1qWikNl4fn8tM5Vi8TzhVnZ4fSBpj08AWLxPGyho Qp0e2gp3eS2muMl7LiYrVNawxpXpAqSxSyN+WmZu37pC/PMAeAtNmkdpF5VN1H04ZyEWrVOon0JHz GTo+45j7yJub9aHwJf/Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2uCJ-0037U8-Hw; Wed, 07 Dec 2022 13:10:52 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2uCF-0037PH-1z for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 13:10:49 +0000 Received: by mail-ej1-x62c.google.com with SMTP id m18so12313357eji.5 for ; Wed, 07 Dec 2022 05:10:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ou3Fk2Irg7eK6b3UgZwKC8kZv42UyPRCF5b6cACD0ek=; b=EOcoZ2gqOYri3OdNf2eWcBugPym4istQe0643ZN2qwHGnqbETuuiTVNmINAfKvTCAq +bDAXaLNv7TsiPwYbOLR2UJBEm9gFa9eXl+NP+KWr5NaS/hUrKHZMfHBRQBaseneJRL8 yJLmPKL3nt4+fS0kqHPKwIqyN1kXr8OQCEjjcrslq9b331+DsFCgwFxsSaiTzGGUuJzN qVLohUxswngg5r4Px4ggawMda66lbEyfSz3BDmQQ5j6XAiOVHtfv3TDLToZNUkGFI21L zEHiHNG17eoWeLIZdp1VUcwGX2Z/31FqfO/t7QXvC793WwnmWVDX0+TzAPvd0i+fxtw2 eaBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ou3Fk2Irg7eK6b3UgZwKC8kZv42UyPRCF5b6cACD0ek=; b=8M8c9iXii8TKLsxB9jKAvbzDl4H8guqJ435gmFwWZHrVMfjlXOvelCs2W+y8UQX/7S YWX/KM2jD77RzcCyASSvkwMzADc+3TbvANcu0zQ2ZWtMvNRqtW+xf7qGgPV7bU/8CQlw UiBestd/Ati2c7ioUEM6U+MLVkCi83bLYWR8pw61zZLEbcP28r1Dh3732+Bbcl4/aHzA 7iPgKof6p11E8L06oR4fGaSQtUrk3j2rrObvazIiOuH8NxQcvTaZ4C3XvI1f8XMCdgJ7 1NoGb7Upax+qKzBcrQ1R2kOVmw2WpZvM90ispYF67WNapcxyEY/+M7mwSEyUY4m6ULRP XclA== X-Gm-Message-State: ANoB5plos84ZWtupUmy4Gxr5LuZeJQHT6Xyfus9ZptrMoG4rNZWJgvas zZvnY6zcK7AxxKTvfhGuqsNSgA== X-Google-Smtp-Source: AA0mqf4C2loeS6wG8nSTXbNYNX13ovAzfSYxgB9gpooa66WdeXRavQ7+9LKyrDQmomGPeGEgLzuLaQ== X-Received: by 2002:a17:906:bc4a:b0:7c0:eb36:5225 with SMTP id s10-20020a170906bc4a00b007c0eb365225mr12713164ejv.229.1670418644424; Wed, 07 Dec 2022 05:10:44 -0800 (PST) Received: from localhost (host-213-179-129-39.customer.m-online.net. [213.179.129.39]) by smtp.gmail.com with ESMTPSA id r1-20020a1709061ba100b00779a605c777sm8488129ejg.192.2022.12.07.05.10.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Dec 2022 05:10:43 -0800 (PST) Date: Wed, 7 Dec 2022 14:10:42 +0100 From: Jiri Pirko To: Jakub Kicinski Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: References: <20221202212206.3619bd5f@kernel.org> <20221205161933.663ea611@kernel.org> <20221206092705.108ded86@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221206092705.108ded86@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221207_051047_344377_F74B2A68 X-CRM114-Status: GOOD ( 12.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Tue, Dec 06, 2022 at 06:27:05PM CET, kuba@kernel.org wrote: >On Tue, 6 Dec 2022 09:50:19 +0100 Jiri Pirko wrote: >>> Yeah, that's a slightly tricky one. We'd probably need some form >>> of second order association. Easiest if we link it to a devlink >>> instance, I reckon. The OCP clock card does not have netdevs so we >>> can't follow the namespace of netdevs (which would be the second >>> option). >> >> Why do we need this association at all? > >Someone someday may want netns delegation and if we don't have the >support from the start we may break backward compat introducing it. Hmm. Can you imagine a usecase? Link to devlink instance btw might be a problem. In case of mlx5, one dpll instance is going to be created for 2 (or more) PFs. 1 per ConnectX ASIC as there is only 1 clock there. And PF devlinks can come and go, does not make sense to link it to any of them. Thinking about it a bit more, DPLL itself has no network notion. The special case is SyncE pin, which is linked to netdevice. Just a small part of dpll device. And the netdevice already has notion of netns. Isn't that enough? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel