From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87FF1C4332F for ; Mon, 12 Dec 2022 18:48:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233364AbiLLSsG (ORCPT ); Mon, 12 Dec 2022 13:48:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233423AbiLLSqc (ORCPT ); Mon, 12 Dec 2022 13:46:32 -0500 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D239634D for ; Mon, 12 Dec 2022 10:46:23 -0800 (PST) Received: by mail-qt1-x836.google.com with SMTP id s9so9491440qtx.6 for ; Mon, 12 Dec 2022 10:46:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bbkdJaLOP/vMBqN0DWbeXqbCoBKj/NLdfM5o1UZoPtg=; b=BiflXrMvkQL86DwDsuvp6zeu20P/QSTZLdhXa0elHIV0T/SgbjFyJwd6jvnjoc+f88 41OV0DeplENg78lX4yl9EdygKEKISQ3t6ZyaGuN+6sNg+M9nXKZsRrRw/7x9eMgHOEqr fscuXjvYupahus/kO2WGkZtW5EAaFAD2+yxyOYZ624vIgFYw6UZZFcxVqX22QIi34AU1 /fpStE00hMo0mxyXrXq1Bru6OBSweQ+rKUt66IltQb85gCfaod0CbdDFSZLMueN+uL2v Wcol1WibOeTSE+o+ofOg67Gjf99MJGhFJbqpoO1Uoad11Tht0XVZZApO5oRxve2JL4+w X7zQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=bbkdJaLOP/vMBqN0DWbeXqbCoBKj/NLdfM5o1UZoPtg=; b=edMlPBOUrQhSZuCDHfhZKH43oPW/6Jz8h7g3LpBHCnQUid4anzbRALWbgcAAwwMHfU ZUJ6HHa7UaIe3IzjsJkpGisJ6/8lWX9pg4ndsusC2huZdqnfXfVKhBMW4Q+veP+ZmOG7 OKJIK6okEtv6/9/MEdXqPFIO7+C/reTVwMXaUFnFgxbEoZbhq6CoTeKDxJQ64O3QqWaA ghghsLQV5aV6txdlH24qrsXqgvcuvxreUZz8MMlUguBQM6LS7qHJ0DyLrMPr5XJYGiD6 AkOAl5jADfZJVImgXBYGNnAM+uuvHIRo/OtX3WqwHelPBENR/orvVxlbQp3jv8dEYR9D URnw== X-Gm-Message-State: ANoB5pnEVXQc1EFpBcWF6SXa48UHamx97/QvkmjuABezs6jWrTnxvzWq g5TF8ddO+cqciRcn7lWB/kFe+A== X-Google-Smtp-Source: AA0mqf5lCcZ3o+7m0AnrGOzD69vhiTmFeYO42EEJpCHJDRdGBUIxLCGMJx4ZMqEDyrKPzYFZZSMrqA== X-Received: by 2002:ac8:5c83:0:b0:3a6:c4eb:2e52 with SMTP id r3-20020ac85c83000000b003a6c4eb2e52mr29409230qta.43.1670870782424; Mon, 12 Dec 2022 10:46:22 -0800 (PST) Received: from localhost (cpe-174-109-170-245.nc.res.rr.com. [174.109.170.245]) by smtp.gmail.com with ESMTPSA id i12-20020ac813cc000000b003a50248b89esm6155964qtj.26.2022.12.12.10.46.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Dec 2022 10:46:21 -0800 (PST) Date: Mon, 12 Dec 2022 13:46:19 -0500 From: Josef Bacik To: Christoph Hellwig Cc: Chris Mason , David Sterba , Damien Le Moal , Naohiro Aota , Johannes Thumshirn , Qu Wenruo , Jens Axboe , "Darrick J. Wong" , linux-block@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: consolidate btrfs checksumming, repair and bio splitting v2 Message-ID: References: <20221120124734.18634-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221120124734.18634-1-hch@lst.de> Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Sun, Nov 20, 2022 at 01:47:15PM +0100, Christoph Hellwig wrote: > Hi all, > > this series moves a large amount of duplicate code below btrfs_submit_bio > into what I call the 'storage' layer. Instead of duplicating code to > checksum, check checksums and repair and split bios in all the caller > of btrfs_submit_bio (buffered I/O, direct I/O, compressed I/O, encoded > I/O), the work is done one in a central place, often more optiomal and > without slight changes in behavior. Once that is done the upper layers > also don't need to split the bios for extent boundaries, as the storage > layer can do that itself, including splitting the bios for the zone > append limits for zoned I/O. > > The split work is inspired by an earlier series from Qu, from which it > also reuses a few patches. > > The rebasing against the latest misc-next was a bit painful due to the > various large cleanups, but very little logic changed, so I've kept the > review tags for now, but I'd appreciated another careful round of eyes. > > A git tree is also available: > > git://git.infradead.org/users/hch/misc.git btrfs-bio-split > > Gitweb: > > http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/btrfs-bio-split > You can add Reviewed-by: Josef Bacik to the patches that don't already have my reviewed-by tag. Thanks, Josef