All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Allen Ballway <ballway@chromium.org>
Cc: dtor@chromium.org, benjamin.tissoires@redhat.com,
	jikos@kernel.org, linux-input@vger.kernel.org,
	linux-kernel@vger.kernel.org, rydberg@bitmath.org
Subject: Re: [PATCH v2] HID: multitouch: Add quirks for flipped axes
Date: Mon, 12 Dec 2022 10:46:12 -0800	[thread overview]
Message-ID: <Y5d29JwIxku9ubVb@google.com> (raw)
In-Reply-To: <20221208165145.1.I69657e84c0606b2e5ccfa9fedbf42b7676a1e129@changeid>

On Thu, Dec 08, 2022 at 04:58:36PM +0000, Allen Ballway wrote:
> Certain touchscreen devices, such as the ELAN9034, are oriented
> incorrectly and report touches on opposite points on the X and Y axes.
> For example, a 100x200 screen touched at (10,20) would report (90, 180)
> and vice versa.
> 
> This is fixed by adding device quirks to transform the touch points
> into the correct spaces, from X -> MAX(X) - X, and Y -> MAX(Y) - Y.
> 
> Signed-off-by: Allen Ballway <ballway@chromium.org>
> ---
> V1 -> V2: Address review comments, change to use DMI match. Confirmed
> MT_TOOL_X/Y require transformation and update orientation based on
> flipped axes.

I think you might need to push the DMI match into i2c-hid driver, and
bubble the quirks up here, otherwise if you connect a 2nd USB
touchscreen to such a system will also result in the quirk being applied
to it as far as I understand. In i2c-hid you can make a fine-grained
match on vendor/product and system to limit the quirk to hopefully the
right peripheral.

Thanks.

-- 
Dmitry

  reply	other threads:[~2022-12-12 18:47 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06 17:38 [PATCH] HID: multitouch: Add quirks for flipped axes Allen Ballway
2022-12-06 20:11 ` Dmitry Torokhov
2022-12-08 16:58   ` [PATCH v2] " Allen Ballway
2022-12-12 18:46     ` Dmitry Torokhov [this message]
2022-12-13  1:01       ` [PATCH v3] " Allen Ballway
2022-12-13  9:19         ` Benjamin Tissoires
2022-12-13 16:45           ` Allen Ballway
2022-12-13 21:46             ` Allen Ballway
2022-12-14 18:13               ` [PATCH v4] " Allen Ballway
2022-12-14 22:26                 ` kernel test robot
2022-12-14 22:57                 ` kernel test robot
2022-12-14 23:45                 ` [PATCH v5] " Allen Ballway
2022-12-15  8:02                   ` kernel test robot
2022-12-15 12:35                   ` kernel test robot
2022-12-15 17:26                   ` [PATCH v6] " Allen Ballway
2023-01-10 20:25                     ` [PATCH v6 RESEND] " Allen Ballway
2023-01-18  9:09                       ` Jiri Kosina
2023-01-31 19:46                       ` [PATCH v7] " Allen Ballway
2022-12-15  0:17                 ` [PATCH v4] " kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5d29JwIxku9ubVb@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=ballway@chromium.org \
    --cc=benjamin.tissoires@redhat.com \
    --cc=dtor@chromium.org \
    --cc=jikos@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rydberg@bitmath.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.