All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Zijun Zhao <zijunzhao@google.com>
Cc: Richard Palethorpe <rpalethorpe@suse.com>, ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm
Date: Wed, 14 Dec 2022 21:39:30 +0100	[thread overview]
Message-ID: <Y5o0gkRnpdWb0oCm@pevik> (raw)
In-Reply-To: <Y5o0DF5paB5iox5p@pevik>

Hi Zijun,

also, more suggestions:

Add to each patch:
Signed-off-by: Zijun Zhao <zijunzhao@google.com>
You can notice all commits have this.
https://www.kernel.org/doc/html/latest/process/submitting-patches.html#sign-your-work-the-developer-s-certificate-of-origin
Richie asked you to do this and thus set your pat
https://patchwork.ozlabs.org/project/ltp/patch/20221213003553.3693243-1-zijunzhao@google.com/

Run 'make check-foo' on target you modify (substitute foo for make target).
That checks for common code mistakes and code style.

You can also use this to check your code:
https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2022-12-14 20:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13  0:35 [LTP] [PATCH] signalfd01.c: put the right round bracket to the right place in tst_resm zijunzhao via ltp
2022-12-13 10:46 ` Richard Palethorpe
2022-12-14 20:37   ` Petr Vorel
2022-12-14 20:39     ` Petr Vorel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5o0gkRnpdWb0oCm@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=rpalethorpe@suse.com \
    --cc=zijunzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.