Re: [PATCH v1 0/5] build/libtraceevent resends

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
	Alexey Bayduraev <alexey.v.bayduraev@linux.intel.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	Anshuman Khandual <anshuman.khandual@arm.com>,
	Andi Kleen <ak@linux.intel.com>,
	James Clark <james.clark@arm.com>,
	Sandipan Das <sandipan.das@amd.com>,
	German Gomez <german.gomez@arm.com>, Leo Yan <leo.yan@linaro.org>,
	Timothy Hayes <timothy.hayes@arm.com>,
	Kan Liang <kan.liang@linux.intel.com>,
	Xing Zhengjun <zhengjun.xing@linux.intel.com>,
	Kim Phillips <kim.phillips@amd.com>,
	Riccardo Mancini <rickyman7@gmail.com>,
	Sean Christopherson <seanjc@google.com>,
	shaomin Deng <dengshaomin@cdjrlc.com>,
	Eelco Chaudron <echaudro@redhat.com>,
	Athira Jajeev <atrajeev@linux.vnet.ibm.com>,
	linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org,
	bpf@vger.kernel.org, Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH v1 0/5] build/libtraceevent resends
Date: Wed, 14 Dec 2022 15:00:35 -0300	[thread overview]
Message-ID: <Y5oPQ0Cf/9JGME3n@kernel.org> (raw)
In-Reply-To: <Y5ncNQfPzq8qBP/f@kernel.org>

Em Wed, Dec 14, 2022 at 11:22:45AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Tue, Dec 13, 2022 at 03:26:46PM -0800, Ian Rogers escreveu:
> > All patches on the acme perf/core branch.
> > 
> > Resend incremental build fix python plugin:
> > https://lore.kernel.org/lkml/20221205225940.3079667-4-irogers@google.com/
> > 
> > Break apart and resend libtraceevent debug logging support:
> > https://lore.kernel.org/linux-perf-users/20210923001024.550263-4-irogers@google.com/
> > 
> > Switch "#if HAVE_LIBTRACEEVENT_TEP_FIELD_IS_RELATIVE" to "#if
> > MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION",
> > ensuring trace-event.h is included as discussed on the mailing list.
> > 
> > Resend removal of --group option:
> > https://lore.kernel.org/lkml/20220707195610.303254-1-irogers@google.com/
> 
> Thanks, applied.

Building on arm64:

/home/acme/git/perf/tools/perf/util/evsel.c: In function ‘evsel__rawptr’:
/home/acme/git/perf/tools/perf/util/evsel.c:2787:65: error: operator '<=' has no right operand
 2787 | #if MAKE_LIBTRACEEVENT_VERSION(1, 5, 0) <= LIBTRACEEVENT_VERSION
      |                                                                 ^
error: command '/usr/bin/gcc' failed with exit code 1
cp: cannot stat '/tmp/build/perf/python_ext_build/lib/perf*.so': No such file or directory

make[2]: *** [Makefile.perf:651: /tmp/build/perf/python/perf.cpython-310-aarch64-linux-gnu.so] Error 1
make[2]: *** Waiting for unfinished jobs....
  LD      /tmp/build/perf/libbpf/staticobjs/libbpf-in.o

Trying to fix...
 
> - Arnaldo
> 
>  
> > Ian Rogers (5):
> >   perf build: Fix python/perf.so library's name
> >   perf trace-event: Add libtraceevent version tools to header
> >   libtraceevent: Increase libtraceevent logging when verbose
> >   perf trace-event: Use version check to avoid 1 define
> >   perf evlist: Remove group option.
> > 
> >  tools/perf/Documentation/perf-record.txt      |  4 ----
> >  tools/perf/Documentation/perf-top.txt         |  7 ++----
> >  tools/perf/Makefile.config                    |  8 +++----
> >  tools/perf/Makefile.perf                      |  2 +-
> >  tools/perf/builtin-record.c                   |  2 --
> >  tools/perf/builtin-stat.c                     |  6 -----
> >  tools/perf/builtin-top.c                      |  2 --
> >  tools/perf/builtin-trace.c                    |  2 +-
> >  tools/perf/tests/attr/README                  |  2 --
> >  tools/perf/tests/attr/test-record-group       | 22 -------------------
> >  tools/perf/tests/attr/test-stat-group         | 17 --------------
> >  tools/perf/util/data-convert-bt.c             |  3 ++-
> >  tools/perf/util/debug.c                       | 10 +++++++++
> >  tools/perf/util/evlist.c                      |  2 +-
> >  tools/perf/util/evlist.h                      |  2 --
> >  tools/perf/util/evsel.c                       |  2 +-
> >  tools/perf/util/python.c                      | 10 +--------
> >  tools/perf/util/record.c                      |  7 ------
> >  tools/perf/util/record.h                      |  1 -
> >  .../util/scripting-engines/trace-event-perl.c |  2 +-
> >  .../scripting-engines/trace-event-python.c    |  2 +-
> >  tools/perf/util/sort.c                        |  3 ++-
> >  tools/perf/util/trace-event.h                 | 13 +++++++++++
> >  23 files changed, 39 insertions(+), 92 deletions(-)
> >  delete mode 100644 tools/perf/tests/attr/test-record-group
> >  delete mode 100644 tools/perf/tests/attr/test-stat-group
> > 
> > -- 
> > 2.39.0.314.g84b9a713c41-goog
> 
> -- 
> 
> - Arnaldo

-- 

- Arnaldo