All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
	Christoph Hellwig <hch@infradead.org>,
	Richard Weinberger <richard@nod.at>,
	Matthew Wilcox <willy@infradead.org>,
	Jens Axboe <axboe@kernel.dk>,
	"Martin K. Petersen" <martin.petersen@oracle.com>,
	Chaitanya Kulkarni <kch@nvidia.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>
Subject: Re: [RFC PATCH 2/2] block: add uImage.FIT block partition driver
Date: Thu, 15 Dec 2022 00:11:11 -0800	[thread overview]
Message-ID: <Y5rWn85kmuzeTvPW@infradead.org> (raw)
In-Reply-To: <Y5h0C4iKoeCJgRCb@makrotopia.org>

> +	dev = class_find_device_by_devt(&block_class, devt);
> +	if (!dev)
> +		return -EPROBE_DEFER;

FYI, class_find_device_by_devt is not for driver use.  The only reson
it isn't marker static is because of various legacy driver model and
devtmpfs interactions.

      parent reply	other threads:[~2022-12-15  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-13 12:46 [RFC PATCH 2/2] block: add uImage.FIT block partition driver Daniel Golle
2022-12-13 16:45 ` Randy Dunlap
2022-12-15  8:11 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y5rWn85kmuzeTvPW@infradead.org \
    --to=hch@infradead.org \
    --cc=axboe@kernel.dk \
    --cc=daniel@makrotopia.org \
    --cc=kch@nvidia.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=richard@nod.at \
    --cc=willy@infradead.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.