From: Al Viro <viro@zeniv.linux.org.uk>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Cc: Wei Chen <harperchen1110@gmail.com>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
syzkaller-bugs@googlegroups.com,
syzbot <syzkaller@googlegroups.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>
Subject: Re: possible deadlock in __ata_sff_interrupt
Date: Thu, 15 Dec 2022 15:19:51 +0000 [thread overview]
Message-ID: <Y5s7F/4WKe8BtftB@ZenIV> (raw)
In-Reply-To: <5eff70b8-04fc-ee87-973a-2099a65f6e29@opensource.wdc.com>
On Thu, Dec 15, 2022 at 06:48:20PM +0900, Damien Le Moal wrote:
> The problem is here: sg_rq_end_io() calling kill_fasync(). But at a quick
> glance, this is not the only driver calling kill_fasync() with a spinlock
> held with irq disabled... So there may be a fundamental problem with
> kill_fasync() function if drivers are allowed to do that, or the reverse,
> all drivers calling that function with a lock held with irq disabled need
> to be fixed.
>
> Al, Chuck, Jeff,
>
> Any thought ?
What is the problem with read_lock_irqsave() called with irqs disabled?
read_lock_irq() would have been a bug in such conditions, of course, but
that's not what we use...
next prev parent reply other threads:[~2022-12-15 15:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-13 15:09 possible deadlock in __ata_sff_interrupt Wei Chen
2022-12-15 9:48 ` Damien Le Moal
2022-12-15 15:19 ` Al Viro [this message]
2022-12-16 1:44 ` Damien Le Moal
2022-12-16 3:41 ` Al Viro
2022-12-16 11:26 ` Linus Torvalds
2022-12-16 23:39 ` Al Viro
2022-12-16 23:54 ` Boqun Feng
2022-12-17 1:59 ` Al Viro
2022-12-17 3:25 ` Boqun Feng
2022-12-17 2:31 ` Linus Torvalds
2022-12-17 2:59 ` Boqun Feng
2022-12-17 3:05 ` Al Viro
2022-12-17 4:41 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5s7F/4WKe8BtftB@ZenIV \
--to=viro@zeniv.linux.org.uk \
--cc=chuck.lever@oracle.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=harperchen1110@gmail.com \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=syzkaller-bugs@googlegroups.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.