From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD928C4332F for ; Fri, 16 Dec 2022 11:56:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229873AbiLPL4r (ORCPT ); Fri, 16 Dec 2022 06:56:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50140 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230299AbiLPL4m (ORCPT ); Fri, 16 Dec 2022 06:56:42 -0500 Received: from smtp-out-08.comm2000.it (smtp-out-08.comm2000.it [212.97.32.78]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 651F61CB0D for ; Fri, 16 Dec 2022 03:56:40 -0800 (PST) Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-08.comm2000.it (Postfix) with ESMTPSA id ED4B24200F5; Fri, 16 Dec 2022 12:56:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1671191799; bh=rYdWMkBty+7sIfkFZSLWNpZmYOUxcedcHuAWanI1FXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dBJHTHQDwvANj6HN2VCtod99bN4aj+7Tk3aA57aQzNZyZdrr3JpHmfvDtqc2uY7GL 3aMzUfM1fxMAC83PdC0wajI4zWh6Z/k86tz/KPIgIvonGVOAUgZ96vnce/o0VcAa4j z4PKTz4cwUjxHIPfWvO6YUOJ6qvcQsggcZQI3Lr8JZUWxVsvPsPZ3sOzaRVTWSzCps Vxxx823tCWgYGQ/e5M20DPh9lMcryauyY80m/F8MGJbvQMiQSqMANvS9cMJkd7CYXl +PA5urSmFDlf9JqVp6m6ShmxA4V+1Mf4kIx4EfS8t0MtqmXG8h51wup+GkVQhtHV5l xHqan1O/oLavw== Date: Fri, 16 Dec 2022 12:56:35 +0100 From: Francesco Dolcini To: Marek Vasut Cc: Francesco Dolcini , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , Peng Fan , Rob Herring , Shawn Guo , NXP Linux Team , devicetree@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards Message-ID: References: <20221215232137.144256-1-marex@denx.de> <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Dec 16, 2022 at 12:43:35PM +0100, Marek Vasut wrote: > On 12/16/22 08:18, Francesco Dolcini wrote: > > Hello Marek > > Hi, > > > On Fri, Dec 16, 2022 at 12:21:34AM +0100, Marek Vasut wrote: > > > The Toradex Verdin based boards have compatible string in the form: > > > "vendor,custom-board", "toradex,som", "fsl,soc" > > > Split the binding entry so this triplet can be matched on. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Fabio Estevam > > > Cc: Francesco Dolcini > > > Cc: Krzysztof Kozlowski > > > Cc: Marcel Ziswiler > > > Cc: Peng Fan > > > Cc: Rob Herring > > > Cc: Shawn Guo > > > Cc: NXP Linux Team > > > Cc: devicetree@vger.kernel.org > > > To: linux-arm-kernel@lists.infradead.org > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 05b5276a0e14c..8dda0e25b99e4 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -830,7 +830,6 @@ properties: > > > - innocomm,wb15-evk # i.MX8MM Innocomm EVK board with WB15 SoM > > > - kontron,imx8mm-sl # i.MX8MM Kontron SL (N801X) SOM > > > - kontron,imx8mm-osm-s # i.MX8MM Kontron OSM-S (N802X) SOM > > > - - menlo,mx8menlo # i.MX8MM Menlo board with Verdin SoM > > > - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules > > > - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini Modules without Wi-Fi / BT > > > - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules > > > @@ -838,6 +837,12 @@ properties: > > > - prt,prt8mm # i.MX8MM Protonic PRT8MM Board > > > - const: fsl,imx8mm > > > + - description: Verdin iMX8M Mini Module based Boards > > I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong? > > Partly wrong, look at 4/4 patch in this series for how this would grow once > more boards based on the Verdin SoM would be added. The first -const: would > turn into enum, the remaining two -const: would remain (different carrier > board, same SoM, same SoC). Shouldn't you than add it to existing `Toradex Boards with Verdin iMX8M Mini Modules` one as a new entry to the existing enum? Maybe the current name is not ideal if we do something like that and should become `Boards using Toradex Verdin iMX8M Mini Modules` if we add menlo to it ? Francesco From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D0BBAC4332F for ; Fri, 16 Dec 2022 11:57:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PZ8bRtU0yUwQN6PYg8kgSbAnIABsnrkXsssypFW9sWk=; b=yQji1u193vMOLT D0/FGZ7lF+5NfC2izq+HS0xpZvkhEfcao58XNJ8usvYn3MNTyTWWEybtORJk4DoxSDEoQBeV5LBeH Gqn4DRBEvmf+vmfFeHUyKSkTgqrzSV0ZUO8HO+7KlCPh6metxkS/kLPPpzOBAzYM3IbovErUNIh6W qy6oFDt8IcDbtUcvkj6UkMZwKLlIsovDXoOXLHvnwsIr5bKb0Ki3xdcTFTDZjvdP7kA0o2ON3QFDj xJS5E3crw3xyDHxtSE9V0jzuDfP3YeDQEb8Rl2M2WrMsh7i7Eh5M/Ao3Fyv37f/MkGM6YpHP46EWQ hR66aqd84zakmfyJnmVw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p69Kb-00Einc-HX; Fri, 16 Dec 2022 11:56:49 +0000 Received: from smtp-out-08.comm2000.it ([212.97.32.78]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p69KY-00Eijz-PO for linux-arm-kernel@lists.infradead.org; Fri, 16 Dec 2022 11:56:48 +0000 Received: from francesco-nb.int.toradex.com (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: francesco@dolcini.it) by smtp-out-08.comm2000.it (Postfix) with ESMTPSA id ED4B24200F5; Fri, 16 Dec 2022 12:56:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mailserver.it; s=mailsrv; t=1671191799; bh=rYdWMkBty+7sIfkFZSLWNpZmYOUxcedcHuAWanI1FXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=dBJHTHQDwvANj6HN2VCtod99bN4aj+7Tk3aA57aQzNZyZdrr3JpHmfvDtqc2uY7GL 3aMzUfM1fxMAC83PdC0wajI4zWh6Z/k86tz/KPIgIvonGVOAUgZ96vnce/o0VcAa4j z4PKTz4cwUjxHIPfWvO6YUOJ6qvcQsggcZQI3Lr8JZUWxVsvPsPZ3sOzaRVTWSzCps Vxxx823tCWgYGQ/e5M20DPh9lMcryauyY80m/F8MGJbvQMiQSqMANvS9cMJkd7CYXl +PA5urSmFDlf9JqVp6m6ShmxA4V+1Mf4kIx4EfS8t0MtqmXG8h51wup+GkVQhtHV5l xHqan1O/oLavw== Date: Fri, 16 Dec 2022 12:56:35 +0100 From: Francesco Dolcini To: Marek Vasut Cc: Francesco Dolcini , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Francesco Dolcini , Krzysztof Kozlowski , Marcel Ziswiler , Peng Fan , Rob Herring , Shawn Guo , NXP Linux Team , devicetree@vger.kernel.org Subject: Re: [PATCH 1/4] dt-bindings: arm: Split i.MX8M Mini Toradex Verdin based boards Message-ID: References: <20221215232137.144256-1-marex@denx.de> <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <3145f5ee-5e25-c105-5aa9-6c76dc531173@denx.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221216_035646_998090_B8434CDA X-CRM114-Status: GOOD ( 21.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 16, 2022 at 12:43:35PM +0100, Marek Vasut wrote: > On 12/16/22 08:18, Francesco Dolcini wrote: > > Hello Marek > > Hi, > > > On Fri, Dec 16, 2022 at 12:21:34AM +0100, Marek Vasut wrote: > > > The Toradex Verdin based boards have compatible string in the form: > > > "vendor,custom-board", "toradex,som", "fsl,soc" > > > Split the binding entry so this triplet can be matched on. > > > > > > Signed-off-by: Marek Vasut > > > --- > > > Cc: Fabio Estevam > > > Cc: Francesco Dolcini > > > Cc: Krzysztof Kozlowski > > > Cc: Marcel Ziswiler > > > Cc: Peng Fan > > > Cc: Rob Herring > > > Cc: Shawn Guo > > > Cc: NXP Linux Team > > > Cc: devicetree@vger.kernel.org > > > To: linux-arm-kernel@lists.infradead.org > > > --- > > > Documentation/devicetree/bindings/arm/fsl.yaml | 7 ++++++- > > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > > > index 05b5276a0e14c..8dda0e25b99e4 100644 > > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > > > @@ -830,7 +830,6 @@ properties: > > > - innocomm,wb15-evk # i.MX8MM Innocomm EVK board with WB15 SoM > > > - kontron,imx8mm-sl # i.MX8MM Kontron SL (N801X) SOM > > > - kontron,imx8mm-osm-s # i.MX8MM Kontron OSM-S (N802X) SOM > > > - - menlo,mx8menlo # i.MX8MM Menlo board with Verdin SoM > > > - toradex,verdin-imx8mm # Verdin iMX8M Mini Modules > > > - toradex,verdin-imx8mm-nonwifi # Verdin iMX8M Mini Modules without Wi-Fi / BT > > > - toradex,verdin-imx8mm-wifi # Verdin iMX8M Mini Wi-Fi / BT Modules > > > @@ -838,6 +837,12 @@ properties: > > > - prt,prt8mm # i.MX8MM Protonic PRT8MM Board > > > - const: fsl,imx8mm > > > + - description: Verdin iMX8M Mini Module based Boards > > I would expect here something like "i.MX8MM Menlo board with Verdin SoM", am I wrong? > > Partly wrong, look at 4/4 patch in this series for how this would grow once > more boards based on the Verdin SoM would be added. The first -const: would > turn into enum, the remaining two -const: would remain (different carrier > board, same SoM, same SoC). Shouldn't you than add it to existing `Toradex Boards with Verdin iMX8M Mini Modules` one as a new entry to the existing enum? Maybe the current name is not ideal if we do something like that and should become `Boards using Toradex Verdin iMX8M Mini Modules` if we add menlo to it ? Francesco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel