All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Delevoryas <peter@pjd.dev>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Steven Lee" <steven_lee@aspeedtech.com>,
	"Peter Delevoryas" <pdel@meta.com>,
	qemu-arm@nongnu.org, "Cleber Rosa" <crosa@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Beraldo Leal" <bleal@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Troy Lee" <troy_lee@aspeedtech.com>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"Joel Stanley" <joel@jms.id.au>,
	"Cédric Le Goater" <clg@kaod.org>,
	"Peter Delevoryas" <pdel@fb.com>,
	"Jamin Lin" <jamin_lin@aspeedtech.com>
Subject: Re: [PATCH 8/9] hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F
Date: Thu, 29 Dec 2022 12:55:30 -0800	[thread overview]
Message-ID: <Y63+wm37Nl6tNXY+@pdel-mbp.dhcp.thefacebook.com> (raw)
In-Reply-To: <20221229152325.32041-9-philmd@linaro.org>

On Thu, Dec 29, 2022 at 04:23:24PM +0100, Philippe Mathieu-Daudé wrote:
> This SoC uses a Cortex-M4F. QEMU only implements a M4,
> which is good enough. Add a TODO note in case the M4F
> is added.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Oh, yeah good to have a note of this somewhere.

Reviewed-by: Peter Delevoryas <peter@pjd.dev>

> ---
>  hw/arm/aspeed_ast10x0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed_ast10x0.c b/hw/arm/aspeed_ast10x0.c
> index 02636705b6..788827ca9d 100644
> --- a/hw/arm/aspeed_ast10x0.c
> +++ b/hw/arm/aspeed_ast10x0.c
> @@ -421,7 +421,7 @@ static void aspeed_soc_ast1030_class_init(ObjectClass *klass, void *data)
>      dc->realize = aspeed_soc_ast1030_realize;
>  
>      sc->name = "ast1030-a1";
> -    sc->cpu_type = ARM_CPU_TYPE_NAME("cortex-m4");
> +    sc->cpu_type = ARM_CPU_TYPE_NAME("cortex-m4"); /* TODO cortex-m4f */
>      sc->silicon_rev = AST1030_A1_SILICON_REV;
>      sc->sram_size = 768 * KiB;
>      sc->secsram_size = 9 * KiB;
> -- 
> 2.38.1
> 


  reply	other threads:[~2022-12-29 21:03 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 15:23 [PATCH 0/9] hw/arm/aspeed_ast10x0: Map more peripherals & few more fixes Philippe Mathieu-Daudé
2022-12-29 15:23 ` [PATCH 1/9] hw/watchdog/wdt_aspeed: Map the whole MMIO range Philippe Mathieu-Daudé
2022-12-29 20:42   ` Peter Delevoryas
2022-12-30  7:32     ` Philippe Mathieu-Daudé
2023-01-02 10:34       ` Cédric Le Goater
2023-01-02 10:21   ` Cédric Le Goater
2022-12-29 15:23 ` [PATCH 2/9] hw/arm/aspeed: Use the IEC binary prefix definitions Philippe Mathieu-Daudé
2022-12-29 20:42   ` Peter Delevoryas
2022-12-29 15:23 ` [PATCH 3/9] hw/arm/aspeed_ast10x0: Add various unimplemented peripherals Philippe Mathieu-Daudé
2022-12-29 20:44   ` Peter Delevoryas
2022-12-29 15:23 ` [PATCH 4/9] hw/arm/aspeed_ast10x0: Map I3C peripheral Philippe Mathieu-Daudé
2022-12-29 20:46   ` Peter Delevoryas
2022-12-30  7:07     ` Philippe Mathieu-Daudé
2022-12-29 15:23 ` [PATCH 5/9] hw/arm/aspeed_ast10x0: Map the secure SRAM Philippe Mathieu-Daudé
2022-12-29 20:50   ` Peter Delevoryas
2022-12-29 15:23 ` [PATCH 6/9] hw/arm/aspeed_ast10x0: Map HACE peripheral Philippe Mathieu-Daudé
2022-12-29 20:52   ` Peter Delevoryas
2022-12-30  8:13     ` Philippe Mathieu-Daudé
2022-12-30 20:23       ` Peter Delevoryas
2022-12-29 15:23 ` [PATCH 7/9] hw/misc/aspeed_hace: Do not crash if address_space_map() failed Philippe Mathieu-Daudé
2022-12-29 20:54   ` Peter Delevoryas
2022-12-29 15:23 ` [PATCH 8/9] hw/arm/aspeed_ast10x0: Add TODO comment to use Cortex-M4F Philippe Mathieu-Daudé
2022-12-29 20:55   ` Peter Delevoryas [this message]
2022-12-29 15:23 ` [PATCH 9/9] tests/avocado: Test Aspeed Zephyr SDK v00.01.08 on AST1030 board Philippe Mathieu-Daudé
2022-12-29 20:56   ` Peter Delevoryas
2022-12-29 20:37 ` [PATCH 0/9] hw/arm/aspeed_ast10x0: Map more peripherals & few more fixes Peter Delevoryas
2023-01-02 10:55 ` Cédric Le Goater

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y63+wm37Nl6tNXY+@pdel-mbp.dhcp.thefacebook.com \
    --to=peter@pjd.dev \
    --cc=andrew@aj.id.au \
    --cc=bleal@redhat.com \
    --cc=clg@kaod.org \
    --cc=crosa@redhat.com \
    --cc=jamin_lin@aspeedtech.com \
    --cc=joel@jms.id.au \
    --cc=pdel@fb.com \
    --cc=pdel@meta.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=steven_lee@aspeedtech.com \
    --cc=troy_lee@aspeedtech.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.