From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB135C3DA7A for ; Tue, 20 Dec 2022 21:28:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234091AbiLTV2r (ORCPT ); Tue, 20 Dec 2022 16:28:47 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233971AbiLTV2q (ORCPT ); Tue, 20 Dec 2022 16:28:46 -0500 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6C071EAE0 for ; Tue, 20 Dec 2022 13:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Uk//xnFF9s+wkGimPH4UmEyWe6edFnqnttAQCxTAmrY=; b=WlQYN464FuPztf/O685AkO1e7z MhMsMYLRl9iJR2hOyX7jUDLiENSQDePxD5Syow3icZ4W97vlqqTc33Hmf+BXsukBlJXGULFrBvmd3 sLg4JVDrlWEFXpbbdiGOzguSNxvU0i39nB2xf5VZ+bpB1NRRVzxOm5iRPgp/O2gCHYPsUP+sEMb3u XX+HLisgIQa75oMOl7CW4pYuPLM+2HslUbo5ck9MCROzfx/CzKN5fE4ynSlCu1BJWxDma/GleczO3 QqDM/kYQp2zHI7q9dapvDhkySipq/2UhNkY4gn3GJZYu2aeQm8XQskJV8AmEO0LS0TGCGde215iKp trhlx9Xg==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7kAF-004LtL-RQ; Tue, 20 Dec 2022 21:28:43 +0000 Date: Tue, 20 Dec 2022 13:28:43 -0800 From: Luis Chamberlain To: Bart Van Assche Cc: osandov@fb.com, linux-block@vger.kernel.org Subject: Re: [PATCH v2] blktests: replace module removal with patient module removal Message-ID: References: <1293a7e7-71d0-117e-1a4f-8ccfc609bc43@acm.org> <71af1a93-1950-b480-afbb-d61b6590f6fe@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <71af1a93-1950-b480-afbb-d61b6590f6fe@acm.org> Sender: Luis Chamberlain Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, May 11, 2022 at 11:22:52AM -0700, Bart Van Assche wrote: > On 5/11/22 10:44, Luis Chamberlain wrote: > > I suspect you ran into the issue of the refcnt being bumped by anything > > multipathd tried, and not being able to remove the module, but if it is > > adding *new* mpath devices that would seem like a bug which we'd need to > > address. The point to the patient module removal is to keep on trying > > until the recnt is 0 and if that fails wait and keep trying, until the > > the timeout. Anytihng userspace does, say multipathd does, like > > bdev_open(), would be yielded to. > > > > So I'd like to keep this change as it is exactly the sort of hack I am > > chasing after with this crusade. > > > > Let me know how you'd like to proceed so I can punt a v3. > > Please implement the patient module removal and the stop_srp_ini() behavior > changes as separate patches such that the stop_srp_ini() behavioral changes > can be reverted easily in case these would trigger a regression. I had dropped the ball here, because well, it takes a bit of time to re-test everything. And also just around this time I was also ironing out how to properly automate testing for srp. That's all done now and I finally had time to re-test so will send a v3 out shortly. Luis