From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tom Saeger <tom.saeger@oracle.com>
Cc: stable@vger.kernel.org, linux-kbuild@vger.kernel.org,
Nick Desaulniers <ndesaulniers@google.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
Michal Marek <michal.lkml@markovi.net>,
Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH 5.15 5.10 5.4 v2] kbuild: fix Build ID if CONFIG_MODVERSIONS
Date: Thu, 22 Dec 2022 07:01:11 +0100 [thread overview]
Message-ID: <Y6Pyp+7Udn6x/UVg@kroah.com> (raw)
In-Reply-To: <20221221205210.6oolnwkzqo2d6q5h@oracle.com>
On Wed, Dec 21, 2022 at 02:52:10PM -0600, Tom Saeger wrote:
> On Wed, Dec 21, 2022 at 05:31:51PM +0100, Greg Kroah-Hartman wrote:
> > On Thu, Dec 15, 2022 at 04:18:18PM -0700, Tom Saeger wrote:
> > > Backport of:
> > > commit 0d362be5b142 ("Makefile: link with -z noexecstack --no-warn-rwx-segments")
> > > breaks arm64 Build ID when CONFIG_MODVERSIONS=y for all kernels
> > > from: commit e4484a495586 ("Merge tag 'kbuild-fixes-v5.0' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild")
> > > until: commit df202b452fe6 ("Merge tag 'kbuild-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild")
> > >
> > > Linus's tree doesn't have this issue since 0d362be5b142 was merged
> > > after df202b452fe6 which included:
> > > commit 7b4537199a4a ("kbuild: link symbol CRCs at final link, removing CONFIG_MODULE_REL_CRCS")
> >
> > Why can't we add this one instead of a custom change?
>
> I quickly abandoned that route - there are too many dependencies.
How many? Why? Whenever we add a "this is not upstream" patch, 90% of
the time it is incorrect and causes problems (merge issues included.)
So please please please let's try to keep in sync with what is in
Linus's tree.
thanks,
greg k-h
next prev parent reply other threads:[~2022-12-22 6:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 23:18 [PATCH 5.15 5.10 5.4 v2] kbuild: fix Build ID if CONFIG_MODVERSIONS Tom Saeger
2022-12-21 16:31 ` Greg Kroah-Hartman
2022-12-21 20:52 ` Tom Saeger
2022-12-22 6:01 ` Greg Kroah-Hartman [this message]
2023-01-09 18:36 ` Tom Saeger
2023-01-10 6:58 ` Masahiro Yamada
2023-01-10 16:27 ` Tom Saeger
2023-01-12 12:00 ` Greg Kroah-Hartman
2023-01-12 21:20 ` Tom Saeger
2023-01-13 15:06 ` Tom Saeger
2023-01-14 13:53 ` Greg Kroah-Hartman
2023-01-17 23:50 ` Tom Saeger
2023-01-18 6:14 ` Greg Kroah-Hartman
2023-01-22 14:21 ` Greg Kroah-Hartman
2023-01-22 14:40 ` Greg Kroah-Hartman
2023-01-23 7:26 ` Greg Kroah-Hartman
2022-12-21 19:56 ` Nick Desaulniers
2022-12-21 20:42 ` Tom Saeger
2022-12-21 21:23 ` Nick Desaulniers
2022-12-21 23:54 ` Tom Saeger
2022-12-22 0:03 ` Tom Saeger
2022-12-31 11:53 ` Greg Kroah-Hartman
2023-01-05 20:30 ` Tom Saeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6Pyp+7Udn6x/UVg@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=stable@vger.kernel.org \
--cc=tom.saeger@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.