From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 154B2C4332F for ; Fri, 23 Dec 2022 12:48:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbiLWMsN (ORCPT ); Fri, 23 Dec 2022 07:48:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230019AbiLWMsM (ORCPT ); Fri, 23 Dec 2022 07:48:12 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E1E961D309; Fri, 23 Dec 2022 04:48:10 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7888960A6F; Fri, 23 Dec 2022 12:48:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A861C433D2; Fri, 23 Dec 2022 12:48:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671799689; bh=W7+OtaE26Rq0/9/+5FJNb9Z0lJvsOAo1uMNomxGwQJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qJcXi3fucQHnXd3o2I2+N9Bs26xTYvCP7xNkNb1vZTDpUyn7247GyYGhN7LKbKGTo BoPp344HafMfcLwcuEXRTM4M3RkewjBouGm+sps/dyrLpq4a/dLrkY4bMhcp9nkBJg OQQp6rihXVpHKPLgAsG9JYJnXgR/ssZGZkTKrxDxJNdDthG4VmwedvYCJOpdorq/VZ 7PNkFYNIMMZ973yd1g+kkUiZCzGkY3+18uPZtSHef50p5LQNQGAeqpQzuU+NLZu1wA pyBltWG3/f6Ud/MN/jz6GeuwTOmXljBt5Pt6BxJ2Wx41BX/FoSWVZHJ+lnizrL012K fG3osmZuvbdJg== Date: Fri, 23 Dec 2022 12:48:03 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Chuanhong Guo , linux-leds@vger.kernel.org, Pavel Machek , Rob Herring , Krzysztof Kozlowski , Stanislav Jakubek , Linus Walleij , Shawn Guo , Johan Hovold , Bjorn Andersson , Marijn Suijten , Sven Schwermer , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v4 2/3] dt-bindings: leds: add worldsemi,ws2812b Message-ID: References: <20221212045558.69602-1-gch981213@gmail.com> <20221212045558.69602-3-gch981213@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Mon, 12 Dec 2022, Krzysztof Kozlowski wrote: > On 12/12/2022 05:55, Chuanhong Guo wrote: > > Add dt binding schema for WorldSemi WS2812B driven using SPI > > bus. > > > > Signed-off-by: Chuanhong Guo > > --- > > Changes since v1: > > remove linux driver reference from description > > remove some obvious descriptions > > fix unit address regex in multi-led property > > drop various minItems > > add maxItems = 1 to reg > > fix node names and property orders in binding example > > drop -spi from compatible string > > add default-brightness > > > > Change since v2: > > drop "this patch" from commit message > > rename leds to led-controller > > drop default-brightness and default-intensity > > > > Change since v3: > > reword commit title > > > > .../bindings/leds/worldsemi,ws2812b.yaml | 116 ++++++++++++++++++ > > 1 file changed, 116 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > > > > diff --git a/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > > new file mode 100644 > > index 000000000000..548c05ac3d31 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > > @@ -0,0 +1,116 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/leds/worldsemi,ws2812b.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: WS2812B LEDs driven using SPI > > + > > +maintainers: > > + - Chuanhong Guo > > + > > +description: | > > + WorldSemi WS2812B is a individually addressable LED chip that can be chained > > + together and controlled individually using a single wire. > > + This binding describes a chain of WS2812B LEDs connected to the SPI MOSI pin. > > + Typical setups includes connecting the data pin of the LED chain to MOSI as > > + the only device or using CS and MOSI with a tri-state voltage-level shifter > > + for the data pin. > > + The SPI frequency needs to be 2.105MHz~2.85MHz for the timing to be correct > > + and the controller needs to send all the bytes continuously. > > + > > +allOf: > > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > > + > > +properties: > > + compatible: > > + const: worldsemi,ws2812b > > + > > + reg: > > + maxItems: 1 > > + > > + spi-max-frequency: > > + minimum: 2105000 > > + maximum: 2850000 > > + > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 0 > > + > > +patternProperties: > > + "^multi-led@[0-9a-f]+$": > > + type: object > > + $ref: leds-class-multicolor.yaml# > > + unevaluatedProperties: false > > + > > + properties: > > + color-index: > > + description: | > > + A 3-item array specifying color of each components in this LED. It > > + should be one of the LED_COLOR_ID_* prefixed definitions from the > > + header include/dt-bindings/leds/common.h. Defaults to > > + > > + if unspecified. > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > + maxItems: 3 > > In general I am fine with it, although there is still question for > adding more multi-color defines in binding headers to replace this > property - GRB/RBG/GBR and even more for RGBW. > > Pavel, Lee, any thoughts from your side? Nothing from me yet. If Pavel doesn't respond soon, I'll get around to doing a full sweep after the merge-window has closed. Actually, most likely the new year now. -- Lee Jones [李琼斯]