From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <kbusch@meta.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
Tony Battersby <tonyb@cybernetics.com>,
Kernel Team <kernel-team@meta.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCHv2 08/11] dmapool: consolidate page initialization
Date: Fri, 23 Dec 2022 08:35:43 -0800 [thread overview]
Message-ID: <Y6XY35c4nBLpLpJT@infradead.org> (raw)
In-Reply-To: <20221216201625.2362737-9-kbusch@meta.com>
> + page->in_use = 0;
> + page->offset = 0;
This move makes total sense to me.
> return NULL;
>
> spin_lock_irqsave(&pool->lock, flags);
> -
> - list_add(&page->page_list, &pool->page_list);
> + pool_initialise_page(pool, page);
.. but this now moves all of pool_initialise_page inside the
pool->lock critical section. Is that really a good idea?
next prev parent reply other threads:[~2022-12-23 16:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 20:16 [PATCHv2 00/11] dmapool enhancements Keith Busch
2022-12-16 20:16 ` [PATCHv2 01/11] dmapool: add alloc/free performance test Keith Busch
2022-12-16 20:16 ` [PATCHv2 02/11] dmapool: remove checks for dev == NULL Keith Busch
2022-12-23 16:27 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 03/11] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2022-12-23 16:28 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 04/11] dmapool: cleanup integer types Keith Busch
2022-12-23 16:29 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 05/11] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc Keith Busch
2022-12-23 16:29 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 06/11] dmapool: move debug code to own functions Keith Busch
2022-12-23 16:31 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 07/11] dmapool: rearrange page alloc failure handling Keith Busch
2022-12-23 16:31 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 08/11] dmapool: consolidate page initialization Keith Busch
2022-12-23 16:35 ` Christoph Hellwig [this message]
2022-12-16 20:16 ` [PATCHv2 09/11] dmapool: simplify freeing Keith Busch
2022-12-23 16:38 ` Christoph Hellwig
2022-12-27 20:21 ` Keith Busch
2022-12-16 20:16 ` [PATCHv2 10/11] dmapool: don't memset on free twice Keith Busch
2022-12-23 16:39 ` Christoph Hellwig
2022-12-16 20:16 ` [PATCHv2 11/11] dmapool: link blocks across pages Keith Busch
2022-12-17 2:39 ` kernel test robot
2022-12-17 3:49 ` kernel test robot
2022-12-23 16:58 ` Christoph Hellwig
2022-12-23 17:08 ` Tony Battersby
2022-12-23 17:15 ` Christoph Hellwig
2022-12-24 14:55 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y6XY35c4nBLpLpJT@infradead.org \
--to=hch@infradead.org \
--cc=kbusch@kernel.org \
--cc=kbusch@meta.com \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tonyb@cybernetics.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.