From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 422BDC46467 for ; Tue, 27 Dec 2022 03:57:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229775AbiL0D5u (ORCPT ); Mon, 26 Dec 2022 22:57:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48518 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229447AbiL0D5s (ORCPT ); Mon, 26 Dec 2022 22:57:48 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3041F62D6; Mon, 26 Dec 2022 19:57:45 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 47B4FB80D82; Tue, 27 Dec 2022 03:57:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A97E8C433D2; Tue, 27 Dec 2022 03:57:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672113463; bh=k69PCImfrSLvjk42gx+bYeneqhfv6p/1jNsy2xD24Vs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lEhdSeenjTcIfWoymtEMPHbpyJQ6ZnvZWwsCFBtdr74BtME3te9jG569gksnxBAjA fm9MLJsMTldkVvgH29kJgRxBvKu3D/mpHMJT1I0AGy/67ECItwNryZxVXjYA2c6oD9 2yAwRPBWKx6rJJt+ZbJA31AB+YJOnfzqinchCdilo0vMBQ5NAqD0osTHXjBd4QsbM/ oT0WTejAK1Hm36HvFaMk/NpDxSMMtcOheXsKUZvsubAuU2w34166xChc0vG4VXj2+1 n04e6YfxVv7i/hyLldwWCEpQbck6ks8TBiGR0tLBXSffV/EZ1/V4FyQGEtz+hc3b0j mNuwxk1gQzQlw== Date: Mon, 26 Dec 2022 20:57:40 -0700 From: Nathan Chancellor To: Masahiro Yamada Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, Nick Desaulniers , Nicolas Schier Subject: Re: [PATCH v2 2/2] kbuild: make W=1 warn files that are tracked but ignored by git Message-ID: References: <20221224155138.447912-1-masahiroy@kernel.org> <20221224155138.447912-2-masahiroy@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221224155138.447912-2-masahiroy@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 25, 2022 at 12:51:38AM +0900, Masahiro Yamada wrote: > The top .gitignore comments about how to detect files breaking > .gitignore rules, but people rarely care about it. > > Add a new W=1 warning to detect files that are tracked but ignored by > git. If git is not installed or the source tree is not tracked by git > at all, this script does not print anything. > > Running it on the v6.1 kernel detected the following: > > $ make W=1 misc-check > Documentation/devicetree/bindings/.yamllint: warning: ignored by one of the .gitignore files > drivers/clk/.kunitconfig: warning: ignored by one of the .gitignore files > drivers/gpu/drm/tests/.kunitconfig: warning: ignored by one of the .gitignore files > drivers/hid/.kunitconfig: warning: ignored by one of the .gitignore files > fs/ext4/.kunitconfig: warning: ignored by one of the .gitignore files > fs/fat/.kunitconfig: warning: ignored by one of the .gitignore files > kernel/kcsan/.kunitconfig: warning: ignored by one of the .gitignore files > lib/kunit/.kunitconfig: warning: ignored by one of the .gitignore files > mm/kfence/.kunitconfig: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/.gitignore: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/Makefile: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/run_tags_test.sh: warning: ignored by one of the .gitignore files > tools/testing/selftests/arm64/tags/tags_test.c: warning: ignored by one of the .gitignore files > > These are ignored by the '.*' or 'tags' in the top .gitignore, but > there is no rule to negate it. > > You might be tempted to do 'git add -f' but I want to have the real > issue fixed (by fixing a .gitignore, or by renaming files, etc.). > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > Changes in v2: > - Add $(srctree)/ to make it work with O= > > Makefile | 6 ++++++ > scripts/misc-check | 19 +++++++++++++++++++ > 2 files changed, 25 insertions(+) > create mode 100755 scripts/misc-check > > diff --git a/Makefile b/Makefile > index 44239352d2bf..f6ff8f77a669 100644 > --- a/Makefile > +++ b/Makefile > @@ -1852,6 +1852,12 @@ rust-analyzer: > # Misc > # --------------------------------------------------------------------------- > > +PHONY += misc-check > +misc-check: > + $(Q)$(srctree)/scripts/misc-check > + > +all: misc-check > + > PHONY += scripts_gdb > scripts_gdb: prepare0 > $(Q)$(MAKE) $(build)=scripts/gdb > diff --git a/scripts/misc-check b/scripts/misc-check > new file mode 100755 > index 000000000000..bf68712d1ac1 > --- /dev/null > +++ b/scripts/misc-check > @@ -0,0 +1,19 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0-only > + > +set -e > + > +# Detect files that are tracked but ignored by git. This is checked only when > +# ${KBUILD_EXTRA_WARN} contains 1, git is installed, and the source tree is > +# tracked by git. > +check_tracked_ignored_files () { > + case "${KBUILD_EXTRA_WARN}" in > + *1*) ;; > + *) return;; > + esac > + > + git ls-files -i -c --exclude-per-directory=.gitignore 2>/dev/null | > + sed 's/$/: warning: ignored by one of the .gitignore files/' >&2 > +} > + > +check_tracked_ignored_files > -- > 2.34.1 >