From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68DA63239 for ; Tue, 27 Dec 2022 18:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D088C433D2; Tue, 27 Dec 2022 18:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672166893; bh=jC+G6KggctyJl19lPvX6acqHjopjAKeOdWYT4ODLTZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lo1YFgc4wMO579CEmwBJteC/WRWHqg6NmNoHdgr2Myntqw6NsJ/QboLSBLlG0/wQl GNxFtfJuBD1zNW0kzFB0gkOFhWDXP7vftCIm8u80vENUIrb/sF3LRupDlqdpM7mH8p Spu9aRXzzs5wSCaFWUx0HinsGxFdV1WgK4abqeTTyC4fyNYrPd6N5EXj06jxX81NYI hl8HBlrrxBvlWkP7lFICUXqtL7HIHU5/Fh8fT8AxhPEir4aAaHqYdTrPahC6IoZctI OOIVJmRn7TjXDhhk9ne82b53glBkRNIvZO4zUJaZWpWsVpawEz/rsxgxxNgnkOxk7w zNVuI+iJztoZw== Date: Tue, 27 Dec 2022 11:48:10 -0700 From: Nathan Chancellor To: Helge Deller Cc: Thomas Zimmermann , Randy Dunlap , linux-kernel@vger.kernel.org, Arnd Bergmann , Masahiro Yamada , Michal =?iso-8859-1?Q?Such=E1nek?= , linuxppc-dev@lists.ozlabs.org, Daniel Vetter , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, llvm@lists.linux.dev Subject: Re: [PATCH] fbdev: make offb driver tristate Message-ID: References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: > On 11/26/22 14:40, Thomas Zimmermann wrote: > > Am 26.11.22 um 01:04 schrieb Randy Dunlap: > > > Make the offb (Open Firmware frame buffer) driver tristate, > > > i.e., so that it can be built as a loadable module. > > > > > > However, it still depends on the setting of DRM_OFDRM > > > so that both of these drivers cannot be builtin at the same time > > > nor can one be builtin and the other one a loadable module. > > > > > > Build-tested successfully with all combination of DRM_OFDRM and FB_OF. > > > > > > This fixes a build issue that Michal reported when FB_OF=y and > > > DRM_OFDRM=m: > > > > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit' > > > > > > Signed-off-by: Randy Dunlap > > > Suggested-by: Arnd Bergmann > > > Cc: Masahiro Yamada > > > Cc: Thomas Zimmermann > > > Cc: Michal Suchánek > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Cc: Daniel Vetter > > > Cc: Helge Deller > > > Cc: linux-fbdev@vger.kernel.org > > > Cc: dri-devel@lists.freedesktop.org > > > > Acked-by: Thomas Zimmermann > > applied. Is this going to make it to Linus soon? We are now seeing this error in our CI, which has the configuration describe in this commit. https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/3785609002/jobs/6437398666#step:5:149 https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integration2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log Cheers, Nathan > > > --- > > >   drivers/video/fbdev/Kconfig |    4 ++-- > > >   1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/video/fbdev/Kconfig > > > @@ -456,8 +456,8 @@ config FB_ATARI > > >         chipset found in Ataris. > > >   config FB_OF > > > -    bool "Open Firmware frame buffer device support" > > > -    depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) > > > +    tristate "Open Firmware frame buffer device support" > > > +    depends on FB && PPC && (!PPC_PSERIES || PCI) > > >       depends on !DRM_OFDRM > > >       select APERTURE_HELPERS > > >       select FB_CFB_FILLRECT > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E6199C4167B for ; Tue, 27 Dec 2022 18:48:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 307A410E331; Tue, 27 Dec 2022 18:48:17 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4E4AD10E331 for ; Tue, 27 Dec 2022 18:48:14 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA7A0611D3; Tue, 27 Dec 2022 18:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D088C433D2; Tue, 27 Dec 2022 18:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672166893; bh=jC+G6KggctyJl19lPvX6acqHjopjAKeOdWYT4ODLTZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lo1YFgc4wMO579CEmwBJteC/WRWHqg6NmNoHdgr2Myntqw6NsJ/QboLSBLlG0/wQl GNxFtfJuBD1zNW0kzFB0gkOFhWDXP7vftCIm8u80vENUIrb/sF3LRupDlqdpM7mH8p Spu9aRXzzs5wSCaFWUx0HinsGxFdV1WgK4abqeTTyC4fyNYrPd6N5EXj06jxX81NYI hl8HBlrrxBvlWkP7lFICUXqtL7HIHU5/Fh8fT8AxhPEir4aAaHqYdTrPahC6IoZctI OOIVJmRn7TjXDhhk9ne82b53glBkRNIvZO4zUJaZWpWsVpawEz/rsxgxxNgnkOxk7w zNVuI+iJztoZw== Date: Tue, 27 Dec 2022 11:48:10 -0700 From: Nathan Chancellor To: Helge Deller Subject: Re: [PATCH] fbdev: make offb driver tristate Message-ID: References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, llvm@lists.linux.dev, Arnd Bergmann , Masahiro Yamada , Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Michal =?iso-8859-1?Q?Such=E1nek?= , linuxppc-dev@lists.ozlabs.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: > On 11/26/22 14:40, Thomas Zimmermann wrote: > > Am 26.11.22 um 01:04 schrieb Randy Dunlap: > > > Make the offb (Open Firmware frame buffer) driver tristate, > > > i.e., so that it can be built as a loadable module. > > > > > > However, it still depends on the setting of DRM_OFDRM > > > so that both of these drivers cannot be builtin at the same time > > > nor can one be builtin and the other one a loadable module. > > > > > > Build-tested successfully with all combination of DRM_OFDRM and FB_OF. > > > > > > This fixes a build issue that Michal reported when FB_OF=y and > > > DRM_OFDRM=m: > > > > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit' > > > > > > Signed-off-by: Randy Dunlap > > > Suggested-by: Arnd Bergmann > > > Cc: Masahiro Yamada > > > Cc: Thomas Zimmermann > > > Cc: Michal Suchánek > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Cc: Daniel Vetter > > > Cc: Helge Deller > > > Cc: linux-fbdev@vger.kernel.org > > > Cc: dri-devel@lists.freedesktop.org > > > > Acked-by: Thomas Zimmermann > > applied. Is this going to make it to Linus soon? We are now seeing this error in our CI, which has the configuration describe in this commit. https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/3785609002/jobs/6437398666#step:5:149 https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integration2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log Cheers, Nathan > > > --- > > >   drivers/video/fbdev/Kconfig |    4 ++-- > > >   1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/video/fbdev/Kconfig > > > @@ -456,8 +456,8 @@ config FB_ATARI > > >         chipset found in Ataris. > > >   config FB_OF > > > -    bool "Open Firmware frame buffer device support" > > > -    depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) > > > +    tristate "Open Firmware frame buffer device support" > > > +    depends on FB && PPC && (!PPC_PSERIES || PCI) > > >       depends on !DRM_OFDRM > > >       select APERTURE_HELPERS > > >       select FB_CFB_FILLRECT > > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD671C4167B for ; Tue, 27 Dec 2022 18:49:14 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NhNwn05xGz3bfG for ; Wed, 28 Dec 2022 05:49:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Lo1YFgc4; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=nathan@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=Lo1YFgc4; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NhNvj1SYSz304m for ; Wed, 28 Dec 2022 05:48:17 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AA7A0611D3; Tue, 27 Dec 2022 18:48:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D088C433D2; Tue, 27 Dec 2022 18:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672166893; bh=jC+G6KggctyJl19lPvX6acqHjopjAKeOdWYT4ODLTZU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Lo1YFgc4wMO579CEmwBJteC/WRWHqg6NmNoHdgr2Myntqw6NsJ/QboLSBLlG0/wQl GNxFtfJuBD1zNW0kzFB0gkOFhWDXP7vftCIm8u80vENUIrb/sF3LRupDlqdpM7mH8p Spu9aRXzzs5wSCaFWUx0HinsGxFdV1WgK4abqeTTyC4fyNYrPd6N5EXj06jxX81NYI hl8HBlrrxBvlWkP7lFICUXqtL7HIHU5/Fh8fT8AxhPEir4aAaHqYdTrPahC6IoZctI OOIVJmRn7TjXDhhk9ne82b53glBkRNIvZO4zUJaZWpWsVpawEz/rsxgxxNgnkOxk7w zNVuI+iJztoZw== Date: Tue, 27 Dec 2022 11:48:10 -0700 From: Nathan Chancellor To: Helge Deller Subject: Re: [PATCH] fbdev: make offb driver tristate Message-ID: References: <20221126000401.25302-1-rdunlap@infradead.org> <46e8cf0d-ab47-59b1-6c87-53d2d63a5bf6@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, llvm@lists.linux.dev, Daniel Vetter , Arnd Bergmann , Masahiro Yamada , Randy Dunlap , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Thomas Zimmermann , Michal =?iso-8859-1?Q?Such=E1nek?= , linuxppc-dev@lists.ozlabs.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Dec 10, 2022 at 05:35:06PM +0100, Helge Deller wrote: > On 11/26/22 14:40, Thomas Zimmermann wrote: > > Am 26.11.22 um 01:04 schrieb Randy Dunlap: > > > Make the offb (Open Firmware frame buffer) driver tristate, > > > i.e., so that it can be built as a loadable module. > > > > > > However, it still depends on the setting of DRM_OFDRM > > > so that both of these drivers cannot be builtin at the same time > > > nor can one be builtin and the other one a loadable module. > > > > > > Build-tested successfully with all combination of DRM_OFDRM and FB_OF. > > > > > > This fixes a build issue that Michal reported when FB_OF=y and > > > DRM_OFDRM=m: > > > > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x58): undefined reference to `cfb_fillrect' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x60): undefined reference to `cfb_copyarea' > > > powerpc64-linux-ld: drivers/video/fbdev/offb.o:(.data.rel.ro+0x68): undefined reference to `cfb_imageblit' > > > > > > Signed-off-by: Randy Dunlap > > > Suggested-by: Arnd Bergmann > > > Cc: Masahiro Yamada > > > Cc: Thomas Zimmermann > > > Cc: Michal Suchánek > > > Cc: linuxppc-dev@lists.ozlabs.org > > > Cc: Daniel Vetter > > > Cc: Helge Deller > > > Cc: linux-fbdev@vger.kernel.org > > > Cc: dri-devel@lists.freedesktop.org > > > > Acked-by: Thomas Zimmermann > > applied. Is this going to make it to Linus soon? We are now seeing this error in our CI, which has the configuration describe in this commit. https://github.com/ClangBuiltLinux/continuous-integration2/actions/runs/3785609002/jobs/6437398666#step:5:149 https://storage.tuxsuite.com/public/clangbuiltlinux/continuous-integration2/builds/2JUMSmjAoSJoKfl6PPjfU66JGit/build.log Cheers, Nathan > > > --- > > >   drivers/video/fbdev/Kconfig |    4 ++-- > > >   1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff -- a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig > > > --- a/drivers/video/fbdev/Kconfig > > > +++ b/drivers/video/fbdev/Kconfig > > > @@ -456,8 +456,8 @@ config FB_ATARI > > >         chipset found in Ataris. > > >   config FB_OF > > > -    bool "Open Firmware frame buffer device support" > > > -    depends on (FB = y) && PPC && (!PPC_PSERIES || PCI) > > > +    tristate "Open Firmware frame buffer device support" > > > +    depends on FB && PPC && (!PPC_PSERIES || PCI) > > >       depends on !DRM_OFDRM > > >       select APERTURE_HELPERS > > >       select FB_CFB_FILLRECT > > > >