All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Linus Walleij <linus.walleij@linaro.org>
Subject: Re: [PATCH v1 01/17] pinctrl: intel: Introduce INTEL_COMMUNITY_*() to unify community macros
Date: Tue, 27 Dec 2022 21:19:12 +0200	[thread overview]
Message-ID: <Y6tFMB5S23PgmxQd@smile.fi.intel.com> (raw)
In-Reply-To: <Y6B2FyOvOK2rR9H9@black.fi.intel.com>

On Mon, Dec 19, 2022 at 04:32:55PM +0200, Mika Westerberg wrote:
> On Mon, Dec 19, 2022 at 02:26:27PM +0200, Andy Shevchenko wrote:
> > Now it becomes visible that we can deduplicate SoC specific
> > *_COMMUNITY() macros across the Intel pin control drivers.
> > For that, introduce a common INTEL_COMMUNITY_GPPS() and
> > INTEL_COMMUNITY_SIZE() macros in the pinctrl-intel.h.
> 
> You should really start learning how to use --cover-letter option with
> git format-patch because for anything more than one patch pretty much
> requires such. Here I would really like to see how much lines this
> series ends up removing :)
> 
> The series looks good to me, though.

The series has been pushed to my review and testing branch, thanks!

P.S. I dared to convert the above into your Acked-by tag. Tell me if it must
not be the case.

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2022-12-27 19:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19 12:26 [PATCH v1 01/17] pinctrl: intel: Introduce INTEL_COMMUNITY_*() to unify community macros Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 02/17] pinctrl: alderlake: Replace ADL_COMMUNITY() by INTEL_COMMUNITY_GPPS() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 03/17] pinctrl: broxton: Replace BXT_COMMUNITY() by INTEL_COMMUNITY_SIZE() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 04/17] pinctrl: cannonlake: Replace CNL_COMMUNITY() by INTEL_COMMUNITY_GPPS() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 05/17] pinctrl: cedarfork: Replace CDF_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 06/17] pinctrl: denverton: Replace DNV_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 07/17] pinctrl: elkhartlake: Replace EHL_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 08/17] pinctrl: emmitsburg: Replace EBG_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 09/17] pinctrl: geminilake: Replace GLK_COMMUNITY() by INTEL_COMMUNITY_SIZE() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 10/17] pinctrl: icelake: Replace ICL_COMMUNITY() by INTEL_COMMUNITY_GPPS() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 11/17] pinctrl: jasperlake: Replace JSL_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 12/17] pinctrl: lakefield: Replace LKF_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 13/17] pinctrl: lewisburg: Replace LBG_COMMUNITY() by INTEL_COMMUNITY_SIZE() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 14/17] pinctrl: meteorlake: Replace MTL_COMMUNITY() by INTEL_COMMUNITY_GPPS() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 15/17] pinctrl: tigerlake: Replace TGL_COMMUNITY() " Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 16/17] pinctrl: sunrisepoint: Replace SPT_COMMUNITY() by INTEL_COMMUNITY_*() Andy Shevchenko
2022-12-19 12:26 ` [PATCH v1 17/17] pinctrl: intel: Always use gpp_num_padown_regs in the main driver Andy Shevchenko
2022-12-19 14:32 ` [PATCH v1 01/17] pinctrl: intel: Introduce INTEL_COMMUNITY_*() to unify community macros Mika Westerberg
2022-12-19 14:38   ` Andy Shevchenko
2022-12-27 19:19   ` Andy Shevchenko [this message]
2022-12-28  6:50     ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6tFMB5S23PgmxQd@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.