From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80281C54EBD for ; Thu, 12 Jan 2023 11:32:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=S3x1//eHHbKdwZOVgh2x7qebq0ltf6nfj1Xd5ZUX3ss=; b=qzdHEvUSLrK+sj B1CLXbyQ2BkU47pLFuyQg2ca6CNxJFIArIpaNGfiQFdRlOlMx5Z8kg/5iVrbJeb7Hz2uWgVxKZR3q TI3xldy1MVg4Ipovlc5LO4UOUaTJL0xWGUBLjLGs3aH5GryyEiMxLLrHHY/7oQJ103Tbp1I+a4LwU CLJz//xsmZMGSWrf35jcWq6yeBYBrkovkHUdX7HksBG8L3jOK03YfnVtvm8koUgPUK3tqQbFT66gx 1F9oHcHYi5fZr/dcmo0PinOoKWpB543hVFwowT8fkduOy7l7VcGMd4hHTFxY5Yiax6WV+rZYFzYzE zjz3Fobtnyy4TxugFCgg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFvnd-00EqE1-69; Thu, 12 Jan 2023 11:31:13 +0000 Received: from galois.linutronix.de ([2a0a:51c0:0:12e:550::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFvnW-00EqC6-30 for linux-arm-kernel@lists.infradead.org; Thu, 12 Jan 2023 11:31:11 +0000 Date: Thu, 12 Jan 2023 12:31:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673523064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WQKzxWGlYcUEh4TPtYYTILu3zcGAYCnzPQyrQfdSwdk=; b=dSXoddQ72Rqbe6DDTUj4sQskN7vwSCOVRsqkK58/hdj6UsPQ3ThpCehVzlp6t2tiwCr2Xa XkohUyOWtAnV1vOEfDJk9OjP05EZopb41pmaJ58gRfs+anxkfFbZrL7dEtxyrSnOlv2TLx Wgv3LIYXqxxAyD0S2CFCZ0I9fBG22sej2TE12gLGiIYQtvlF6SbDV/Uv9+1Pi2r5oKtJxU VtWfoVwQvLbpWoZEo21AD5YB3/q9RDXF6SNGHW7sJpzEf2PLOpbWAmZdwlcef1tjfulJyE Kx0ccVpeEFWm6jl9uxgJRbIdksQuKX4v6K+f76dqgOI8smN426+adTUSUMpXjA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673523064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WQKzxWGlYcUEh4TPtYYTILu3zcGAYCnzPQyrQfdSwdk=; b=+KCMjXpngd1nZ5yDy9hP+czUOcsSDk5w7W2miPE1JxTfEWhSuQpLWIdDgicOHM93OEaJFV whNiykUIC1Aq7rAw== From: Sebastian Andrzej Siewior To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Kevin Hilman , Ulf Hansson , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adrien Thierry , Brian Masney , linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 5/5] PM: domains: Do not call device_pm_check_callbacks() when holding genpd_lock() Message-ID: References: <20221219151503.385816-1-krzysztof.kozlowski@linaro.org> <20221219151503.385816-6-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221219151503.385816-6-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230112_033106_430560_B8076575 X-CRM114-Status: GOOD ( 18.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMi0xMi0xOSAxNjoxNTowMyBbKzAxMDBdLCBLcnp5c3p0b2YgS296bG93c2tpIHdyb3Rl Ogo+IElmIFBNIGRvbWFpbiBvbiBQUkVFTVBUX1JUIGlzIG1hcmtlZCBhcyBHRU5QRF9GTEFHX1JU X1NBRkUoKSwgdGhlCj4gZ2VucGRfbG9jaygpIHdpbGwgYmUgYSByYXcgc3BpbiBsb2NrLCB0aHVz IGRldmljZV9wbV9jaGVja19jYWxsYmFja3MoKQoKYSByYXdfc3BpbmxvY2tfdAoKPiBtdXN0IGJl IGNhbGxlZCBvdXRzaWRlIG9mIHRoZSBkb21haW4gbG9jay4KClJpZ2h0LiBGaXJzdCB0aGUgc2xl ZXBpbmcgbG9jaywgZm9sbG93ZWQgYnkgdGhlIHNwaW5uaW5nIGxvY2tzLiBUaGlzIGlzCmNvdmVy ZWQgaW4KCURvY3VtZW50YXRpb24vbG9ja2luZy9sb2NrdHlwZXMucnN0CgphdCB0aGUgZW5kLiAK Cj4gVGhpcyBzb2x2ZXMgb24gUFJFRU1QVF9SVDoKWWVzIGJ1dAo+ICAgWyBCVUc6IEludmFsaWQg d2FpdCBjb250ZXh0IF0KClRoaXMgIkludmFsaWQgd2FpdCBjb250ZXh0IiBzaG91bGQgYWxzbyB0 cmlnZ2VyIG9uICFQUkVFTVBUX1JUIHdpdGgKQ09ORklHX1BST1ZFX1JBV19MT0NLX05FU1RJTkcu Cgo+ICAgNi4xLjAtcnQ1LTAwMzI1LWc4YTVmNTZiY2ZjY2EgIzggVGFpbnRlZDogRyAgICAgICAg Vwo+ICAgLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgIHN3YXBwZXIvMC8xIGlzIHRy eWluZyB0byBsb2NrOgo+ICAgZmZmZjc2ZTA0NWRlYzlhMCAoJmRldi0+cG93ZXIubG9jayl7Ky4r Ln0tezM6M30sIGF0OiBkZXZpY2VfcG1fY2hlY2tfY2FsbGJhY2tzKzB4MjAvMHhmMAo+ICAgb3Ro ZXIgaW5mbyB0aGF0IG1pZ2h0IGhlbHAgdXMgZGVidWcgdGhpczoKPiAgIGNvbnRleHQtezU6NX0K PiAgIDMgbG9ja3MgaGVsZCBieSBzd2FwcGVyLzAvMToKPiAgICAjMDogZmZmZjc2ZTA0NWRlYjhl OCAoJmRldi0+bXV0ZXgpey4uLi59LXs0OjR9LCBhdDogX19kZXZpY2VfYXR0YWNoKzB4MzgvMHgx YzAKPiAgICAjMTogZmZmZmE5MmI4MWY4MjVlMCAoZ3BkX2xpc3RfbG9jayl7Ky4rLn0tezQ6NH0s IGF0OiBfX2dlbnBkX2Rldl9wbV9hdHRhY2grMHg3Yy8weDI1MAo+ICAgICMyOiBmZmZmNzZlMDQx MDVjN2EwICgmZ2VucGQtPnJzbG9jayl7Li4uLn0tezI6Mn0sIGF0OiBnZW5wZF9sb2NrX3Jhd3Nw aW4rMHgxYy8weDMwCj4gICBzdGFjayBiYWNrdHJhY2U6Cj4gICBDUFU6IDUgUElEOiAxIENvbW06 IHN3YXBwZXIvMCBUYWludGVkOiBHICAgICAgICBXICAgICAgICAgIDYuMS4wLXJ0NS0wMDMyNS1n OGE1ZjU2YmNmY2NhICM4Cj4gICBIYXJkd2FyZSBuYW1lOiBRdWFsY29tbSBUZWNobm9sb2dpZXMs IEluYy4gUm9ib3RpY3MgUkI1IChEVCkKPiAgIENhbGwgdHJhY2U6Cj4gICAgZHVtcF9iYWNrdHJh Y2UucGFydC4wKzB4ZTAvMHhmMAo+ICAgIHNob3dfc3RhY2srMHgxOC8weDQwCj4gICAgZHVtcF9z dGFja19sdmwrMHg4Yy8weGI4Cj4gICAgZHVtcF9zdGFjaysweDE4LzB4MzQKPiAgICBfX2xvY2tf YWNxdWlyZSsweDkzOC8weDIxMDAKPiAgICBsb2NrX2FjcXVpcmUucGFydC4wKzB4MTA0LzB4Mjhj Cj4gICAgbG9ja19hY3F1aXJlKzB4NjgvMHg4NAo+ICAgIHJ0X3NwaW5fbG9jaysweDQwLzB4MTAw Cj4gICAgZGV2aWNlX3BtX2NoZWNrX2NhbGxiYWNrcysweDIwLzB4ZjAKPiAgICBkZXZfcG1fZG9t YWluX3NldCsweDU0LzB4NjQKPiAgICBnZW5wZF9hZGRfZGV2aWNlKzB4MjU4LzB4MzQwCj4gICAg X19nZW5wZF9kZXZfcG1fYXR0YWNoKzB4YTgvMHgyNTAKPiAgICBnZW5wZF9kZXZfcG1fYXR0YWNo X2J5X2lkKzB4YzQvMHgxOTAKPiAgICBnZW5wZF9kZXZfcG1fYXR0YWNoX2J5X25hbWUrMHgzYy8w eDYwCj4gICAgZGV2X3BtX2RvbWFpbl9hdHRhY2hfYnlfbmFtZSsweDIwLzB4MzAKPiAgICBkdF9p ZGxlX2F0dGFjaF9jcHUrMHgyNC8weDkwCj4gICAgcHNjaV9jcHVpZGxlX3Byb2JlKzB4MzAwLzB4 NGIwCj4gICAgcGxhdGZvcm1fcHJvYmUrMHg2OC8weGUwCj4gICAgcmVhbGx5X3Byb2JlKzB4YmMv MHgyZGMKPiAgICBfX2RyaXZlcl9wcm9iZV9kZXZpY2UrMHg3OC8weGUwCj4gICAgZHJpdmVyX3By b2JlX2RldmljZSsweDNjLzB4MTYwCj4gICAgX19kZXZpY2VfYXR0YWNoX2RyaXZlcisweGI4LzB4 MTQwCj4gICAgYnVzX2Zvcl9lYWNoX2RydisweDc4LzB4ZDAKPiAgICBfX2RldmljZV9hdHRhY2gr MHhhOC8weDFjMAo+ICAgIGRldmljZV9pbml0aWFsX3Byb2JlKzB4MTQvMHgyMAo+ICAgIGJ1c19w cm9iZV9kZXZpY2UrMHg5Yy8weGE0Cj4gICAgZGV2aWNlX2FkZCsweDNiNC8weDhkYwo+ICAgIHBs YXRmb3JtX2RldmljZV9hZGQrMHgxMTQvMHgyMzQKPiAgICBwbGF0Zm9ybV9kZXZpY2VfcmVnaXN0 ZXJfZnVsbCsweDEwOC8weDFhNAo+ICAgIHBzY2lfaWRsZV9pbml0KzB4NmMvMHhiMAo+ICAgIGRv X29uZV9pbml0Y2FsbCsweDc0LzB4NDUwCj4gICAga2VybmVsX2luaXRfZnJlZWFibGUrMHgyZTAv MHgzNTAKPiAgICBrZXJuZWxfaW5pdCsweDI0LzB4MTMwCj4gICAgcmV0X2Zyb21fZm9yaysweDEw LzB4MjAKCkkgd291bGQgcHJlZmVyIGEgZGVzY3JpcHRpb24gb2YgdGhlIGlzc3VlIGluc3RlYWQg aGFjaW5nIHRoaXMKYmFja3RyYWNlLgoKPiBDYzogQWRyaWVuIFRoaWVycnkgPGF0aGllcnJ5QHJl ZGhhdC5jb20+Cj4gQ2M6IEJyaWFuIE1hc25leSA8Ym1hc25leUByZWRoYXQuY29tPgo+IENjOiBs aW51eC1ydC11c2Vyc0B2Z2VyLmtlcm5lbC5vcmcKPiBTaWduZWQtb2ZmLWJ5OiBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+Cj4gLS0tCj4gIGRyaXZl cnMvYmFzZS9wb3dlci9kb21haW4uYyB8IDYgKysrKystCj4gIDEgZmlsZSBjaGFuZ2VkLCA1IGlu c2VydGlvbnMoKyksIDEgZGVsZXRpb24oLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9iYXNl L3Bvd2VyL2RvbWFpbi5jIGIvZHJpdmVycy9iYXNlL3Bvd2VyL2RvbWFpbi5jCj4gaW5kZXggNGRm Y2UxZDQ3NmY0Li5kYjQ5OWJhNDA0OTcgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9iYXNlL3Bvd2Vy L2RvbWFpbi5jCj4gKysrIGIvZHJpdmVycy9iYXNlL3Bvd2VyL2RvbWFpbi5jCj4gQEAgLTE2NjYs MTAgKzE2NjYsMTQgQEAgc3RhdGljIGludCBnZW5wZF9hZGRfZGV2aWNlKHN0cnVjdCBnZW5lcmlj X3BtX2RvbWFpbiAqZ2VucGQsIHN0cnVjdCBkZXZpY2UgKmRldiwKPiAgCWlmIChyZXQpCj4gIAkJ Z290byBvdXQ7Cj4gIAo+ICsKPiArCS8qIFBSRUVNUFRfUlQ6IE11c3QgYmUgb3V0c2lkZSBvZiBn ZW5wZF9sb2NrICovCgpDb3VsZCB0aGlzIGNvbW1lbnQgYmUgcmV3cml0dGVuIGlmIG5lZWRlZD8K VGhlIGNhbGxiYWNrLCB3aGljaCBhY3F1aXJlcyBzbGVlcGluZyBsb2NrcyBvbiBQUkVFTVBUX1JU LCBjYW4gYmUgbW92ZWQKYmVmb3JlIGdlbnBkX2xvY2soKSBiZWNhdXNlIGl0IGRvZXMgbm90IHJl bHkgb24gdGhpcyBsb2NrLiBJdCBtdXN0IGJlCm1vdmVkIGJlY2F1c2UgdGhlIGxhdHRlciBtYXkg YWNxdWlyZSBzcGlubmluZyBsb2Nrcy4KCkl0IG1pZ2h0IGJlIGFsc28gYmUgcGFydCBvZiB0aGUg Y29tbWl0IG1lc3NhZ2XigKYKCj4gKwlkZXZpY2VfcG1fY2hlY2tfY2FsbGJhY2tzKGRldik7Cj4g Kwo+ICAJZ2VucGRfbG9jayhnZW5wZCk7Cj4gIAo+ICAJZ2VucGRfc2V0X2NwdW1hc2soZ2VucGQs IGdwZF9kYXRhLT5jcHUpOwo+IC0JZGV2X3BtX2RvbWFpbl9zZXQoZGV2LCAmZ2VucGQtPmRvbWFp bik7Cj4gKwlkZXZfcG1fZG9tYWluX3NldF9ub19jYihkZXYsICZnZW5wZC0+ZG9tYWluKTsKPiAg Cj4gIAlnZW5wZC0+ZGV2aWNlX2NvdW50Kys7Cj4gIAlpZiAoZ2QpCgpTZWJhc3RpYW4KCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93C85C54EBD for ; Thu, 12 Jan 2023 11:41:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233808AbjALLln (ORCPT ); Thu, 12 Jan 2023 06:41:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235120AbjALLku (ORCPT ); Thu, 12 Jan 2023 06:40:50 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F12AB50F57; Thu, 12 Jan 2023 03:31:05 -0800 (PST) Date: Thu, 12 Jan 2023 12:31:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1673523064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WQKzxWGlYcUEh4TPtYYTILu3zcGAYCnzPQyrQfdSwdk=; b=dSXoddQ72Rqbe6DDTUj4sQskN7vwSCOVRsqkK58/hdj6UsPQ3ThpCehVzlp6t2tiwCr2Xa XkohUyOWtAnV1vOEfDJk9OjP05EZopb41pmaJ58gRfs+anxkfFbZrL7dEtxyrSnOlv2TLx Wgv3LIYXqxxAyD0S2CFCZ0I9fBG22sej2TE12gLGiIYQtvlF6SbDV/Uv9+1Pi2r5oKtJxU VtWfoVwQvLbpWoZEo21AD5YB3/q9RDXF6SNGHW7sJpzEf2PLOpbWAmZdwlcef1tjfulJyE Kx0ccVpeEFWm6jl9uxgJRbIdksQuKX4v6K+f76dqgOI8smN426+adTUSUMpXjA== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1673523064; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WQKzxWGlYcUEh4TPtYYTILu3zcGAYCnzPQyrQfdSwdk=; b=+KCMjXpngd1nZ5yDy9hP+czUOcsSDk5w7W2miPE1JxTfEWhSuQpLWIdDgicOHM93OEaJFV whNiykUIC1Aq7rAw== From: Sebastian Andrzej Siewior To: Krzysztof Kozlowski Cc: "Rafael J. Wysocki" , Len Brown , Pavel Machek , Greg Kroah-Hartman , Kevin Hilman , Ulf Hansson , Daniel Lezcano , Lorenzo Pieralisi , Sudeep Holla , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Adrien Thierry , Brian Masney , linux-rt-users@vger.kernel.org Subject: Re: [PATCH v2 5/5] PM: domains: Do not call device_pm_check_callbacks() when holding genpd_lock() Message-ID: References: <20221219151503.385816-1-krzysztof.kozlowski@linaro.org> <20221219151503.385816-6-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <20221219151503.385816-6-krzysztof.kozlowski@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022-12-19 16:15:03 [+0100], Krzysztof Kozlowski wrote: > If PM domain on PREEMPT_RT is marked as GENPD_FLAG_RT_SAFE(), the > genpd_lock() will be a raw spin lock, thus device_pm_check_callbacks() a raw_spinlock_t > must be called outside of the domain lock. Right. First the sleeping lock, followed by the spinning locks. This is covered in Documentation/locking/locktypes.rst at the end.=20 > This solves on PREEMPT_RT: Yes but > [ BUG: Invalid wait context ] This "Invalid wait context" should also trigger on !PREEMPT_RT with CONFIG_PROVE_RAW_LOCK_NESTING. > 6.1.0-rt5-00325-g8a5f56bcfcca #8 Tainted: G W > ----------------------------- > swapper/0/1 is trying to lock: > ffff76e045dec9a0 (&dev->power.lock){+.+.}-{3:3}, at: device_pm_check_ca= llbacks+0x20/0xf0 > other info that might help us debug this: > context-{5:5} > 3 locks held by swapper/0/1: > #0: ffff76e045deb8e8 (&dev->mutex){....}-{4:4}, at: __device_attach+0x= 38/0x1c0 > #1: ffffa92b81f825e0 (gpd_list_lock){+.+.}-{4:4}, at: __genpd_dev_pm_a= ttach+0x7c/0x250 > #2: ffff76e04105c7a0 (&genpd->rslock){....}-{2:2}, at: genpd_lock_raws= pin+0x1c/0x30 > stack backtrace: > CPU: 5 PID: 1 Comm: swapper/0 Tainted: G W 6.1.0-rt5-00= 325-g8a5f56bcfcca #8 > Hardware name: Qualcomm Technologies, Inc. Robotics RB5 (DT) > Call trace: > dump_backtrace.part.0+0xe0/0xf0 > show_stack+0x18/0x40 > dump_stack_lvl+0x8c/0xb8 > dump_stack+0x18/0x34 > __lock_acquire+0x938/0x2100 > lock_acquire.part.0+0x104/0x28c > lock_acquire+0x68/0x84 > rt_spin_lock+0x40/0x100 > device_pm_check_callbacks+0x20/0xf0 > dev_pm_domain_set+0x54/0x64 > genpd_add_device+0x258/0x340 > __genpd_dev_pm_attach+0xa8/0x250 > genpd_dev_pm_attach_by_id+0xc4/0x190 > genpd_dev_pm_attach_by_name+0x3c/0x60 > dev_pm_domain_attach_by_name+0x20/0x30 > dt_idle_attach_cpu+0x24/0x90 > psci_cpuidle_probe+0x300/0x4b0 > platform_probe+0x68/0xe0 > really_probe+0xbc/0x2dc > __driver_probe_device+0x78/0xe0 > driver_probe_device+0x3c/0x160 > __device_attach_driver+0xb8/0x140 > bus_for_each_drv+0x78/0xd0 > __device_attach+0xa8/0x1c0 > device_initial_probe+0x14/0x20 > bus_probe_device+0x9c/0xa4 > device_add+0x3b4/0x8dc > platform_device_add+0x114/0x234 > platform_device_register_full+0x108/0x1a4 > psci_idle_init+0x6c/0xb0 > do_one_initcall+0x74/0x450 > kernel_init_freeable+0x2e0/0x350 > kernel_init+0x24/0x130 > ret_from_fork+0x10/0x20 I would prefer a description of the issue instead hacing this backtrace. > Cc: Adrien Thierry > Cc: Brian Masney > Cc: linux-rt-users@vger.kernel.org > Signed-off-by: Krzysztof Kozlowski > --- > drivers/base/power/domain.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c > index 4dfce1d476f4..db499ba40497 100644 > --- a/drivers/base/power/domain.c > +++ b/drivers/base/power/domain.c > @@ -1666,10 +1666,14 @@ static int genpd_add_device(struct generic_pm_dom= ain *genpd, struct device *dev, > if (ret) > goto out; > =20 > + > + /* PREEMPT_RT: Must be outside of genpd_lock */ Could this comment be rewritten if needed? The callback, which acquires sleeping locks on PREEMPT_RT, can be moved before genpd_lock() because it does not rely on this lock. It must be moved because the latter may acquire spinning locks. It might be also be part of the commit message=E2=80=A6 > + device_pm_check_callbacks(dev); > + > genpd_lock(genpd); > =20 > genpd_set_cpumask(genpd, gpd_data->cpu); > - dev_pm_domain_set(dev, &genpd->domain); > + dev_pm_domain_set_no_cb(dev, &genpd->domain); > =20 > genpd->device_count++; > if (gd) Sebastian