From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F183C46467 for ; Mon, 2 Jan 2023 18:35:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233444AbjABSfO (ORCPT ); Mon, 2 Jan 2023 13:35:14 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56400 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230127AbjABSfM (ORCPT ); Mon, 2 Jan 2023 13:35:12 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B47322188; Mon, 2 Jan 2023 10:35:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9ndz5vBaBmqACnJVA/c07kvOtW14mqhh8FDCUNWTZAU=; b=TAwPjFjB1En3Q9ORCDoeuwVfL7 tPtKE92ui/Pvf+8RHE2qt+1dijpdbWn9GMSjpGOwhzfhvRKogLGix+RVa61exiyvsCXTHQDV+6M7K 7J3gPr2aPPytcmRKBnjDnG0YVKhn87inZhQJghxhoarw94279JfomPKUf7d+EyF/8qs0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pCPe3-000xUI-5H; Mon, 02 Jan 2023 19:34:47 +0100 Date: Mon, 2 Jan 2023 19:34:47 +0100 From: Andrew Lunn To: Roger Quadros Cc: MD Danish Anwar , "Andrew F. Davis" , Tero Kristo , Suman Anna , YueHaibing , Vignesh Raghavendra , Krzysztof Kozlowski , Rob Herring , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , nm@ti.com, ssantosh@kernel.org, srk@ti.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Message-ID: References: <20221223110930.1337536-1-danishanwar@ti.com> <20221223110930.1337536-2-danishanwar@ti.com> <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 02, 2023 at 03:04:19PM +0200, Roger Quadros wrote: > > > On 23/12/2022 16:28, Andrew Lunn wrote: > >> + ethernet-ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + pruss2_emac0: port@0 { > >> + reg = <0>; > >> + phy-handle = <&pruss2_eth0_phy>; > >> + phy-mode = "rgmii-rxid"; > > > > That is unusual. Where are the TX delays coming from? > > >From the below property > > + ti,syscon-rgmii-delay = <&scm_conf 0x4120>; > > The TX delay can be enabled/disabled from within the ICSSG block. > > If this property exists and PHY mode is neither PHY_INTERFACE_MODE_RGMII_ID > nor PHY_INTERFACE_MODE_RGMII_TXID then the internal delay is enabled. > > This logic is in prueth_config_rgmiidelay() function in the introduced driver. What nearly every other MAC driver does is pass the phy-mode to the PHY and lets the PHY add the delays. I would recommend you do that, rather than be special and different. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64D83C46467 for ; Mon, 2 Jan 2023 19:16:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HL/VM23M/iYnooUgUkUEFFbsfO78EYxyEbKVjnRVkyE=; b=QprZAqwVbNpxHP iz2U4IOH72qY33ajwS7WgZnhUYRwqwTBLt6juvmSYFRefO5j7HqUJnLcsPXZs3lybKDcOcrgMkg5g 5F+qUc/hnKuuRXBwEiV0CZwuTGeiRBVDCJoWC/WjPrF4VEockmHx4wDwueJwp7CVBjWGAdZmiRRm7 DoDHxhrkefE19HnYOE4xavrQXMO4nrKMg4tGP/WtzGHScqBgePpGQqu9H9kDQ78B7auELzC6tNyee wR1ZO15if27rk4FnR6holqxw/9IJIn3N+wctU4bH5buHQczPBuCJG4fdFLTLf+iHmtr4AsHLmgJcy mWC6mlEyR537M+rQt+Gw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCQGO-00DlQK-7q; Mon, 02 Jan 2023 19:14:24 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCQFo-00DlN9-Dt for linux-arm-kernel@bombadil.infradead.org; Mon, 02 Jan 2023 19:13:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9ndz5vBaBmqACnJVA/c07kvOtW14mqhh8FDCUNWTZAU=; b=lSnFvclIqZHfJ8H8azaIikQN3O 5/Y7TJ10/ADtHlPGOeNsm6lNqDZd3A5bpeyTc5QcYboNqnVaeIFEPq8I5dXV7lbekzIIncy81bcEC qzK/Ya6kthoUoEhicDL4X2uzhcQQ/zjw9dudq2XbS655GiJ1DAYkLlW7EpIig1LqJ7sLDqwq8sNlw caQhH1CzFa7YkAU2Izrd+4bMzPDFT8Z42d8R6IVbiGGF91y+gqauXEslo88wHgntvSrdjE1m/9Lhc tic7CEV9UHvswxRW0TwLiXwuSKv1qABbzuDc+j0iY7bv1LI3/UAG+kL70nCsbWxijAVB8Qfk+GwHa NbFLYtVg==; Received: from vps0.lunn.ch ([156.67.10.101]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pCPei-000LDE-2U for linux-arm-kernel@lists.infradead.org; Mon, 02 Jan 2023 18:35:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=9ndz5vBaBmqACnJVA/c07kvOtW14mqhh8FDCUNWTZAU=; b=TAwPjFjB1En3Q9ORCDoeuwVfL7 tPtKE92ui/Pvf+8RHE2qt+1dijpdbWn9GMSjpGOwhzfhvRKogLGix+RVa61exiyvsCXTHQDV+6M7K 7J3gPr2aPPytcmRKBnjDnG0YVKhn87inZhQJghxhoarw94279JfomPKUf7d+EyF/8qs0=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pCPe3-000xUI-5H; Mon, 02 Jan 2023 19:34:47 +0100 Date: Mon, 2 Jan 2023 19:34:47 +0100 From: Andrew Lunn To: Roger Quadros Subject: Re: [PATCH v3 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Message-ID: References: <20221223110930.1337536-1-danishanwar@ti.com> <20221223110930.1337536-2-danishanwar@ti.com> <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <620ce8e6-2b40-1322-364a-0099a6e2af26@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230102_183528_916951_D9FA6381 X-CRM114-Status: GOOD ( 14.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nm@ti.com, srk@ti.com, Paolo Abeni , Vignesh Raghavendra , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, netdev@vger.kernel.org, YueHaibing , linux-kernel@vger.kernel.org, MD Danish Anwar , "Andrew F. Davis" , Tero Kristo , Eric Dumazet , Rob Herring , Krzysztof Kozlowski , ssantosh@kernel.org, Jakub Kicinski , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 02, 2023 at 03:04:19PM +0200, Roger Quadros wrote: > > > On 23/12/2022 16:28, Andrew Lunn wrote: > >> + ethernet-ports { > >> + #address-cells = <1>; > >> + #size-cells = <0>; > >> + pruss2_emac0: port@0 { > >> + reg = <0>; > >> + phy-handle = <&pruss2_eth0_phy>; > >> + phy-mode = "rgmii-rxid"; > > > > That is unusual. Where are the TX delays coming from? > > >From the below property > > + ti,syscon-rgmii-delay = <&scm_conf 0x4120>; > > The TX delay can be enabled/disabled from within the ICSSG block. > > If this property exists and PHY mode is neither PHY_INTERFACE_MODE_RGMII_ID > nor PHY_INTERFACE_MODE_RGMII_TXID then the internal delay is enabled. > > This logic is in prueth_config_rgmiidelay() function in the introduced driver. What nearly every other MAC driver does is pass the phy-mode to the PHY and lets the PHY add the delays. I would recommend you do that, rather than be special and different. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel