From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 510B4C3DA7D for ; Thu, 5 Jan 2023 11:00:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233052AbjAEK77 (ORCPT ); Thu, 5 Jan 2023 05:59:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45256 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233114AbjAEK7k (ORCPT ); Thu, 5 Jan 2023 05:59:40 -0500 Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E9E957907; Thu, 5 Jan 2023 02:59:30 -0800 (PST) Received: by mail-wr1-x436.google.com with SMTP id az7so11325504wrb.5; Thu, 05 Jan 2023 02:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Wxg4n9JP4gJD7PKhSiNfZm9HcsyJiX7nt/oNFVx3d0s=; b=IogR2t2gkZFtz//KdpYY+adNeEuq7UdJSkjO6nCOkAzu1atSQsKciiH5hiVlXxnHR+ MmrTYUex+/Sr59FIioxlYp81SFIIqACUrOG7shjmyOUnk68UKWAx708gobvhtgSnqZLV KI4ck1NOo/qE2y/SR0OzPM4E7nFvSt8eeOwkW7kfviBU6aBIm0XuxvFuTdY26a9exi80 nZfpi/OqHJnQmVs+iltP+xl+rirdERCd3v4BxSjm6PQC2ZxbkdPGx6Xh1t+QS9HcP2XE QiafpN1rBxcrEhwIywUy6PMkrgnbDPjMQM0VChkmN2q40xTFr1ULbXxNxFmXrIVUrdVi R9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wxg4n9JP4gJD7PKhSiNfZm9HcsyJiX7nt/oNFVx3d0s=; b=MhL4p+hBK8LKnJrLVIsw/H41ee2qN4uEFEBLPKbOJWXyS5/L9gORuED3gIdyx0eEmS mkJVKgqq621gkCUSNkMElrfkCTb47mG/MwKDKGXuDeg5iLZBfAEg5pcdX+nihBMlgVHP ceSjxGiwdfdUIvAnbR6am5AkfBvf6/NFcn12LSXnkBX1cB7fQMdqQU2nlRzYCsKceV3w mw0jJb/REWrxiAO53wP+PwBdWOGI1c3b6+5w7iqdNhD/d05OsXqsxQe+UpHzFWGiYwVk 4XZMGcRHV9H5zbCRx6qRJiRjXjO1lrbqA1NlKkpkuDbonT9hiEb1gZIsOea0CKNQfu0v 3/tg== X-Gm-Message-State: AFqh2koaw9iZGezkATdBOkod7If/GZyrc8lJuKZGVfT4OgNKaxYEsaQL dsSru2K6f6pjNR3My5nVr2k= X-Google-Smtp-Source: AMrXdXtYwh5O+rYA9+7GVMmmJIKoPK/pGHeSNjC1fUIzIxedgu9At+LnqH/M8jguOESETkxHzlrVlg== X-Received: by 2002:adf:f0ca:0:b0:275:e426:4134 with SMTP id x10-20020adff0ca000000b00275e4264134mr27976450wro.51.1672916369161; Thu, 05 Jan 2023 02:59:29 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id c11-20020a5d4ccb000000b002b6bcc0b64dsm126541wrt.4.2023.01.05.02.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 02:59:28 -0800 (PST) Date: Thu, 5 Jan 2023 13:58:20 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules Message-ID: References: <20230105081335.1261636-1-steen.hegelund@microchip.com> <20230105081335.1261636-3-steen.hegelund@microchip.com> <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Email re-arranged because I screwed up - dan] On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote: > This series was first sent to net, but the response was that I should go into > net-next instead, so it is really a first version in net-next. > > What was your question? I was not able to find it... Ugh... Oauth2 code (mutt/msmtp) silently ate my email. Sorry. > > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule) > > >       ret = vcap_write_rule(ri); > > >       if (ret) > > >               pr_err("%s:%d: rule write error: %d\n", __func__, __LINE__, > > > ret); There should be a "goto out;" after the pr_err(). > > > +     /* Set the counter to zero */ > > > +     ret = vcap_write_counter(ri, &ctr); > > >  out: > > >       mutex_unlock(&ri->admin->lock); > > >       return ret; > > regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D5E04C3DA7A for ; Thu, 5 Jan 2023 20:24:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zEuzzQ1WT8g/hIDkSjmufrPY29Dr/tZvwGWkzAIeXh8=; b=iXXPNAjBL+fEHf 3f84HbG/gxLbbBU0lOyOwA48p+6ii056MUkyEIY9OQvPpqEgjjEH3BDLG5GIEvaIlWVzaNS5Bz/75 Nl6AwvCbTTITGgpPtqoN3skiz8e+jP1ffAoRy0F7t0ObVcQ1Zv7AqIykTfT+4qSFec2Z6JzyZp6IO l3KT30Z3oZ+uLz71Y6OBxzRerQgllR+OVUjKkJ1Yu1NQvepmDux8XWU+OhxF/IjNQmQdvL2oX2ahv DEMREEFxGv+hyW3iwRiZ1YL/eDvoBGWi1Id7NgmcATM4eqvyv7sttk8ns9KjUsi00ul8oQSN+6cky pxnyQ2d3eKEljD1ZnKvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDWm4-00EVb0-Cd; Thu, 05 Jan 2023 20:23:40 +0000 Received: from mail-wr1-x42d.google.com ([2a00:1450:4864:20::42d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDNy7-00BGu9-Bm for linux-arm-kernel@lists.infradead.org; Thu, 05 Jan 2023 10:59:32 +0000 Received: by mail-wr1-x42d.google.com with SMTP id s9so3711827wru.13 for ; Thu, 05 Jan 2023 02:59:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=Wxg4n9JP4gJD7PKhSiNfZm9HcsyJiX7nt/oNFVx3d0s=; b=IogR2t2gkZFtz//KdpYY+adNeEuq7UdJSkjO6nCOkAzu1atSQsKciiH5hiVlXxnHR+ MmrTYUex+/Sr59FIioxlYp81SFIIqACUrOG7shjmyOUnk68UKWAx708gobvhtgSnqZLV KI4ck1NOo/qE2y/SR0OzPM4E7nFvSt8eeOwkW7kfviBU6aBIm0XuxvFuTdY26a9exi80 nZfpi/OqHJnQmVs+iltP+xl+rirdERCd3v4BxSjm6PQC2ZxbkdPGx6Xh1t+QS9HcP2XE QiafpN1rBxcrEhwIywUy6PMkrgnbDPjMQM0VChkmN2q40xTFr1ULbXxNxFmXrIVUrdVi R9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Wxg4n9JP4gJD7PKhSiNfZm9HcsyJiX7nt/oNFVx3d0s=; b=uV4HGU9ZQ382v/wg8VnLlOTS66IGSPVKVKK/o/bW1uHt85WAuC5qpzQfYukVFKclDU fkvACrfVf1jm/rYpsDRBijiXrpzgTe/Oo2VsqOUdwPZR1qe+i1QtFueuhP7FF+d9cHo8 MZrf5KPkIBepRYirN5iFgRva2q0vH+qXkTxMeu92bm0zScdywlVYpvWNz+6bqmmn4CBG d32ts+33SeuY1Ilk22lwLsmKIWv7z6zvRZEwYvIPXCGRJZHQmGo9xYup7khiXAGC4iJR Hxk5qiuVvDuC2VZteoKyH2DBsICJdTNJB3hoWPs4NLe3nm/pM63yCTZNkDT2HXOSffvc fqRQ== X-Gm-Message-State: AFqh2krMsEcTdlorXF3k/9x2kgWIl0UIXAJPinBXjy+Ujp/3ZvLF8Xig fktKiP+OH4PexeBfhjjgoIg= X-Google-Smtp-Source: AMrXdXtYwh5O+rYA9+7GVMmmJIKoPK/pGHeSNjC1fUIzIxedgu9At+LnqH/M8jguOESETkxHzlrVlg== X-Received: by 2002:adf:f0ca:0:b0:275:e426:4134 with SMTP id x10-20020adff0ca000000b00275e4264134mr27976450wro.51.1672916369161; Thu, 05 Jan 2023 02:59:29 -0800 (PST) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id c11-20020a5d4ccb000000b002b6bcc0b64dsm126541wrt.4.2023.01.05.02.59.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 02:59:28 -0800 (PST) Date: Thu, 5 Jan 2023 13:58:20 +0300 From: Dan Carpenter To: Steen Hegelund Cc: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , UNGLinuxDriver@microchip.com, Randy Dunlap , Casper Andersson , Russell King , Wan Jiabing , Nathan Huckleberry , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Daniel Machon , Horatiu Vultur , Lars Povlsen Subject: Re: [PATCH net-next 2/8] net: microchip: sparx5: Reset VCAP counter for new rules Message-ID: References: <20230105081335.1261636-1-steen.hegelund@microchip.com> <20230105081335.1261636-3-steen.hegelund@microchip.com> <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <7fa8ea30beffcb9256422f7a474a8be7d5791f5a.camel@microchip.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230105_025931_478573_37169CD5 X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org [ Email re-arranged because I screwed up - dan] On Thu, Jan 05, 2023 at 11:43:17AM +0100, Steen Hegelund wrote: > This series was first sent to net, but the response was that I should go = into > net-next instead, so it is really a first version in net-next. > = > What was your question? I was not able to find it... Ugh... Oauth2 code (mutt/msmtp) silently ate my email. Sorry. > > > @@ -1833,6 +1834,8 @@ int vcap_add_rule(struct vcap_rule *rule) > > > =A0=A0=A0=A0=A0 ret =3D vcap_write_rule(ri); > > > =A0=A0=A0=A0=A0 if (ret) > > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 pr_err("%s:%d: rule write err= or: %d\n", __func__, __LINE__, > > > ret); There should be a "goto out;" after the pr_err(). > > > +=A0=A0=A0=A0 /* Set the counter to zero */ > > > +=A0=A0=A0=A0 ret =3D vcap_write_counter(ri, &ctr); > > > =A0out: > > > =A0=A0=A0=A0=A0 mutex_unlock(&ri->admin->lock); > > > =A0=A0=A0=A0=A0 return ret; > > = regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel