From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6EEEC3DA7A for ; Thu, 5 Jan 2023 14:50:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AED3510E02F; Thu, 5 Jan 2023 14:50:06 +0000 (UTC) Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by gabe.freedesktop.org (Postfix) with ESMTPS id F09D610E745 for ; Thu, 5 Jan 2023 14:50:03 +0000 (UTC) Received: by mail-wm1-x336.google.com with SMTP id g10so14402539wmo.1 for ; Thu, 05 Jan 2023 06:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=yPQLhJfGS4U3xEltVHsl7WvTSNQNkZrTzl5+OBE7NGc=; b=j+fWJTtYWJmBkURH22XHoXCrWFWpvPBR4u/ZSno2OQUTuv0dZ1MjzTZFJ8qX2tpOSd ytXnc66NNDsgiMVBbnCUMQ5t72DIz/dJPIOwLwnlcvuQwYVd/Kn6D497fPuoyI/ForIK MZir7e4pn9R+Kcfwfg64TaUSIgfAgZfabo5Xs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yPQLhJfGS4U3xEltVHsl7WvTSNQNkZrTzl5+OBE7NGc=; b=MvPdiW8HLeFLfn10KvW14QwAzup/o9Cln3F6xAm1wAhw0K0NzuUScippdpMc5zb2FO vfTLC0cC2Lz601qwZr6YEg+J5A7bKSWo9n9lh8f7POco6etFiAFzYweMFYpFlgVTyeQy 7CK/Y8M9rlJlzGotND9X5pNx7KEmxvczbzL4Z+XYS/gaFIMzVSmpL15u3RUWuymjIZ1L zH66eMyODXHe7pOUVfzi96CtOHAcNIKzk1x7zlKNbjN4fvJAwlvC+eK+lQpB8wRzY0FO SI9nzrokFkEGORYTxFgXxOyoQLp2x+2gJZ7jBNyLkAC+1xfjnWhC8a065UqcNMOBtsM2 mVmQ== X-Gm-Message-State: AFqh2kpiLiX0Fz9xGBDmcQk4A2DaKTXyebg7+EypYlwkbVl1RXeG54F5 HNLHVS3gZ2PoNBvvEBbh2qhkcQ== X-Google-Smtp-Source: AMrXdXt1HxOI0/mCWWxpOZY8g1+ljmWpFuHE+KOd2cz8wEKC6mCLR+HGawWtPioFoLI+8R98zkQEag== X-Received: by 2002:a05:600c:224b:b0:3cf:ae53:b1e0 with SMTP id a11-20020a05600c224b00b003cfae53b1e0mr37245642wmm.9.1672930202353; Thu, 05 Jan 2023 06:50:02 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b003d96efd09b7sm3206401wmp.19.2023.01.05.06.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 06:50:01 -0800 (PST) Date: Thu, 5 Jan 2023 15:49:58 +0100 From: Daniel Vetter To: Marijn Suijten Subject: Re: [PATCH v2 0/8] drm/msm: DSC Electric Boogaloo for sm8[12]50 Message-ID: Mail-Followup-To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Vinod Koul , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Stephen Boyd , Bjorn Andersson , Jessica Zhang , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221221231943.1961117-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221231943.1961117-1-marijn.suijten@somainline.org> X-Operating-System: Linux phenom 5.19.0-2-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, AngeloGioacchino Del Regno , phone-devel@vger.kernel.org, Sam Ravnborg , Haowen Bai , Vinod Koul , Kuogee Hsieh , Jessica Zhang , Jani Nikula , linux-arm-msm@vger.kernel.org, Abhinav Kumar , Stephen Boyd , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Sean Paul , Loic Poulain , Jami Kettunen , Bjorn Andersson , Vladimir Lypak , Douglas Anderson , Konrad Dybcio , sunliming , Dmitry Baryshkov , freedreno@lists.freedesktop.org, Vinod Polimera Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Dec 22, 2022 at 12:19:35AM +0100, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CTLs), logic bugs are corrected, zeroed struct > members are now assigned proper values, and RM allocation and hw block > retrieval now hand out (or not) DSC blocks without causing null-pointer > dereferences. > > Unfortunately it is not yet enough to get rid of completely corrupted > display output on the boards I tested here: > - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; > - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; > - (can include more Xperia boards if desired) > > Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP > and DSC, but only a single INTF/encoder/DSI-link. > > Hopefully this spawns some community/upstream interest to help rootcause > our corruption issues (after we open a drm/msm report on GitLab for more > appropriate tracking). > > The Sony Xperia XZ3 (sdm845) was fully tested and validated with this > series to not cause any regressions (and one of the math fixes now > allows us to change slice_count in the panel driver, which would corrupt > previously). > > Changes since v1: > > - Split patch 6 into two separately backportable Fixes: patches; > - Additionally remove num_enc from msm_display_topology in favour of > num_dsc; > - Reorder patches to have all Fixes: at the beginning for easier > picking; > - Fix existing multiline comment while editing it anyway; > - Add missing Signed-off-by to patch 5. Please note that Electric Boogaloo/Boogaloo Boys has been appropriated by US alt-right groups, and so is really not a great thing to put into the cover letter for your patch series. For the next round, please use a meme that isn't tarnished like this. Thanks, Daniel > > v1: https://lore.kernel.org/linux-arm-msm/20221213232207.113607-1-marijn.suijten@somainline.org/T/#u > > Marijn Suijten (8): > drm/msm/dpu: Wire up DSC mask for active CTL configuration > drm/msm/dsi: Use DSC slice(s) packet size to compute word count > drm/msm/dsi: Flip greater-than check for slice_count and > slice_per_intf > drm/msm/dpu: Disallow unallocated resources to be returned > drm/msm/dpu: Reject topologies for which no DSC blocks are available > drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc > drm/msm/dpu: Implement DSC binding to PP block for CTL V1 > drm/msm/dpu: Add DSC configuration for SM8150 and SM8250 > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++++---- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 +++++++++++----- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 9 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 27 +++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 4 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 14 ++++++++-- > drivers/gpu/drm/msm/dsi/dsi_host.c | 7 ++--- > drivers/gpu/drm/msm/msm_drv.h | 2 -- > 10 files changed, 82 insertions(+), 18 deletions(-) > > -- > 2.39.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12CABC53210 for ; Thu, 5 Jan 2023 14:50:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231431AbjAEOuv (ORCPT ); Thu, 5 Jan 2023 09:50:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233371AbjAEOuF (ORCPT ); Thu, 5 Jan 2023 09:50:05 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D0A145932B for ; Thu, 5 Jan 2023 06:50:03 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id bg13-20020a05600c3c8d00b003d9712b29d2so1485190wmb.2 for ; Thu, 05 Jan 2023 06:50:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:from:to:cc :subject:date:message-id:reply-to; bh=yPQLhJfGS4U3xEltVHsl7WvTSNQNkZrTzl5+OBE7NGc=; b=j+fWJTtYWJmBkURH22XHoXCrWFWpvPBR4u/ZSno2OQUTuv0dZ1MjzTZFJ8qX2tpOSd ytXnc66NNDsgiMVBbnCUMQ5t72DIz/dJPIOwLwnlcvuQwYVd/Kn6D497fPuoyI/ForIK MZir7e4pn9R+Kcfwfg64TaUSIgfAgZfabo5Xs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yPQLhJfGS4U3xEltVHsl7WvTSNQNkZrTzl5+OBE7NGc=; b=bKMjlZmqeV5uzAV9qd1Khjmb2jtbMdLc24hn6UEkW8+e+IyTtsG9V11k2PMkTFoHHU SJ7KUrMzDJJ+284ZBG+7Cos9aP+VD+W+JB2veKx7aAWV81y12ljKQBHLCb0dn+p4MUgT MaEV3s4aGVq/C12teToBuZoXxZWJlDVF2Kbcibx1OBLyN9YAQjaMunLjY6UpVux0juPH voYluRcNtiq8VgsmzJsBYUACC5D4O6LXXb4OAZ/cbAX0yusNgM0FpA3jlXwpdxmGr6B9 7LCY1odLTJm1cVJCC3tToul2eNyryFVlNljx8rCAFxv8XD5nozQIT/Pr0NJ6719uFLZU seWA== X-Gm-Message-State: AFqh2kqhPE7bP0+Z6Cy0B/bhFOTokZXFUTgsAvJOfrUIcJ8qaGboQ6mA eCyQ9cfJcuE//U0vi93rteULuQ== X-Google-Smtp-Source: AMrXdXt1HxOI0/mCWWxpOZY8g1+ljmWpFuHE+KOd2cz8wEKC6mCLR+HGawWtPioFoLI+8R98zkQEag== X-Received: by 2002:a05:600c:224b:b0:3cf:ae53:b1e0 with SMTP id a11-20020a05600c224b00b003cfae53b1e0mr37245642wmm.9.1672930202353; Thu, 05 Jan 2023 06:50:02 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id z6-20020a05600c0a0600b003d96efd09b7sm3206401wmp.19.2023.01.05.06.50.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Jan 2023 06:50:01 -0800 (PST) Date: Thu, 5 Jan 2023 15:49:58 +0100 From: Daniel Vetter To: Marijn Suijten Cc: phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Vinod Koul , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Daniel Vetter , Stephen Boyd , Bjorn Andersson , Jessica Zhang , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/8] drm/msm: DSC Electric Boogaloo for sm8[12]50 Message-ID: Mail-Followup-To: Marijn Suijten , phone-devel@vger.kernel.org, Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Vinod Koul , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Sean Paul , David Airlie , Stephen Boyd , Bjorn Andersson , Jessica Zhang , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Kuogee Hsieh , Jani Nikula , sunliming , Sam Ravnborg , Haowen Bai , Konrad Dybcio , Loic Poulain , Vinod Polimera , Douglas Anderson , Vladimir Lypak , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20221221231943.1961117-1-marijn.suijten@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221221231943.1961117-1-marijn.suijten@somainline.org> X-Operating-System: Linux phenom 5.19.0-2-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Dec 22, 2022 at 12:19:35AM +0100, Marijn Suijten wrote: > This preliminary Display Stream Compression support package for > (initially tested on) sm8[12]50 is based on comparing DSC behaviour > between downstream and mainline. Some new callbacks are added (for > binding blocks on active CTLs), logic bugs are corrected, zeroed struct > members are now assigned proper values, and RM allocation and hw block > retrieval now hand out (or not) DSC blocks without causing null-pointer > dereferences. > > Unfortunately it is not yet enough to get rid of completely corrupted > display output on the boards I tested here: > - Sony Xperia 1 (sm8150), 1644x3840 or 1096x2560 pixels; > - Sony Xperia 5II (sm8250), 1080x2520, at 60 or 120Hz; > - (can include more Xperia boards if desired) > > Both devices use the DUALPIPE_DSCMERGE topology downstream: dual LM, PP > and DSC, but only a single INTF/encoder/DSI-link. > > Hopefully this spawns some community/upstream interest to help rootcause > our corruption issues (after we open a drm/msm report on GitLab for more > appropriate tracking). > > The Sony Xperia XZ3 (sdm845) was fully tested and validated with this > series to not cause any regressions (and one of the math fixes now > allows us to change slice_count in the panel driver, which would corrupt > previously). > > Changes since v1: > > - Split patch 6 into two separately backportable Fixes: patches; > - Additionally remove num_enc from msm_display_topology in favour of > num_dsc; > - Reorder patches to have all Fixes: at the beginning for easier > picking; > - Fix existing multiline comment while editing it anyway; > - Add missing Signed-off-by to patch 5. Please note that Electric Boogaloo/Boogaloo Boys has been appropriated by US alt-right groups, and so is really not a great thing to put into the cover letter for your patch series. For the next round, please use a meme that isn't tarnished like this. Thanks, Daniel > > v1: https://lore.kernel.org/linux-arm-msm/20221213232207.113607-1-marijn.suijten@somainline.org/T/#u > > Marijn Suijten (8): > drm/msm/dpu: Wire up DSC mask for active CTL configuration > drm/msm/dsi: Use DSC slice(s) packet size to compute word count > drm/msm/dsi: Flip greater-than check for slice_count and > slice_per_intf > drm/msm/dpu: Disallow unallocated resources to be returned > drm/msm/dpu: Reject topologies for which no DSC blocks are available > drm/msm/dpu: Remove num_enc from topology struct in favour of num_dsc > drm/msm/dpu: Implement DSC binding to PP block for CTL V1 > drm/msm/dpu: Add DSC configuration for SM8150 and SM8250 > > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 12 +++++---- > .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 1 + > .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 1 + > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 23 +++++++++++----- > .../gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 9 +++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.c | 27 +++++++++++++++++++ > drivers/gpu/drm/msm/disp/dpu1/dpu_hw_dsc.h | 4 +++ > drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 14 ++++++++-- > drivers/gpu/drm/msm/dsi/dsi_host.c | 7 ++--- > drivers/gpu/drm/msm/msm_drv.h | 2 -- > 10 files changed, 82 insertions(+), 18 deletions(-) > > -- > 2.39.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch