Re: [LTP] [PATCH v2] ltp-aiodio.part4: Run DIT000 with only 1 reader process

[Petr Vorel <pvorel@suse.cz>]

Hi Martin,

...
> diff --git a/testcases/kernel/io/ltp-aiodio/dio_truncate.c b/testcases/kernel/io/ltp-aiodio/dio_truncate.c
...
> +
> +	if (numchildren > 2 && !tst_kconfig_check(kconf_rt)) {
> +		tst_res(TINFO, "Warning: This test may deadlock on RT kernels");
I hate TWARN exits non-zero, thus we need to have warnings like this
(TWARN would be more visible than TINFO, but it'd always mean non-zero for RT).

I'd wish the message was TWARN on error, but because on RT test timeouts, we
would have to somehow check remaining time to print the warning before timeout.

Let's not complicate things more. Thank you for your work!

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +		tst_res(TINFO, "If it does, reduce number of threads to 2");
> +	}
>  }

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp