From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2589C3DA7A for ; Fri, 6 Jan 2023 11:59:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229564AbjAFL7Y (ORCPT ); Fri, 6 Jan 2023 06:59:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232320AbjAFL7X (ORCPT ); Fri, 6 Jan 2023 06:59:23 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 384A9728A5; Fri, 6 Jan 2023 03:59:20 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 698D04AE; Fri, 6 Jan 2023 12:59:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673006357; bh=shoG7w+x8M1GwR2Lnup58s8nVA/zibc7HrmK9Bg1M6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S5UkQ179hLtb7c28hhlzGA4VZiFHh4/pFJU3aNVHHYwmCsIwEQDTIu8xFpEJbgOu9 HcjdDv3I68ZHWKthn0v+DVGkZN3nWYuhoV75yRqJQDnVTF8dBbUDOY0/At9BssEz4Q BeL6BmSTMYDLMN6rEzqW40jdwvnR4K+GzVfJ78Yk= Date: Fri, 6 Jan 2023 13:59:11 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/8] media: imx-pxp: extract helper function to setup data path Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-4-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230105134729.59542-4-m.tretter@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, Thank you for the patch. On Thu, Jan 05, 2023 at 02:47:24PM +0100, Michael Tretter wrote: > The driver must configure the data path through the Pixel Pipeline. > > Currently, the driver is using a fixed setup, but once there are > different pipeline configurations, it is helpful to have a dedicated > function for determining the register value for the data path. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-pxp.c | 62 +++++++++++++++++++--------- > 1 file changed, 42 insertions(+), 20 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > index 05abe40558b0..a957fee88829 100644 > --- a/drivers/media/platform/nxp/imx-pxp.c > +++ b/drivers/media/platform/nxp/imx-pxp.c > @@ -726,6 +726,47 @@ static void pxp_setup_csc(struct pxp_ctx *ctx) > } > } > > +static u32 pxp_data_path_ctrl0(struct pxp_ctx *ctx) > +{ > + u32 ctrl0; > + > + ctrl0 = 0; > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX14_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX3_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(0); > + > + return ctrl0; > +} > + > +static void pxp_set_data_path(struct pxp_ctx *ctx) > +{ > + struct pxp_dev *dev = ctx->dev; > + u32 ctrl0; > + u32 ctrl1; > + > + ctrl0 = pxp_data_path_ctrl0(ctx); > + > + ctrl1 = 0; > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(1); > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(1); > + > + writel(ctrl0, dev->mmio + HW_PXP_DATA_PATH_CTRL0); > + writel(ctrl1, dev->mmio + HW_PXP_DATA_PATH_CTRL1); > +} > + > static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > struct vb2_v4l2_buffer *out_vb) > { > @@ -912,26 +953,7 @@ static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > /* bypass LUT */ > writel(BM_PXP_LUT_CTRL_BYPASS, dev->mmio + HW_PXP_LUT_CTRL); > > - writel(BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX14_SEL(1)| > - BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1)| > - BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX3_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(0), > - dev->mmio + HW_PXP_DATA_PATH_CTRL0); > - writel(BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(1) | > - BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(1), > - dev->mmio + HW_PXP_DATA_PATH_CTRL1); > + pxp_set_data_path(ctx); > > writel(0xffff, dev->mmio + HW_PXP_IRQ_MASK); > -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 40C24C4708D for ; Fri, 6 Jan 2023 12:00:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uCavG6tZ63iIHYdZ7FPKGusY2EPEfChaKCUtoWNkkq8=; b=0FZ0gfRUl5MJEP hR/y7zS973tpf+DWVR9Yr+1kZojiENd6H7GJv/jaxgIfQi9Lbl96ag6all0bOX0FmUWSh/7a5kC52 cTLXAFHQ0wpgg0TKA8yXE3NN4ksX++VG3V4xtorIDVMfADRzbm6iIvM80ugc8OmvwOHotcXjgQL99 pATthmDgiWQgOfrnEVLGBs+4wF8ZPIQ+tkFgyIWplSXIzGtthIja5qfyIDDdQDMyk5b1FT1qhYDF6 4Fi2UHu8BJurr50N9TMS1Hv0tc6ayYn0TNLTzLKjRifdgwsfz4htTPmkcF4j2kXDzewNHyUANm058 Gh3W/OHRrXhuYCueVx8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDlNb-007s5e-Rm; Fri, 06 Jan 2023 11:59:24 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDlNY-007s2h-2m for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 11:59:21 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 698D04AE; Fri, 6 Jan 2023 12:59:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673006357; bh=shoG7w+x8M1GwR2Lnup58s8nVA/zibc7HrmK9Bg1M6Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S5UkQ179hLtb7c28hhlzGA4VZiFHh4/pFJU3aNVHHYwmCsIwEQDTIu8xFpEJbgOu9 HcjdDv3I68ZHWKthn0v+DVGkZN3nWYuhoV75yRqJQDnVTF8dBbUDOY0/At9BssEz4Q BeL6BmSTMYDLMN6rEzqW40jdwvnR4K+GzVfJ78Yk= Date: Fri, 6 Jan 2023 13:59:11 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/8] media: imx-pxp: extract helper function to setup data path Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-4-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105134729.59542-4-m.tretter@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_035920_516220_B20606B5 X-CRM114-Status: GOOD ( 21.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, Thank you for the patch. On Thu, Jan 05, 2023 at 02:47:24PM +0100, Michael Tretter wrote: > The driver must configure the data path through the Pixel Pipeline. > > Currently, the driver is using a fixed setup, but once there are > different pipeline configurations, it is helpful to have a dedicated > function for determining the register value for the data path. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-pxp.c | 62 +++++++++++++++++++--------- > 1 file changed, 42 insertions(+), 20 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > index 05abe40558b0..a957fee88829 100644 > --- a/drivers/media/platform/nxp/imx-pxp.c > +++ b/drivers/media/platform/nxp/imx-pxp.c > @@ -726,6 +726,47 @@ static void pxp_setup_csc(struct pxp_ctx *ctx) > } > } > > +static u32 pxp_data_path_ctrl0(struct pxp_ctx *ctx) > +{ > + u32 ctrl0; > + > + ctrl0 = 0; > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX14_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX3_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(0); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(0); > + > + return ctrl0; > +} > + > +static void pxp_set_data_path(struct pxp_ctx *ctx) > +{ > + struct pxp_dev *dev = ctx->dev; > + u32 ctrl0; > + u32 ctrl1; > + > + ctrl0 = pxp_data_path_ctrl0(ctx); > + > + ctrl1 = 0; > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(1); > + ctrl1 |= BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(1); > + > + writel(ctrl0, dev->mmio + HW_PXP_DATA_PATH_CTRL0); > + writel(ctrl1, dev->mmio + HW_PXP_DATA_PATH_CTRL1); > +} > + > static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > struct vb2_v4l2_buffer *out_vb) > { > @@ -912,26 +953,7 @@ static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > /* bypass LUT */ > writel(BM_PXP_LUT_CTRL_BYPASS, dev->mmio + HW_PXP_LUT_CTRL); > > - writel(BF_PXP_DATA_PATH_CTRL0_MUX15_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX14_SEL(1)| > - BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1)| > - BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX6_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX5_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX4_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX3_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX2_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX1_SEL(0)| > - BF_PXP_DATA_PATH_CTRL0_MUX0_SEL(0), > - dev->mmio + HW_PXP_DATA_PATH_CTRL0); > - writel(BF_PXP_DATA_PATH_CTRL1_MUX17_SEL(1) | > - BF_PXP_DATA_PATH_CTRL1_MUX16_SEL(1), > - dev->mmio + HW_PXP_DATA_PATH_CTRL1); > + pxp_set_data_path(ctx); > > writel(0xffff, dev->mmio + HW_PXP_IRQ_MASK); > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel