From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DCADC3DA7A for ; Fri, 6 Jan 2023 12:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbjAFM1k (ORCPT ); Fri, 6 Jan 2023 07:27:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57576 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233043AbjAFM11 (ORCPT ); Fri, 6 Jan 2023 07:27:27 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D533035937; Fri, 6 Jan 2023 04:27:26 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 473944AE; Fri, 6 Jan 2023 13:27:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673008045; bh=1ZxzED4nciIar20t4Xd9ZwLDt1bW0Vxw8Yw6awN5DQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fOX3sn4v6RVHQ+qQtOQcbcdOghHaUQQUGOcbsBkMba+ArnH1xiG0pEtgGyEmExzmR Q3+7TsaYE3uNv7heXKMipQItFiXkv97gb97OZrtDAo7bv/hiROztci7c68S8a2o5RM OZIOCNhG9a7Wwc4p8HV8YHzJbcvXDbkTpSxL4Z3o= Date: Fri, 6 Jan 2023 14:27:20 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/8] media: imx-pxp: disable LUT block Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-6-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230105134729.59542-6-m.tretter@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, Thank you for the patch. On Thu, Jan 05, 2023 at 02:47:26PM +0100, Michael Tretter wrote: > The LUT block is always configured in bypass mode. > > Take it entirely out of the pipeline by disabling it and routing the > data path around the LUT. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-pxp.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > index 6ffd07cda965..1d649b9cadad 100644 > --- a/drivers/media/platform/nxp/imx-pxp.c > +++ b/drivers/media/platform/nxp/imx-pxp.c > @@ -737,11 +737,10 @@ static u32 pxp_data_path_ctrl0(struct pxp_ctx *ctx) > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(3); > /* Select Rotation */ > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0); > - /* Select LUT */ > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0); > + /* Bypass LUT */ > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(1); > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(3); > - /* Select MUX8 for LUT */ > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(3); > /* Select CSC 2 */ > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0); > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(3); > @@ -966,7 +965,7 @@ static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > /* ungate, enable PS/AS/OUT and PXP operation */ > writel(BM_PXP_CTRL_IRQ_ENABLE, dev->mmio + HW_PXP_CTRL_SET); > writel(BM_PXP_CTRL_ENABLE | BM_PXP_CTRL_ENABLE_CSC2 | > - BM_PXP_CTRL_ENABLE_LUT | BM_PXP_CTRL_ENABLE_ROTATE0 | > + BM_PXP_CTRL_ENABLE_ROTATE0 | > BM_PXP_CTRL_ENABLE_PS_AS_OUT, dev->mmio + HW_PXP_CTRL_SET); > > return 0; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 03730C3DA7A for ; Fri, 6 Jan 2023 12:28:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vWPFjOPUXexNBN5YyOm3taOoxYjLEsq/ONCKyebHUfI=; b=36VJ8hxUh7/C9w 6mFTh6OIqjNu0wMdPn8swUeBXP+AOOWn3EA/s90CRZSM0YE4X6Km0dmIZhbUJVmkN6gH30q5TOPBF B91wi1C9BPSWG+taLSZUNZX2sGPICMyutyff4eIFAkjGane87Rb8S7YMqOPdEn6ZAwBod6JCnIw1P hgjboxF7xVPCozVx6SDqpenVSarY6zXMqV3Qxnh7carCHcl9DV+ucBoFRS7KJqQeXkHhussgb3L6J 23kOSkvhJBM1NmGvBd/jz9rdmWk2dTsKzHHQwbqJJK4y2jma1gjE3ckJ8bEOnTZaJOfuULxm4lDJU njydJDa2ZtXpKdmUSZIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDloo-00839M-DP; Fri, 06 Jan 2023 12:27:30 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDlok-00837h-Rb for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 12:27:28 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 473944AE; Fri, 6 Jan 2023 13:27:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673008045; bh=1ZxzED4nciIar20t4Xd9ZwLDt1bW0Vxw8Yw6awN5DQc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fOX3sn4v6RVHQ+qQtOQcbcdOghHaUQQUGOcbsBkMba+ArnH1xiG0pEtgGyEmExzmR Q3+7TsaYE3uNv7heXKMipQItFiXkv97gb97OZrtDAo7bv/hiROztci7c68S8a2o5RM OZIOCNhG9a7Wwc4p8HV8YHzJbcvXDbkTpSxL4Z3o= Date: Fri, 6 Jan 2023 14:27:20 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 5/8] media: imx-pxp: disable LUT block Message-ID: References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-6-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230105134729.59542-6-m.tretter@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_042727_076383_EEE94A82 X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, Thank you for the patch. On Thu, Jan 05, 2023 at 02:47:26PM +0100, Michael Tretter wrote: > The LUT block is always configured in bypass mode. > > Take it entirely out of the pipeline by disabling it and routing the > data path around the LUT. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/nxp/imx-pxp.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/drivers/media/platform/nxp/imx-pxp.c b/drivers/media/platform/nxp/imx-pxp.c > index 6ffd07cda965..1d649b9cadad 100644 > --- a/drivers/media/platform/nxp/imx-pxp.c > +++ b/drivers/media/platform/nxp/imx-pxp.c > @@ -737,11 +737,10 @@ static u32 pxp_data_path_ctrl0(struct pxp_ctx *ctx) > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX13_SEL(3); > /* Select Rotation */ > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX12_SEL(0); > - /* Select LUT */ > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(0); > + /* Bypass LUT */ > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX11_SEL(1); > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX10_SEL(3); > - /* Select MUX8 for LUT */ > - ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(1); > + ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX9_SEL(3); > /* Select CSC 2 */ > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX8_SEL(0); > ctrl0 |= BF_PXP_DATA_PATH_CTRL0_MUX7_SEL(3); > @@ -966,7 +965,7 @@ static int pxp_start(struct pxp_ctx *ctx, struct vb2_v4l2_buffer *in_vb, > /* ungate, enable PS/AS/OUT and PXP operation */ > writel(BM_PXP_CTRL_IRQ_ENABLE, dev->mmio + HW_PXP_CTRL_SET); > writel(BM_PXP_CTRL_ENABLE | BM_PXP_CTRL_ENABLE_CSC2 | > - BM_PXP_CTRL_ENABLE_LUT | BM_PXP_CTRL_ENABLE_ROTATE0 | > + BM_PXP_CTRL_ENABLE_ROTATE0 | > BM_PXP_CTRL_ENABLE_PS_AS_OUT, dev->mmio + HW_PXP_CTRL_SET); > > return 0; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel