All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <willy@infradead.org>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Chris Mason <clm@fb.com>, Josef Bacik <josef@toxicpanda.com>,
	David Sterba <dsterba@suse.com>,
	Dave Kleikamp <shaggy@kernel.org>, Mark Fasheh <mark@fasheh.com>,
	Joel Becker <jlbec@evilplan.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>,
	Evgeniy Dushistov <dushistov@mail.ru>,
	linux-btrfs@vger.kernel.org,
	jfs-discussion@lists.sourceforge.net, ocfs2-devel@oss.oracle.com,
	linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories
Date: Sun, 8 Jan 2023 21:17:26 +0000	[thread overview]
Message-ID: <Y7sy5jzjT7tpPX6Z@casper.infradead.org> (raw)
In-Reply-To: <20230108165645.381077-4-hch@lst.de>

On Sun, Jan 08, 2023 at 05:56:41PM +0100, Christoph Hellwig wrote:
> @@ -274,9 +280,10 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
>  		memset (namx + namelen, 0, sbi->s_dirsize - namelen - 2);
>  		de->inode = inode->i_ino;
>  	}
> -	err = dir_commit_chunk(page, pos, sbi->s_dirsize);
> +	dir_commit_chunk(page, pos, sbi->s_dirsize);
>  	dir->i_mtime = dir->i_ctime = current_time(dir);
>  	mark_inode_dirty(dir);
> +	minix_handle_dirsync(dir);

Doesn't this need to be:

	err = minix_handle_dirsync(dir);

> @@ -426,7 +436,7 @@ void minix_set_link(struct minix_dir_entry *de, struct page *page,
>  			((minix3_dirent *) de)->inode = inode->i_ino;
>  		else
>  			de->inode = inode->i_ino;
> -		err = dir_commit_chunk(page, pos, sbi->s_dirsize);
> +		dir_commit_chunk(page, pos, sbi->s_dirsize);
>  	} else {
>  		unlock_page(page);
>  	}
> -- 

Aren't you missing a call to minix_handle_dirsync() in this function?

WARNING: multiple messages have this Message-ID (diff)
From: Matthew Wilcox via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Dave Kleikamp <shaggy@kernel.org>,
	jfs-discussion@lists.sourceforge.net,
	Evgeniy Dushistov <dushistov@mail.ru>,
	Josef Bacik <josef@toxicpanda.com>,
	linux-mm@kvack.org, Chris Mason <clm@fb.com>,
	ocfs2-devel@oss.oracle.com, David Sterba <dsterba@suse.com>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org
Subject: Re: [Ocfs2-devel] [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories
Date: Sun, 8 Jan 2023 21:17:26 +0000	[thread overview]
Message-ID: <Y7sy5jzjT7tpPX6Z@casper.infradead.org> (raw)
In-Reply-To: <20230108165645.381077-4-hch@lst.de>

On Sun, Jan 08, 2023 at 05:56:41PM +0100, Christoph Hellwig wrote:
> @@ -274,9 +280,10 @@ int minix_add_link(struct dentry *dentry, struct inode *inode)
>  		memset (namx + namelen, 0, sbi->s_dirsize - namelen - 2);
>  		de->inode = inode->i_ino;
>  	}
> -	err = dir_commit_chunk(page, pos, sbi->s_dirsize);
> +	dir_commit_chunk(page, pos, sbi->s_dirsize);
>  	dir->i_mtime = dir->i_ctime = current_time(dir);
>  	mark_inode_dirty(dir);
> +	minix_handle_dirsync(dir);

Doesn't this need to be:

	err = minix_handle_dirsync(dir);

> @@ -426,7 +436,7 @@ void minix_set_link(struct minix_dir_entry *de, struct page *page,
>  			((minix3_dirent *) de)->inode = inode->i_ino;
>  		else
>  			de->inode = inode->i_ino;
> -		err = dir_commit_chunk(page, pos, sbi->s_dirsize);
> +		dir_commit_chunk(page, pos, sbi->s_dirsize);
>  	} else {
>  		unlock_page(page);
>  	}
> -- 

Aren't you missing a call to minix_handle_dirsync() in this function?

_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  reply	other threads:[~2023-01-08 21:17 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-08 16:56 remove write_one_page / folio_write_one Christoph Hellwig
2023-01-08 16:56 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 1/7] btrfs: don't read the disk superblock for zoned devices in btrfs_scratch_superblocks Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 2/7] btrfs: stop using write_one_page in btrfs_scratch_superblock Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:13   ` Matthew Wilcox via Ocfs2-devel
2023-01-08 21:13     ` Matthew Wilcox
2023-01-08 16:56 ` [PATCH 3/7] minix: don't flush page immediately for DIRSYNC directories Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:17   ` Matthew Wilcox [this message]
2023-01-08 21:17     ` Matthew Wilcox via Ocfs2-devel
2023-01-10  8:22     ` Christoph Hellwig
2023-01-10  8:22       ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-11  2:20       ` Al Viro
2023-01-11  2:20         ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-01-11  4:26         ` Christoph Hellwig via Ocfs2-devel
2023-01-11  4:26           ` Christoph Hellwig
2023-01-11  4:58           ` Al Viro
2023-01-11  4:58             ` [Ocfs2-devel] " Al Viro via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 4/7] sysv: " Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:19   ` Matthew Wilcox
2023-01-08 21:19     ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel
2023-01-10  8:24     ` Christoph Hellwig via Ocfs2-devel
2023-01-10  8:24       ` Christoph Hellwig
2023-01-08 16:56 ` [PATCH 5/7] ufs: " Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-08 16:56 ` [PATCH 6/7] ocfs2: don't use write_one_page in ocfs2_duplicate_clusters_by_page Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-09 17:03   ` Jan Kara via Ocfs2-devel
2023-01-09 17:03     ` Jan Kara
2023-01-10  3:03   ` [Ocfs2-devel] " Joseph Qi via Ocfs2-devel
2023-01-10  3:03     ` Joseph Qi
2023-01-08 16:56 ` [PATCH 7/7] mm,jfs: move write_one_page/folio_write_one to jfs Christoph Hellwig
2023-01-08 16:56   ` [Ocfs2-devel] [PATCH 7/7] mm, jfs: " Christoph Hellwig via Ocfs2-devel
2023-01-08 21:31 ` remove write_one_page / folio_write_one Matthew Wilcox
2023-01-08 21:31   ` [Ocfs2-devel] " Matthew Wilcox via Ocfs2-devel
2023-01-09 19:53 ` David Sterba
2023-01-09 19:53   ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-10  8:16   ` Christoph Hellwig
2023-01-10  8:16     ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-10 13:00     ` David Sterba
2023-01-10 13:00       ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-10 15:32       ` Christoph Hellwig via Ocfs2-devel
2023-01-10 15:32         ` Christoph Hellwig
2023-01-11 19:20         ` David Sterba
2023-01-11 19:20           ` [Ocfs2-devel] " David Sterba via Ocfs2-devel
2023-01-12  8:02           ` Christoph Hellwig
2023-01-12  8:02             ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y7sy5jzjT7tpPX6Z@casper.infradead.org \
    --to=willy@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=dushistov@mail.ru \
    --cc=hch@lst.de \
    --cc=jfs-discussion@lists.sourceforge.net \
    --cc=jlbec@evilplan.org \
    --cc=josef@toxicpanda.com \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark@fasheh.com \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=shaggy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.