From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEF9C28E8 for ; Mon, 9 Jan 2023 11:04:38 +0000 (UTC) Received: by mail-wr1-f43.google.com with SMTP id j7so2744144wrn.9 for ; Mon, 09 Jan 2023 03:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=JfOf7Ybc+GU1nn8y1UcCvxhLZxdJnTmM6yTssoaGD6iHkSp9kw+vB/gkiSd9BYh1Ev 0QFxzWP/4tG540eJGRXWjtCmZaqkjyjagRDq8bBhASM3grdf91bjsYv4KgV91OB6++4s YsO8YvQsF+0XVZ29S/f//4CfrmOe9Sy50FKX3juIAKrtyF082yVw33n51qKs/qdi7yYI 5jeqjXKki1UkPiZnTc5D0T6QLRHn9xrUgbQ09ydGm4qnjFUmkdixeoByKFU5eYtKy7FR 6A31HILTPPT2+/z7YlxLdMYcewFPN71b3Dgv09t0GfYu7LRrYZNWfX48SDylX3W4GzdP ASMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=1mwu63sFPlVynWzYYwop9e5Nv8Pf/vr2ww6Ah9PW471dVgmUfIn4N+Rq/89ScPBFf5 QVQOH4fHuEmykffL32D9uE8KfdyTYksh7RMgOxtBM+1n1d6I81PMqL2xmueD+705Z01Y PHHkBVaZpFT99j1O40HpG2tmUaRzyenBL5c0ATvHALWDbp9UGLZsk0CJ4qJXODjzqveW Q9BDW8Gkmz8LZX9vqTgcNaXVxKNozzqF6r6IoLei54VxHlRLZ90yjJElPnz/qhvYAXXO EnITDLhPgcqE9/QFUbyK6TlzpatiQK0aMunxqptKIgkXBAbAQrZid6c8QTxHp7ApZIWW +C8Q== X-Gm-Message-State: AFqh2kqQLNR3bNsm7nJe88GLUKJTID5uKxT6N17o7d8sVGy7Dzuw02E1 UZ1/4Ghgla3TQZlfQHz14Eyx3A== X-Google-Smtp-Source: AMrXdXt0sWws9FC7FmSd3zSlUGnJeOxvVL6lisTvf8bQ3vSNu8uoGcg+vPo7j6+ZFs9pmgtUvQuw9w== X-Received: by 2002:adf:d846:0:b0:29f:4e42:33c5 with SMTP id k6-20020adfd846000000b0029f4e4233c5mr14183491wrl.55.1673262277116; Mon, 09 Jan 2023 03:04:37 -0800 (PST) Received: from aspen.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id z6-20020a5d6546000000b002bc371a08adsm2060413wrv.101.2023.01.09.03.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:04:36 -0800 (PST) Date: Mon, 9 Jan 2023 11:04:34 +0000 From: Daniel Thompson To: sam@ravnborg.org Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Jingoo Han , linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-staging@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, Stephen Kitt Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Stephen Kitt > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Signed-off-by: Sam Ravnborg Just for completeness... Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29005C54EBD for ; Mon, 9 Jan 2023 11:05:38 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NrB1r4ZVMz3c3N for ; Mon, 9 Jan 2023 22:05:36 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=JfOf7Ybc; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linaro.org (client-ip=2a00:1450:4864:20::431; helo=mail-wr1-x431.google.com; envelope-from=daniel.thompson@linaro.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=JfOf7Ybc; dkim-atps=neutral Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NrB0n2tXSz2xJ4 for ; Mon, 9 Jan 2023 22:04:41 +1100 (AEDT) Received: by mail-wr1-x431.google.com with SMTP id h16so7732185wrz.12 for ; Mon, 09 Jan 2023 03:04:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=JfOf7Ybc+GU1nn8y1UcCvxhLZxdJnTmM6yTssoaGD6iHkSp9kw+vB/gkiSd9BYh1Ev 0QFxzWP/4tG540eJGRXWjtCmZaqkjyjagRDq8bBhASM3grdf91bjsYv4KgV91OB6++4s YsO8YvQsF+0XVZ29S/f//4CfrmOe9Sy50FKX3juIAKrtyF082yVw33n51qKs/qdi7yYI 5jeqjXKki1UkPiZnTc5D0T6QLRHn9xrUgbQ09ydGm4qnjFUmkdixeoByKFU5eYtKy7FR 6A31HILTPPT2+/z7YlxLdMYcewFPN71b3Dgv09t0GfYu7LRrYZNWfX48SDylX3W4GzdP ASMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=VyNfzZDKNTQkIE2aRIdgrQU+FALnhvP/YXn4QwfwHBOfTuIZylDTyfJ3JN+bxyr3Zz L3Ru67+ZR+fV+Mt4zKyyFuL9Fseyii1XOKXs8zGOjwpRW3XAMIkRQ9IEUNqvQeUsCNEy M53a5oc4VIlx1jGQwzHMjTjGw9qaNCzHUDn3o8BYsNXqm/5W3g+k0Dk17WDdg4NjIgy7 gaDzkpp/oaI4CBJOuhrqS9u9zwTrxSGwwCQPG9nKzn5DlRbFdMRQQ2nSzddHRoaH/G9x KyK7qzCOw3T8jJJGisQWxFIBYtpB9QvRLnLYBdZEY/hYopxqNx7iUTg45CYdCDopnYyN dc4g== X-Gm-Message-State: AFqh2kptkZrD2J9xQQIFCHCjH59M71bdR7pr3IG0v+kEFZXva+C9KKZ3 2Qq0LRkYaEaIOV0F1FCH533Q4A== X-Google-Smtp-Source: AMrXdXt0sWws9FC7FmSd3zSlUGnJeOxvVL6lisTvf8bQ3vSNu8uoGcg+vPo7j6+ZFs9pmgtUvQuw9w== X-Received: by 2002:adf:d846:0:b0:29f:4e42:33c5 with SMTP id k6-20020adfd846000000b0029f4e4233c5mr14183491wrl.55.1673262277116; Mon, 09 Jan 2023 03:04:37 -0800 (PST) Received: from aspen.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id z6-20020a5d6546000000b002bc371a08adsm2060413wrv.101.2023.01.09.03.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:04:36 -0800 (PST) Date: Mon, 9 Jan 2023 11:04:34 +0000 From: Daniel Thompson To: sam@ravnborg.org Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-staging@lists.linux.dev, Stephen Kitt , Antonino Daplas , Robin van der Gracht , Helge Deller , Lee Jones , Nicolas Ferre , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Stephen Kitt > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Signed-off-by: Sam Ravnborg Just for completeness... Reviewed-by: Daniel Thompson Daniel. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7931C54EBD for ; Mon, 9 Jan 2023 11:06:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=o0VnzZvJ4gdhomFiYgQcdm8/u59KC5pxvUejSrBrOWY=; b=YwktGKq9BZBcaJ PmWia4WxraLAD3YhNmUye7XgUkX90D9fAEp3usjHsDeynXJo0KjNMsW2wlguSoVBf5sDFeIPPaMVi th4gt6PDYy3t5rU4/HrDqg4uj+HRpG0D9KzFNjNm4hc1ZoqhbTUTX5blQWbttzEpqc83h/b6/NKnv D8b9AxcJ60V8s8qiNuYqFjK6+VlNjR0kkEhKjTPV0OBis5n8BJbVyo6nWURtJ0V5bNM1YTa8cpJL2 h0yTSI56825QWnrAUIZyGnJ2HmOvxktqnhq4atLu05Vj3p2KNfaES2dkUSbZ274KTr57r79ZFUMBR twKxXvBniWVVkKLHclzA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEpxL-000xXt-KU; Mon, 09 Jan 2023 11:04:43 +0000 Received: from mail-wr1-x435.google.com ([2a00:1450:4864:20::435]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEpxH-000xVx-Tn for linux-arm-kernel@lists.infradead.org; Mon, 09 Jan 2023 11:04:41 +0000 Received: by mail-wr1-x435.google.com with SMTP id m7so7738952wrn.10 for ; Mon, 09 Jan 2023 03:04:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=JfOf7Ybc+GU1nn8y1UcCvxhLZxdJnTmM6yTssoaGD6iHkSp9kw+vB/gkiSd9BYh1Ev 0QFxzWP/4tG540eJGRXWjtCmZaqkjyjagRDq8bBhASM3grdf91bjsYv4KgV91OB6++4s YsO8YvQsF+0XVZ29S/f//4CfrmOe9Sy50FKX3juIAKrtyF082yVw33n51qKs/qdi7yYI 5jeqjXKki1UkPiZnTc5D0T6QLRHn9xrUgbQ09ydGm4qnjFUmkdixeoByKFU5eYtKy7FR 6A31HILTPPT2+/z7YlxLdMYcewFPN71b3Dgv09t0GfYu7LRrYZNWfX48SDylX3W4GzdP ASMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=F1o1h0/8Z9CTd9JzV9HYcBGjMEGQHN88SqgrqMI3CKE=; b=bnKE6J2ctohc/2au0gtMBUkt4ql2oEROveOEkjSzhWaNzfjozsDHASf2oauWr1fXq4 3mKbVY411lt0YvOfJHKDfeYSDk8ok0nFBAgzVv06mMLF+nMg/AWyDPZidGzRq9iOfkKV Zf72gEkByyoFnXhqOMGTQxdVAyeG3R4WmjICNkX0MQeixHKG0BSrZ9zQAbTLLXuhVxn6 KRTb3KVopHRhU+lBqbCiKtXtg8qugs4fKIIRgpIZXgRvfX1RHq8CN2UrBxHaEuFrpxe5 19ffp/EsEX3o7nzSbMkVw+s4RC/T28D76iW0HCfQ7640aX30Z2ZSy2hFi2ENeg1aSqAw EY2g== X-Gm-Message-State: AFqh2krStV/xwO2vOaqdMnnNkiYFRn34g/h49amNxey/Bab/6xWzows0 MVz981ZU3hpm1NrCIGylIl+RPA== X-Google-Smtp-Source: AMrXdXt0sWws9FC7FmSd3zSlUGnJeOxvVL6lisTvf8bQ3vSNu8uoGcg+vPo7j6+ZFs9pmgtUvQuw9w== X-Received: by 2002:adf:d846:0:b0:29f:4e42:33c5 with SMTP id k6-20020adfd846000000b0029f4e4233c5mr14183491wrl.55.1673262277116; Mon, 09 Jan 2023 03:04:37 -0800 (PST) Received: from aspen.lan (cpc141216-aztw34-2-0-cust174.18-1.cable.virginm.net. [80.7.220.175]) by smtp.gmail.com with ESMTPSA id z6-20020a5d6546000000b002bc371a08adsm2060413wrv.101.2023.01.09.03.04.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 03:04:36 -0800 (PST) Date: Mon, 9 Jan 2023 11:04:34 +0000 From: Daniel Thompson To: sam@ravnborg.org Subject: Re: [PATCH 14/15] backlight: tosa: Use backlight helper Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230107-sam-video-backlight-drop-fb_blank-v1-14-1bd9bafb351f@ravnborg.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_030439_985015_E5FA9573 X-CRM114-Status: GOOD ( 11.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , linux-staging@lists.linux.dev, Stephen Kitt , Antonino Daplas , Robin van der Gracht , Benjamin Herrenschmidt , Helge Deller , Lee Jones , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jingoo Han , Paul Mackerras , linux-fbdev@vger.kernel.org, Greg Kroah-Hartman , Miguel Ojeda , linux-omap@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Jan 07, 2023 at 07:26:28PM +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Stephen Kitt > > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Signed-off-by: Stephen Kitt > Signed-off-by: Sam Ravnborg Just for completeness... Reviewed-by: Daniel Thompson Daniel. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel