From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D1C85C54EBD for ; Mon, 9 Jan 2023 07:37:05 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id BD34185475; Mon, 9 Jan 2023 08:37:02 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="sDfyd7DT"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 8D44085369; Mon, 9 Jan 2023 08:37:00 +0100 (CET) Received: from mail-ej1-x632.google.com (mail-ej1-x632.google.com [IPv6:2a00:1450:4864:20::632]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7AEF985475 for ; Mon, 9 Jan 2023 08:36:57 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ej1-x632.google.com with SMTP id vm8so17877343ejc.2 for ; Sun, 08 Jan 2023 23:36:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=SfUsrMTMXVB9TN7DZeqGuYN3DKUNRVPqhytXh+APRys=; b=sDfyd7DTBCORfrTbIiS9TW4fwykEN8lFGjGNE430zG+mnJ/NHcue7rS6fa229IgxYV gj5mnDixLTSBmYzSgP0DY9QD05WPSAFi3TZIyJoQzDTC/s9Mtx7IXbvMyIu5LVwirt3A XR5CcDJUsejLTOgfcDAf08YKC9WLyJgR7iAiXvGXooS1jm0/q/kb2oXSjxB4gDndMQ7q i8hQ38nC7CIwEVgIIUFZsRdqY4qXXew0aqQgH0x9Nujla78akxY5l5UdFBEzKE28qqEv KJlVv+mCfsSi4LcCtyq8qlHPn5GAJk+13bgpObw4hK232f3PKJK7bEQFp5RVs4RBfCrt 6fcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=SfUsrMTMXVB9TN7DZeqGuYN3DKUNRVPqhytXh+APRys=; b=SPwr+deh3JRzuBPZUQPPOfDV8+TfZnYHdinRD5w2VnrYAKVgIWPjqDZiK0yrrOgclf /8Y3OmDtZaQQLfVghxXVCLnEICIVX0p44Cnwl022kRSPLkNAlxgBt/6OF9VB+Neu85sU EoPNUIm9mGsIi/Ub88M94XaGdNzJ8MfsmWV1ZEhZLW/hkNlWeSgbWi3Wqc1wqPkmQJhA j56v7aiagW46k3XWJOvu1j65igCHd2HPjZkoDWeBffwgrnhXe1nNTJwZkkLLCydc0rAV pCpkQ6cXh0n4KJYbg3lCjX72dPhUxBFFX3+aU91gkuWhxa+Zi9pLFn45ZdIK2PpNPPvU /JLQ== X-Gm-Message-State: AFqh2kqpxG4XkivCsROXQ8hzymFBZHt7ZEGlm5R1ouskJniBy/7QveyM yDE4fx0wRNfW6P/53VQHbWNdFQ== X-Google-Smtp-Source: AMrXdXs7dXW0tsnt3xcPPNfyz1G/r4To3z007iMup1s0pmaGPqhTqHWTHf5LSFSq8QT8Pn6WrAm+Iw== X-Received: by 2002:a17:907:6d85:b0:83f:748a:5c6e with SMTP id sb5-20020a1709076d8500b0083f748a5c6emr89284763ejc.71.1673249817118; Sun, 08 Jan 2023 23:36:57 -0800 (PST) Received: from hades (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id f4-20020a50ee84000000b00494dcc5047asm3367031edr.22.2023.01.08.23.36.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 08 Jan 2023 23:36:56 -0800 (PST) Date: Mon, 9 Jan 2023 09:36:54 +0200 From: Ilias Apalodimas To: Jassi Brar Cc: u-boot@lists.denx.de, etienne.carriere@linaro.org, trini@konsulko.com, sjg@chromium.org, sughosh.ganu@linaro.org, xypron.glpk@gmx.de, patrick.delaunay@foss.st.com, patrice.chotard@foss.st.com, Jassi Brar Subject: Re: [PATCHv3 1/5] fwu: gpt: use cached meta-data partition numbers Message-ID: References: <20230102182532.2411125-1-jaswinder.singh@linaro.org> <20230102182619.2411192-1-jaswinder.singh@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230102182619.2411192-1-jaswinder.singh@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Mon, Jan 02, 2023 at 12:26:19PM -0600, Jassi Brar wrote: > Use cached values and avoid parsing and scanning through partitions > everytime for meta-data partitions because they can't change after bootup. > > Acked-by: Etienne Carriere > Signed-off-by: Jassi Brar > --- > drivers/fwu-mdata/gpt_blk.c | 43 +++++++++++++++++++++---------------- > 1 file changed, 24 insertions(+), 19 deletions(-) > > diff --git a/drivers/fwu-mdata/gpt_blk.c b/drivers/fwu-mdata/gpt_blk.c > index d35ce49c5c..28f5d23e1e 100644 > --- a/drivers/fwu-mdata/gpt_blk.c > +++ b/drivers/fwu-mdata/gpt_blk.c > @@ -24,8 +24,9 @@ enum { > MDATA_WRITE, > }; > > -static int gpt_get_mdata_partitions(struct blk_desc *desc, > - uint mdata_parts[2]) > +static uint g_mdata_part[2]; /* = {0, 0} to check against uninit parts */ > + > +static int gpt_get_mdata_partitions(struct blk_desc *desc) > { > int i, ret; > u32 nparts; > @@ -33,18 +34,19 @@ static int gpt_get_mdata_partitions(struct blk_desc *desc, > struct disk_partition info; > const efi_guid_t fwu_mdata_guid = FWU_MDATA_GUID; > > + /* if primary and secondary partitions already found */ > + if (g_mdata_part[0] && g_mdata_part[1]) > + return 0; > + > nparts = 0; > - for (i = 1; i < MAX_SEARCH_PARTITIONS; i++) { > + for (i = 1; i < MAX_SEARCH_PARTITIONS && nparts < 2; i++) { > if (part_get_info(desc, i, &info)) > continue; > uuid_str_to_bin(info.type_guid, part_type_guid.b, > UUID_STR_FORMAT_GUID); > > - if (!guidcmp(&fwu_mdata_guid, &part_type_guid)) { > - if (nparts < 2) > - mdata_parts[nparts] = i; > - ++nparts; > - } > + if (!guidcmp(&fwu_mdata_guid, &part_type_guid)) > + g_mdata_part[nparts++] = i; > } > > if (nparts != 2) { > @@ -127,26 +129,25 @@ static int fwu_gpt_update_mdata(struct udevice *dev, struct fwu_mdata *mdata) > { > int ret; > struct blk_desc *desc; > - uint mdata_parts[2]; > struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > > desc = dev_get_uclass_plat(priv->blk_dev); > > - ret = gpt_get_mdata_partitions(desc, mdata_parts); > + ret = gpt_get_mdata_partitions(desc); > if (ret < 0) { > log_debug("Error getting the FWU metadata partitions\n"); > return -ENOENT; > } > > /* First write the primary partition */ > - ret = gpt_read_write_mdata(desc, mdata, MDATA_WRITE, mdata_parts[0]); > + ret = gpt_read_write_mdata(desc, mdata, MDATA_WRITE, g_mdata_part[0]); > if (ret < 0) { > log_debug("Updating primary FWU metadata partition failed\n"); > return ret; > } > > /* And now the replica */ > - ret = gpt_read_write_mdata(desc, mdata, MDATA_WRITE, mdata_parts[1]); > + ret = gpt_read_write_mdata(desc, mdata, MDATA_WRITE, g_mdata_part[1]); > if (ret < 0) { > log_debug("Updating secondary FWU metadata partition failed\n"); > return ret; > @@ -158,16 +159,14 @@ static int fwu_gpt_update_mdata(struct udevice *dev, struct fwu_mdata *mdata) > static int gpt_get_mdata(struct blk_desc *desc, struct fwu_mdata *mdata) > { > int ret; > - uint mdata_parts[2]; > - > - ret = gpt_get_mdata_partitions(desc, mdata_parts); > > + ret = gpt_get_mdata_partitions(desc); > if (ret < 0) { > log_debug("Error getting the FWU metadata partitions\n"); > return -ENOENT; > } > > - ret = gpt_read_write_mdata(desc, mdata, MDATA_READ, mdata_parts[0]); > + ret = gpt_read_write_mdata(desc, mdata, MDATA_READ, g_mdata_part[0]); > if (ret < 0) { > log_debug("Failed to read the FWU metadata from the device\n"); > return -EIO; > @@ -182,7 +181,7 @@ static int gpt_get_mdata(struct blk_desc *desc, struct fwu_mdata *mdata) > * Try to read the replica. > */ > memset(mdata, '\0', sizeof(struct fwu_mdata)); > - ret = gpt_read_write_mdata(desc, mdata, MDATA_READ, mdata_parts[1]); > + ret = gpt_read_write_mdata(desc, mdata, MDATA_READ, g_mdata_part[1]); > if (ret < 0) { > log_debug("Failed to read the FWU metadata from the device\n"); > return -EIO; > @@ -206,9 +205,15 @@ static int fwu_gpt_get_mdata(struct udevice *dev, struct fwu_mdata *mdata) > static int fwu_gpt_get_mdata_partitions(struct udevice *dev, uint *mdata_parts) > { > struct fwu_mdata_gpt_blk_priv *priv = dev_get_priv(dev); > + int err; > + > + err = gpt_get_mdata_partitions(dev_get_uclass_plat(priv->blk_dev)); > + if (!err) { > + mdata_parts[0] = g_mdata_part[0]; > + mdata_parts[1] = g_mdata_part[1]; > + } > > - return gpt_get_mdata_partitions(dev_get_uclass_plat(priv->blk_dev), > - mdata_parts); > + return err; > } > > static int fwu_gpt_read_mdata_partition(struct udevice *dev, > -- > 2.34.1 > Reviewed-by: Ilias Apalodimas