From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FBA1C67871 for ; Mon, 9 Jan 2023 16:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234756AbjAIQxx (ORCPT ); Mon, 9 Jan 2023 11:53:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45944 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237123AbjAIQx0 (ORCPT ); Mon, 9 Jan 2023 11:53:26 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3898D958E; Mon, 9 Jan 2023 08:52:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C02FC611EC; Mon, 9 Jan 2023 16:52:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AF0A2C433D2; Mon, 9 Jan 2023 16:52:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673283160; bh=mRTcU5DgoJZ9IoZF19Noim1g8fgOIG9OELRUEBbUrDM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iSPzQBzwtUDkQNt8lapcRIpErc2yJKjPA+XKF0geXDvm1G3Kx+fowf6npXXVquNnn S/rY4mhClUlu9uFHoJBnXHRmMoWh1J79FFS7D/JI1acB3GS/8QF414/J4Yh/eNxqka z9Q+AyeK0Oyo/HvG4NZ9Ix0YH+X+N10dzG3MFAuXW3WqErybrcOlWlB3xWy9erlE9V /c1pWah5KRhLHJBvjavfeIv8GA0G05a82LAXBwZo0YgDVXcNEB0DF9jzf8PGp+M6xG xJvPMSnTWuOat+xB7etb3Uas/+C5DnDoXux7t0xKNHAWp336P/8M/j/6wDyyqdeQWl TtY8bC/dsSBbA== Date: Mon, 9 Jan 2023 16:52:34 +0000 From: Lee Jones To: Krzysztof Kozlowski Cc: Pavel Machek , Chuanhong Guo , linux-leds@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Stanislav Jakubek , Linus Walleij , Shawn Guo , Johan Hovold , Bjorn Andersson , Marijn Suijten , Sven Schwermer , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Subject: Re: [PATCH v4 2/3] dt-bindings: leds: add worldsemi,ws2812b Message-ID: References: <20221212045558.69602-1-gch981213@gmail.com> <20221212045558.69602-3-gch981213@gmail.com> <9d2c05f6-af5a-2d79-02ea-85c49e244957@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d2c05f6-af5a-2d79-02ea-85c49e244957@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Sat, 24 Dec 2022, Krzysztof Kozlowski wrote: > On 23/12/2022 18:19, Pavel Machek wrote: > > Hi! > > > >>> Add dt binding schema for WorldSemi WS2812B driven using SPI > >>> bus. > >>> > >>> Signed-off-by: Chuanhong Guo > >>> --- > >>> Changes since v1: > >>> remove linux driver reference from description > >>> remove some obvious descriptions > >>> fix unit address regex in multi-led property > >>> drop various minItems > >>> add maxItems = 1 to reg > >>> fix node names and property orders in binding example > >>> drop -spi from compatible string > >>> add default-brightness > >>> > >>> Change since v2: > >>> drop "this patch" from commit message > >>> rename leds to led-controller > >>> drop default-brightness and default-intensity > >>> > >>> Change since v3: > >>> reword commit title > >>> > >>> .../bindings/leds/worldsemi,ws2812b.yaml | 116 ++++++++++++++++++ > >>> 1 file changed, 116 insertions(+) > >>> create mode 100644 Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > >>> > >>> diff --git a/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > >>> new file mode 100644 > >>> index 000000000000..548c05ac3d31 > >>> --- /dev/null > >>> +++ b/Documentation/devicetree/bindings/leds/worldsemi,ws2812b.yaml > >>> @@ -0,0 +1,116 @@ > >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>> +%YAML 1.2 > >>> +--- > >>> +$id: http://devicetree.org/schemas/leds/worldsemi,ws2812b.yaml# > >>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>> + > >>> +title: WS2812B LEDs driven using SPI > >>> + > >>> +maintainers: > >>> + - Chuanhong Guo > >>> + > >>> +description: | > >>> + WorldSemi WS2812B is a individually addressable LED chip that can be chained > >>> + together and controlled individually using a single wire. > >>> + This binding describes a chain of WS2812B LEDs connected to the SPI MOSI pin. > >>> + Typical setups includes connecting the data pin of the LED chain to MOSI as > >>> + the only device or using CS and MOSI with a tri-state voltage-level shifter > >>> + for the data pin. > >>> + The SPI frequency needs to be 2.105MHz~2.85MHz for the timing to be correct > >>> + and the controller needs to send all the bytes continuously. > >>> + > >>> +allOf: > >>> + - $ref: /schemas/spi/spi-peripheral-props.yaml# > >>> + > >>> +properties: > >>> + compatible: > >>> + const: worldsemi,ws2812b > >>> + > >>> + reg: > >>> + maxItems: 1 > >>> + > >>> + spi-max-frequency: > >>> + minimum: 2105000 > >>> + maximum: 2850000 > >>> + > >>> + "#address-cells": > >>> + const: 1 > >>> + > >>> + "#size-cells": > >>> + const: 0 > >>> + > >>> +patternProperties: > >>> + "^multi-led@[0-9a-f]+$": > >>> + type: object > >>> + $ref: leds-class-multicolor.yaml# > >>> + unevaluatedProperties: false > >>> + > >>> + properties: > >>> + color-index: Why "index"? Isn't it just an array of colours rather than an index into something? > >>> + description: | > >>> + A 3-item array specifying color of each components in this LED. It Why are you forcing this to 3? Surely there are multi-colour LEDs containing more or less colours? > >>> + should be one of the LED_COLOR_ID_* prefixed definitions from the > >>> + header include/dt-bindings/leds/common.h. Defaults to Isn't "include" a Linuxisum? > >>> + > >>> + if unspecified. > >>> + $ref: /schemas/types.yaml#/definitions/uint32-array > >>> + maxItems: 3 > >> > >> In general I am fine with it, although there is still question for > >> adding more multi-color defines in binding headers to replace this > >> property - GRB/RBG/GBR and even more for RGBW. > >> > >> Pavel, Lee, any thoughts from your side? > > > > This really needs to mention the name this hardware is known as -- I > > believe it is NeoPixel. > > We wait here for feedback on colors... The binding is re-implementing > color, just because of combinations GRB/RBG/GBR, which could be achieved > with new color defines. Sure, but where does that end? How many permutations are there likely to be? An unlimited array has more of a chance of standing the test of time. -- Lee Jones [李琼斯]