From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 335CCC5479D for ; Mon, 9 Jan 2023 18:21:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0DA0F10E4E1; Mon, 9 Jan 2023 18:21:06 +0000 (UTC) Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [IPv6:2a02:2350:5:403::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F23B10E4E1 for ; Mon, 9 Jan 2023 18:21:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lee Jones , Stephen Kitt , Greg Kroah-Hartman , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Paul Mackerras , Daniel Thompson , Antonino Daplas , Helge Deller , "linux-staging@lists.linux.dev" , Daniel Vetter , Miguel Ojeda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jason Yan , Robin van der Gracht , Nicolas Ferre , Souptick Joarder , Jingoo Han , "linuxppc-dev@lists.ozlabs.org" , Claudiu Beznea Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > > > Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > When I read 'introduce' I understand that you are adding a new function. > > In fact backlight_get_brightness() already exists, so maybe replace > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [46.30.211.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017B06108 for ; Mon, 9 Jan 2023 18:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Cc: Nicolas Ferre , Helge Deller , Alexandre Belloni , Claudiu Beznea , Antonino Daplas , Benjamin Herrenschmidt , Paul Mackerras , Greg Kroah-Hartman , Robin van der Gracht , Miguel Ojeda , Lee Jones , Daniel Thompson , Jingoo Han , "linux-fbdev@vger.kernel.org" , Stephen Kitt , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , "linux-staging@lists.linux.dev" , Maarten Lankhorst , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Jason Yan , Souptick Joarder , Daniel Vetter , "linux-omap@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > > > Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > When I read 'introduce' I understand that you are adding a new function. > > In fact backlight_get_brightness() already exists, so maybe replace > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7F7A8C54EBD for ; Mon, 9 Jan 2023 18:31:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rEbLOu0D3WNEScGUoqxEMynXNLi5izYxFphFHjqpwVY=; b=A0JmKYysRXKl4I oM6kw7DTFlyjHQZbzDPYSueesd3zZYFNc4DMeKGVAn42jLkPiqoSwPuJ+NJGnUPFXMlnfROBhhHLk cEp7iEWkxPrkrETvPN3d27q4swIOPX9WXrIa/GX/mItyqDRZd7YQG0w1AjSN0Ic3zCUy+YHe7d6NI n9ERGEAE1v/bT8Rcrj5OGCbTH+1jDnE2WEV1jqcTRcrL1vDY0x3jC3a9gg5t0o4Hir7zzPjnRNFEM Sw26bjwWsWtLOv+arpU+SSdD0Zu2cnk9KdlU+ulc0aXnrC5iI6Zqd8YVa1Tm3T6xcnZOqsJl3/Kho /Y4Gfj5/x/rM++zsxetw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEwty-003IYc-Fc; Mon, 09 Jan 2023 18:29:44 +0000 Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com ([2a02:2350:5:403::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pEwlg-003Ee6-Qk for linux-arm-kernel@lists.infradead.org; Mon, 09 Jan 2023 18:21:12 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230109_102109_052797_B02F7E0B X-CRM114-Status: GOOD ( 12.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lee Jones , Stephen Kitt , Greg Kroah-Hartman , Benjamin Herrenschmidt , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Paul Mackerras , Daniel Thompson , Antonino Daplas , Helge Deller , "linux-staging@lists.linux.dev" , Daniel Vetter , Miguel Ojeda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , Maarten Lankhorst , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jason Yan , Robin van der Gracht , Souptick Joarder , Jingoo Han , "linuxppc-dev@lists.ozlabs.org" , Claudiu Beznea Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > = > = > Le 07/01/2023 =E0 19:26, Sam Ravnborg via B4 Submission Endpoint a =E9cri= t=A0: > > From: Sam Ravnborg > > = > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > = > When I read 'introduce' I understand that you are adding a new function. > = > In fact backlight_get_brightness() already exists, so maybe replace = > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E3C0C54EBD for ; Mon, 9 Jan 2023 18:38:25 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4NrN4H59HVz3cKr for ; Tue, 10 Jan 2023 05:38:23 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=ravnborg.org header.i=@ravnborg.org header.a=rsa-sha256 header.s=rsa2 header.b=xr+iUWmf; dkim=fail reason="signature verification failed" header.d=ravnborg.org header.i=@ravnborg.org header.a=ed25519-sha256 header.s=ed2 header.b=nxcQ2DNw; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.helo=mailrelay4-1.pub.mailoutpod2-cph3.one.com (client-ip=46.30.211.179; helo=mailrelay4-1.pub.mailoutpod2-cph3.one.com; envelope-from=sam@ravnborg.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=ravnborg.org header.i=@ravnborg.org header.a=rsa-sha256 header.s=rsa2 header.b=xr+iUWmf; dkim=pass header.d=ravnborg.org header.i=@ravnborg.org header.a=ed25519-sha256 header.s=ed2 header.b=nxcQ2DNw; dkim-atps=neutral Received: from mailrelay4-1.pub.mailoutpod2-cph3.one.com (mailrelay4-1.pub.mailoutpod2-cph3.one.com [46.30.211.179]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4NrN380KYMz3c3N for ; Tue, 10 Jan 2023 05:37:21 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ravnborg.org; s=rsa2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=xr+iUWmfOB1CLBr6Qsy2YZMDRotm12WBZ/zh+3qIGnqD+WW38gq16Rl6LS9taWAIgXP2llv2ueyF0 fA3iIIxYnmuPGkwiK+SGk3l7yHRvIxggcTtT7x2q0+wwF6fVIQkEzPtcW04Q4A6X4SKS9m56vo7D0o hLzfG7GraTS31Ch8FAtoGue7T76SmYvTnNeZNZkj0/5oK6YNNivj7Wo0ExtjbmvCmHRBteAPdkj/Eg NkDkGI6lGIPAVh39LbMkR8Ej5M2GsnANIVRaeRashpzz54gdLod6v1ri7V6JrPjvdhVHIVaCwftjs+ 2rttIhFTMoveJDSDeM23dX3GpjUJUVw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=ravnborg.org; s=ed2; h=in-reply-to:content-transfer-encoding:content-type:mime-version:references: message-id:subject:cc:to:from:date:from; bh=wZxH/nDf40/5XX4K0N7bveQXBer/ZTbSo4stXhMD1MQ=; b=nxcQ2DNweooGl9o3PknXxmGKMXudrM7A8yocezPtlLEgBpQEu7WtSwjxUTWj2HhN7+D5H3vtKKz4P oB6b4GmAA== X-HalOne-ID: 5e23647e-904a-11ed-85ce-87783a957ad9 Received: from ravnborg.org (2-105-2-98-cable.dk.customer.tdc.net [2.105.2.98]) by mailrelay4 (Halon) with ESMTPSA id 5e23647e-904a-11ed-85ce-87783a957ad9; Mon, 09 Jan 2023 18:21:02 +0000 (UTC) Date: Mon, 9 Jan 2023 19:21:00 +0100 From: Sam Ravnborg To: Christophe Leroy Subject: Re: [PATCH 02/15] video: fbdev: atyfb: Introduce backlight_get_brightness() Message-ID: References: <20230107-sam-video-backlight-drop-fb_blank-v1-0-1bd9bafb351f@ravnborg.org> <20230107-sam-video-backlight-drop-fb_blank-v1-2-1bd9bafb351f@ravnborg.org> <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <04f0f8c7-43cd-f774-c952-eb1cf3494bd8@csgroup.eu> X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , Lee Jones , Stephen Kitt , Greg Kroah-Hartman , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Paul Mackerras , Daniel Thompson , Antonino Daplas , Helge Deller , "linux-staging@lists.linux.dev" , Daniel Vetter , Miguel Ojeda , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Jani Nikula , Maarten Lankhorst , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Jason Yan , Robin van der Gracht , Nicolas Ferre , Souptick Joarder , Jingoo Han , "linuxppc-dev@lists.ozlabs.org" , Claudiu Beznea Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Hi Christophe, On Mon, Jan 09, 2023 at 05:44:46PM +0000, Christophe Leroy wrote: > > > Le 07/01/2023 à 19:26, Sam Ravnborg via B4 Submission Endpoint a écrit : > > From: Sam Ravnborg > > > > Introduce backlight_get_brightness() to simplify logic > > and avoid direct access to backlight properties. > > When I read 'introduce' I understand that you are adding a new function. > > In fact backlight_get_brightness() already exists, so maybe replace > 'introduce' by 'use' Thanks for your feedback. A similar patch is already applied to the fbdev tree, so this patch can be ignored. Sam