From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4AD7FC38142 for ; Tue, 24 Jan 2023 10:25:42 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 43922855D7; Tue, 24 Jan 2023 11:25:40 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="tee0iF4Y"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 6F255855EB; Tue, 24 Jan 2023 11:25:38 +0100 (CET) Received: from mail-ed1-x536.google.com (mail-ed1-x536.google.com [IPv6:2a00:1450:4864:20::536]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id B2860855C7 for ; Tue, 24 Jan 2023 11:25:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilias.apalodimas@linaro.org Received: by mail-ed1-x536.google.com with SMTP id x10so17725825edd.10 for ; Tue, 24 Jan 2023 02:25:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=rjRm7fsxISBXe6LExhXvySUJ2haosT9bGRQbSKIjbUE=; b=tee0iF4Ygr3SoutKZ90GhFL45+vmJxQgyDeaKUYyawxQEqi56gH0GfMk1fEap7qwV4 QP/7CxNa8Xdp4ecz4g1DY4c/d3iyH40a8Ky+CuD/hEvo8DGzp45OQcm3buCnZyopn5M5 kf18IpcZkhChGyJmRgcG984xWkZn2WPCi3OtVU3mvWt1pVLQAzaup+3n1jHpCIIcnDou wsxliJDWbpI4Mb9LROUXps05MLeAf0iK12BCErnuont3OjwBCKQdhx9MwFjcEujq59xL 6d8Jm1S/4dTV+JHzGl+yA+et8gKxc1vT8iQI1O4PIhNjdTVd82aMUMcxMAEFTfFdwCWq HbpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=rjRm7fsxISBXe6LExhXvySUJ2haosT9bGRQbSKIjbUE=; b=qQHBl5YsFPLwzP2m/RlHXPUaB8HcjTyBt9pEI4LuAo1VbkT/vN5mai4ytsNVUslzbn ym6F/vnUPpZ51hOIxpg+dqEq9eyRd0uqMKfZubGFvAteBYKTp66GB4qVPalVonZQ7VIY 3IeVDlKdYTfVGHXRkeumXFrtNX9SCHy9pSssdeY09cJF/tR/AF61sKziLuXCUbDrclvL Fa2uasuhocrHeA1eIkbI9XpcYuRUvzAsnvPOJNJkcKT+bcp7LarX7QF38Zjvv5121ZiI NSNAHhNfV9cSotihLt7I/MOC8De6NDEZ7TXJWTrm7TLq/XQ/yiiImPVOG6QPvGaQ+kN6 pxiw== X-Gm-Message-State: AFqh2kqKliSLPdfH1dqBD4Zbl8Vi8gUMU60jyKp/IRwgFDahuR0fEy8X ZK4SNXuLmiT3NvSGd3/ppXo1MQ== X-Google-Smtp-Source: AMrXdXtHFs1VCH501GvzMlAan00GrbIxaJWVwpNL8Ixya4MqXrVpayf8V3w2ClG1FEdX30fYfqL3+g== X-Received: by 2002:a05:6402:430c:b0:49e:50e:1553 with SMTP id m12-20020a056402430c00b0049e050e1553mr38924736edc.3.1674555934309; Tue, 24 Jan 2023 02:25:34 -0800 (PST) Received: from hera (ppp079167090036.access.hol.gr. [79.167.90.36]) by smtp.gmail.com with ESMTPSA id h26-20020aa7c95a000000b0049019b48373sm851921edt.85.2023.01.24.02.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Jan 2023 02:25:33 -0800 (PST) Date: Tue, 24 Jan 2023 12:25:31 +0200 From: Ilias Apalodimas To: Heinrich Schuchardt Cc: u-boot@lists.denx.de Subject: Re: [PATCH 1/1] efi_loader: fix comment in ESRT code Message-ID: References: <20230123232645.7449-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230123232645.7449-1-heinrich.schuchardt@canonical.com> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On Tue, Jan 24, 2023 at 12:26:45AM +0100, Heinrich Schuchardt wrote: > There is no variable num_pages in function efi_esrt_allocate_install(). > > Signed-off-by: Heinrich Schuchardt > --- > lib/efi_loader/efi_esrt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/efi_loader/efi_esrt.c b/lib/efi_loader/efi_esrt.c > index dcc08a6d3a..7f46d651e6 100644 > --- a/lib/efi_loader/efi_esrt.c > +++ b/lib/efi_loader/efi_esrt.c > @@ -115,7 +115,7 @@ efi_status_t efi_esrt_allocate_install(u32 num_entries) > u32 size = efi_esrt_entries_to_size(num_entries); > efi_guid_t esrt_guid = efi_esrt_guid; > > - /* Reserve num_pages for ESRT */ > + /* Reserve memory for ESRT */ > ret = efi_allocate_pool(EFI_BOOT_SERVICES_DATA, size, > (void **)&new_esrt); > > -- > 2.38.1 > Reviewed-by: Ilias Apalodimas