From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 238A1C38142 for ; Mon, 23 Jan 2023 06:59:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231500AbjAWG7n (ORCPT ); Mon, 23 Jan 2023 01:59:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48674 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231483AbjAWG7l (ORCPT ); Mon, 23 Jan 2023 01:59:41 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A48FA13DE9; Sun, 22 Jan 2023 22:59:38 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3251DB80BEA; Mon, 23 Jan 2023 06:59:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 896E9C433EF; Mon, 23 Jan 2023 06:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674457175; bh=oruDvn5Mc2ikihY0Gp535LHpXV69DqgvDQhed9bm0sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uM2qnvMoyR6bH/uoiqSTyrjMVyhh39uGnNOhVzwhonP5ZJytyfswVZ6vOdWk5IpOY koWxTemvu1K3WD2Otz898dCYddboAHzeEA96tjy780rry22qmpU7T5uCQ/0vPcKSyY 52aYTfinuWF/MVqHIVqG+QRd0ZJtV7tC6JB+784Nwg00GDmBR/ruk/9NOe5ukFY/bT moEazkRfdn7KuPw2mPP7wM3mjekVMraLHkYVfKKkuUDyUg92o9FpiwwnBQzVPgk+TC HzliX49T3rLuvDIuj13oRaOnqBif9i1ETGVsCkezHqGk139Ee3v8CRZnxKN0TWHkI/ J3lYtuGfD6Ksg== Date: Sun, 22 Jan 2023 22:59:33 -0800 From: Eric Biggers To: Jaegeuk Kim Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, akpm@linux-foundation.org, linux-ext4@vger.kernel.org, Alexander Potapenko Subject: Re: [PATCH 3/5] fs: f2fs: initialize fsdata in pagecache_write() Message-ID: References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-3-glider@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 21, 2022 at 07:53:19PM +0000, Eric Biggers wrote: > On Mon, Nov 21, 2022 at 12:21:32PM +0100, Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally initializing fsdata. > > > > Suggested-by: Eric Biggers > > Fixes: 95ae251fe828 ("f2fs: add fs-verity support") > > Signed-off-by: Alexander Potapenko > > --- > > fs/f2fs/verity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c > > index c352fff88a5e6..3f4f3295f1c66 100644 > > --- a/fs/f2fs/verity.c > > +++ b/fs/f2fs/verity.c > > @@ -81,7 +81,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > > size_t n = min_t(size_t, count, > > PAGE_SIZE - offset_in_page(pos)); > > struct page *page; > > - void *fsdata; > > + void *fsdata = NULL; > > int res; > > > > res = aops->write_begin(NULL, mapping, pos, n, &page, &fsdata); > > Reviewed-by: Eric Biggers > Jaegeuk, can you please apply this patch? - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B6984C38142 for ; Mon, 23 Jan 2023 06:59:49 +0000 (UTC) Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1pJqo0-0008Ch-LG; Mon, 23 Jan 2023 06:59:47 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pJqnz-0008Cb-32 for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Jan 2023 06:59:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fqQnBSy5k1++LEeLhg51ySvvJlFZ4PVXt/L1aIE5yEk=; b=I97Ta7AjWY9FUnw1O0CLLeJk9C PsiixcTQaYMJcnql3TuIbZqqxQa7LY0Ce2W+D0IlQ73pIqCr+p5Q5GapaX6M1T1ruSLF7VBXO+YQw w+iZMCqP0A4J6sv9gjvPs43srdL1oPwGeYY6SVOdjYwOXL8efmprZgKe+whZmm+1cwVY=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fqQnBSy5k1++LEeLhg51ySvvJlFZ4PVXt/L1aIE5yEk=; b=CORreUlx8eEPu0sXst94UMWVQA f/VEnCMPsEUIS5QamLgmaBXcUvkOIeCD7kc/zpYkKH+rNWJ9dHU8ZpnZG1IdBfuYBr0ucV+bIpAdd Sb4kFL1hJKKdGqQWVFPd22QuMOyuos97zP69kCFzbNqrKjYcaLZyTGM+Gg5KG5pZdmws=; Received: from dfw.source.kernel.org ([139.178.84.217]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1pJqnx-0002fw-2H for linux-f2fs-devel@lists.sourceforge.net; Mon, 23 Jan 2023 06:59:45 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6DFDC60CF3; Mon, 23 Jan 2023 06:59:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 896E9C433EF; Mon, 23 Jan 2023 06:59:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674457175; bh=oruDvn5Mc2ikihY0Gp535LHpXV69DqgvDQhed9bm0sc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=uM2qnvMoyR6bH/uoiqSTyrjMVyhh39uGnNOhVzwhonP5ZJytyfswVZ6vOdWk5IpOY koWxTemvu1K3WD2Otz898dCYddboAHzeEA96tjy780rry22qmpU7T5uCQ/0vPcKSyY 52aYTfinuWF/MVqHIVqG+QRd0ZJtV7tC6JB+784Nwg00GDmBR/ruk/9NOe5ukFY/bT moEazkRfdn7KuPw2mPP7wM3mjekVMraLHkYVfKKkuUDyUg92o9FpiwwnBQzVPgk+TC HzliX49T3rLuvDIuj13oRaOnqBif9i1ETGVsCkezHqGk139Ee3v8CRZnxKN0TWHkI/ J3lYtuGfD6Ksg== Date: Sun, 22 Jan 2023 22:59:33 -0800 From: Eric Biggers To: Jaegeuk Kim Message-ID: References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-3-glider@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1pJqnx-0002fw-2H Subject: Re: [f2fs-dev] [PATCH 3/5] fs: f2fs: initialize fsdata in pagecache_write() X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: tytso@mit.edu, Alexander Potapenko , linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, adilger.kernel@dilger.ca, linux-fsdevel@vger.kernel.org, jaegeuk@kernel.org, akpm@linux-foundation.org, linux-ext4@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On Mon, Nov 21, 2022 at 07:53:19PM +0000, Eric Biggers wrote: > On Mon, Nov 21, 2022 at 12:21:32PM +0100, Alexander Potapenko wrote: > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > an error passing the latter to aops->write_end(). > > > > Fix this by unconditionally initializing fsdata. > > > > Suggested-by: Eric Biggers > > Fixes: 95ae251fe828 ("f2fs: add fs-verity support") > > Signed-off-by: Alexander Potapenko > > --- > > fs/f2fs/verity.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c > > index c352fff88a5e6..3f4f3295f1c66 100644 > > --- a/fs/f2fs/verity.c > > +++ b/fs/f2fs/verity.c > > @@ -81,7 +81,7 @@ static int pagecache_write(struct inode *inode, const void *buf, size_t count, > > size_t n = min_t(size_t, count, > > PAGE_SIZE - offset_in_page(pos)); > > struct page *page; > > - void *fsdata; > > + void *fsdata = NULL; > > int res; > > > > res = aops->write_begin(NULL, mapping, pos, n, &page, &fsdata); > > Reviewed-by: Eric Biggers > Jaegeuk, can you please apply this patch? - Eric _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel