From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE22C54E94 for ; Mon, 23 Jan 2023 17:03:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232730AbjAWRC7 (ORCPT ); Mon, 23 Jan 2023 12:02:59 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39522 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232856AbjAWRCz (ORCPT ); Mon, 23 Jan 2023 12:02:55 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E2AB4D3; Mon, 23 Jan 2023 09:02:52 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 8D3FDB80BA2; Mon, 23 Jan 2023 17:02:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C6F9C433EF; Mon, 23 Jan 2023 17:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674493370; bh=N50BI0eAmKLyjzAgI2VcGiyz4oyDgkoQN9/RlfmJQ9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g8lMhEHWsshNL4zKOk9nAg2yTrPyeUIAoqur5h7IY9O+Xu/yeqLKrDaRpDPfHEKlA O9b0S8d0aMfBF4hs+p8h8OTTD6RhVX29cZ8lmhjhMBk44lnEkYC7C2QQS/TCYMJsCh 2Q17QM/4AykEFk7NAvhkQUJVk4HeWAimyaCTWCJSpFbLJ8e1g+fC6ZC8KtmHIn7I+m Zj2EBxvuIEu4ChmAbD1NKEnXo8Fs3uGhB6TNpVHQV1mWuULrdW+9pNcoIak83EL03h 3xDS4mNwVU8sUHzSKEvMv3+IbtxsCW8i8Zd7dyGqhU0F9QtfFQajKwNMEOUxdqRBnZ 334Ir4u3bWiCw== Date: Mon, 23 Jan 2023 18:34:26 +0200 From: Leon Romanovsky To: Simon Horman Cc: "David S . Miller" , Jakub Kicinski , Steffen Klassert , Andy Gospodarek , Ayush Sawal , Eric Dumazet , Herbert Xu , intel-wired-lan@lists.osuosl.org, Jay Vosburgh , Jesse Brandeburg , Jonathan Corbet , linux-doc@vger.kernel.org, netdev@vger.kernel.org, oss-drivers@corigine.com, Paolo Abeni , Raju Rangoju , Saeed Mahameed , Tony Nguyen , Veaceslav Falico Subject: Re: [PATCH net-next 06/10] nfp: fill IPsec state validation failure reason Message-ID: References: <99049389f2f4fb967aac8026bd05f36ea13c47aa.1674481435.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Jan 23, 2023 at 04:09:20PM +0100, Simon Horman wrote: > On Mon, Jan 23, 2023 at 04:00:19PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Rely on extack to return failure reason. > > > > Signed-off-by: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > > One minor suggestion below, but regardless this looks good to me. > > Reviewed-by: Simon Horman > > > --- > > .../net/ethernet/netronome/nfp/crypto/ipsec.c | 38 +++++++++---------- > > 1 file changed, 19 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > index 41b98f2b7402..7af41cbc8c0b 100644 > > --- a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > +++ b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > ... > > > if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) { > > - nn_err(nn, "Unsupported xfrm offload tyoe\n"); > > + NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload tyoe"); > > While we are here, maybe s/tyoe/type/ ? Sure, will fix. Thanks > > ... From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B349C05027 for ; Mon, 23 Jan 2023 17:02:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id F007E40AD1; Mon, 23 Jan 2023 17:02:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F007E40AD1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1674493376; bh=WO5u+1vLfTXH2ycMBMvCzyDcwLnT/EqWxE6XBpr3opE=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=G0QvtlumveZlcuHcJvOATAG2uGHzlfdWq9RSKdfXUwSB236YNK6pZaut5cSf6l0fy u5ThtOP8Mei4SLmg7dpPnYA7CMLqpeFnMsbleX5blNMkuxbJX+C1PbuAVygv8Um7R3 q3xgqRJ7m8EFf1I+Aonlr27n51w0+gjf5ECKMAr7a6Z55yZ9trRvcSMZ4TrvbB4RXA 7BGKwi33dMLNweIGsU9bE019SqqmWnihpMZ+PZQxrmb+M6tVkfRZ7LekwmnJ8ZAgS/ 70nkH7kOv6GUmSBdwQU8cIXwEno/i+grcqq+rr2LLtpGbRbDnqn0FfnT7E7nRZJ4/A aaCwrces+x0Eg== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RVgDHSK0lHbH; Mon, 23 Jan 2023 17:02:55 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id 10C0640AD9; Mon, 23 Jan 2023 17:02:55 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 10C0640AD9 Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 226F21BF859 for ; Mon, 23 Jan 2023 17:02:53 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id F04F7417B0 for ; Mon, 23 Jan 2023 17:02:52 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org F04F7417B0 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Hh8T7Qr3miTg for ; Mon, 23 Jan 2023 17:02:52 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 063F4417A8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp4.osuosl.org (Postfix) with ESMTPS id 063F4417A8 for ; Mon, 23 Jan 2023 17:02:51 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C1F3D60F1F; Mon, 23 Jan 2023 17:02:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C6F9C433EF; Mon, 23 Jan 2023 17:02:49 +0000 (UTC) Date: Mon, 23 Jan 2023 18:34:26 +0200 From: Leon Romanovsky To: Simon Horman Message-ID: References: <99049389f2f4fb967aac8026bd05f36ea13c47aa.1674481435.git.leon@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674493370; bh=N50BI0eAmKLyjzAgI2VcGiyz4oyDgkoQN9/RlfmJQ9o=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=g8lMhEHWsshNL4zKOk9nAg2yTrPyeUIAoqur5h7IY9O+Xu/yeqLKrDaRpDPfHEKlA O9b0S8d0aMfBF4hs+p8h8OTTD6RhVX29cZ8lmhjhMBk44lnEkYC7C2QQS/TCYMJsCh 2Q17QM/4AykEFk7NAvhkQUJVk4HeWAimyaCTWCJSpFbLJ8e1g+fC6ZC8KtmHIn7I+m Zj2EBxvuIEu4ChmAbD1NKEnXo8Fs3uGhB6TNpVHQV1mWuULrdW+9pNcoIak83EL03h 3xDS4mNwVU8sUHzSKEvMv3+IbtxsCW8i8Zd7dyGqhU0F9QtfFQajKwNMEOUxdqRBnZ 334Ir4u3bWiCw== X-Mailman-Original-Authentication-Results: smtp4.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=g8lMhEHW Subject: Re: [Intel-wired-lan] [PATCH net-next 06/10] nfp: fill IPsec state validation failure reason X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Steffen Klassert , Veaceslav Falico , Herbert Xu , Jonathan Corbet , Tony Nguyen , Jay Vosburgh , oss-drivers@corigine.com, linux-doc@vger.kernel.org, Raju Rangoju , Jesse Brandeburg , Eric Dumazet , netdev@vger.kernel.org, intel-wired-lan@lists.osuosl.org, Ayush Sawal , Jakub Kicinski , Paolo Abeni , Saeed Mahameed , "David S . Miller" , Andy Gospodarek Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Jan 23, 2023 at 04:09:20PM +0100, Simon Horman wrote: > On Mon, Jan 23, 2023 at 04:00:19PM +0200, Leon Romanovsky wrote: > > From: Leon Romanovsky > > > > Rely on extack to return failure reason. > > > > Signed-off-by: Leon Romanovsky > > Signed-off-by: Leon Romanovsky > > One minor suggestion below, but regardless this looks good to me. > > Reviewed-by: Simon Horman > > > --- > > .../net/ethernet/netronome/nfp/crypto/ipsec.c | 38 +++++++++---------- > > 1 file changed, 19 insertions(+), 19 deletions(-) > > > > diff --git a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > index 41b98f2b7402..7af41cbc8c0b 100644 > > --- a/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > +++ b/drivers/net/ethernet/netronome/nfp/crypto/ipsec.c > > ... > > > if (x->xso.type != XFRM_DEV_OFFLOAD_CRYPTO) { > > - nn_err(nn, "Unsupported xfrm offload tyoe\n"); > > + NL_SET_ERR_MSG_MOD(extack, "Unsupported xfrm offload tyoe"); > > While we are here, maybe s/tyoe/type/ ? Sure, will fix. Thanks > > ... _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan