From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90A53C54EBD for ; Fri, 13 Jan 2023 10:43:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RHmH4QVViXeQW8bP+RzJJxt8LprjA8ppTmKJ6mhM6cs=; b=q+wYkMui8XAlo4 BxBizsdIr1psaaMPx4iG6RWMCqztb/PpiYFwXg39SRa/DgpVt71C6xis2iuhihi/CvgLlw+rjjIWO Db6/ahjx/1rG3ifUUQnLT+xgoTeZmtaIpZDGOPje8MewNwJq+n4Fm9oVWPyizpeYOb52bb2wAtw3t IwKZkyFoo6N1MZL3hXho6cfVYo+GIghfsSocGXQie0y4WeXRpMJZRqG+/x9lfyjNZHf+cQoBWXHnh Rj64cBkUa2yjBuJETdd6AhNUhv5I4B2BV/+PylVJEpG9XOXpEp+Q3/uT7Rkq9Xeg6VTc4rElS5+3V R4tq3vAykRXdK0TLtfGw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGHVq-001pcp-Fw; Fri, 13 Jan 2023 10:42:18 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGHUm-001p0m-9J for linux-arm-kernel@lists.infradead.org; Fri, 13 Jan 2023 10:41:14 +0000 Received: from pendragon.ideasonboard.com (85-131-99-81.bb.dnainternet.fi [85.131.99.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB5984D4; Fri, 13 Jan 2023 11:41:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673606467; bh=PJzxvdHtmVgYHpX5Et0D7TMm40oki/fliTJUSOEyrJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hl8P6pbY+7KRnSiWTSczwpDia0pqm3zwpePDcWuUzpwq3pfzgNIr5cmLkzjFkL5+e 6LrK40bBgTPAaNmNZiKLCfWouzXTaxOflKAvH6KRWYU6vvkZjVujZlkdcjjKARylwA SyA/kVNQPhf0yqJKX197Y7KN8bZGG6iwYs+Tzdw4= Date: Fri, 13 Jan 2023 12:41:06 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/16] dt-bindings: media: fsl-pxp: convert to yaml Message-ID: References: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> <20230112-imx-pxp-v2-1-e2281da1db55@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230112-imx-pxp-v2-1-e2281da1db55@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230113_024112_618298_8C059812 X-CRM114-Status: GOOD ( 24.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, Thank you for the patch. On Fri, Jan 13, 2023 at 10:54:07AM +0100, Michael Tretter wrote: > Convert the bindings of the Freescale Pixel Pipeline to YAML. > > The conversion drops the previously listed compatibles for several SoCs. > It is unclear, if the PXP on these SoCs is compatible to any of the PXPs > on the existing SoCs and would allow to reuse the already defined > compatibles. The missing compatibles should be brought back when the > support for the PXP on these SoCs is added. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > Changelog: > > v2: > > - add fsl,imx6sll-pxp and fsl,imx6sx-pxp compatibles > - restrict number of interrupts per variant > - cleanup syntax > --- > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 ++++++++++++++++++++++ > .../devicetree/bindings/media/fsl-pxp.txt | 26 ------- > 2 files changed, 82 insertions(+), 26 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > new file mode 100644 > index 000000000000..c1232689a261 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/fsl,imx6ull-pxp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale Pixel Pipeline > + > +maintainers: > + - Philipp Zabel > + - Michael Tretter > + > +description: > + The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine > + that supports scaling, colorspace conversion, alpha blending, rotation, and > + pixel conversion via lookup table. Different versions are present on various > + i.MX SoCs from i.MX23 to i.MX7. > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx6ul-pxp > + - const: fsl,imx6ull-pxp > + - const: fsl,imx7d-pxp > + - items: > + - enum: > + - fsl,imx6sll-pxp > + - fsl,imx6sx-pxp > + - const: fsl,imx6ull-pxp > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: axi > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-pxp > + then: > + properties: > + interrupts: > + numItems: 1 > + else: > + properties: > + interrupts: > + numItems: 2 > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + pxp: pxp@21cc000 { > + compatible = "fsl,imx6ull-pxp"; > + reg = <0x021cc000 0x4000>; > + interrupts = , > + ; > + clock-names = "axi"; > + clocks = <&clks IMX6UL_CLK_PXP>; > + }; > diff --git a/Documentation/devicetree/bindings/media/fsl-pxp.txt b/Documentation/devicetree/bindings/media/fsl-pxp.txt > deleted file mode 100644 > index f8090e06530d..000000000000 > --- a/Documentation/devicetree/bindings/media/fsl-pxp.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -Freescale Pixel Pipeline > -======================== > - > -The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine > -that supports scaling, colorspace conversion, alpha blending, rotation, and > -pixel conversion via lookup table. Different versions are present on various > -i.MX SoCs from i.MX23 to i.MX7. > - > -Required properties: > -- compatible: should be "fsl,-pxp", where SoC can be one of imx23, imx28, > - imx6dl, imx6sl, imx6sll, imx6ul, imx6sx, imx6ull, or imx7d. > -- reg: the register base and size for the device registers > -- interrupts: the PXP interrupt, two interrupts for imx6ull and imx7d. > -- clock-names: should be "axi" > -- clocks: the PXP AXI clock > - > -Example: > - > -pxp@21cc000 { > - compatible = "fsl,imx6ull-pxp"; > - reg = <0x021cc000 0x4000>; > - interrupts = , > - ; > - clock-names = "axi"; > - clocks = <&clks IMX6UL_CLK_PXP>; > -}; > -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E821C54EBD for ; Fri, 13 Jan 2023 10:44:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241349AbjAMKoV (ORCPT ); Fri, 13 Jan 2023 05:44:21 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42906 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241525AbjAMKns (ORCPT ); Fri, 13 Jan 2023 05:43:48 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C5F8C77AC3; Fri, 13 Jan 2023 02:41:09 -0800 (PST) Received: from pendragon.ideasonboard.com (85-131-99-81.bb.dnainternet.fi [85.131.99.81]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DB5984D4; Fri, 13 Jan 2023 11:41:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673606467; bh=PJzxvdHtmVgYHpX5Et0D7TMm40oki/fliTJUSOEyrJM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hl8P6pbY+7KRnSiWTSczwpDia0pqm3zwpePDcWuUzpwq3pfzgNIr5cmLkzjFkL5+e 6LrK40bBgTPAaNmNZiKLCfWouzXTaxOflKAvH6KRWYU6vvkZjVujZlkdcjjKARylwA SyA/kVNQPhf0yqJKX197Y7KN8bZGG6iwYs+Tzdw4= Date: Fri, 13 Jan 2023 12:41:06 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 01/16] dt-bindings: media: fsl-pxp: convert to yaml Message-ID: References: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> <20230112-imx-pxp-v2-1-e2281da1db55@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230112-imx-pxp-v2-1-e2281da1db55@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, Thank you for the patch. On Fri, Jan 13, 2023 at 10:54:07AM +0100, Michael Tretter wrote: > Convert the bindings of the Freescale Pixel Pipeline to YAML. > > The conversion drops the previously listed compatibles for several SoCs. > It is unclear, if the PXP on these SoCs is compatible to any of the PXPs > on the existing SoCs and would allow to reuse the already defined > compatibles. The missing compatibles should be brought back when the > support for the PXP on these SoCs is added. > > Signed-off-by: Michael Tretter Reviewed-by: Laurent Pinchart > --- > Changelog: > > v2: > > - add fsl,imx6sll-pxp and fsl,imx6sx-pxp compatibles > - restrict number of interrupts per variant > - cleanup syntax > --- > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 ++++++++++++++++++++++ > .../devicetree/bindings/media/fsl-pxp.txt | 26 ------- > 2 files changed, 82 insertions(+), 26 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > new file mode 100644 > index 000000000000..c1232689a261 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl,imx6ull-pxp.yaml > @@ -0,0 +1,82 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > + > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/media/fsl,imx6ull-pxp.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale Pixel Pipeline > + > +maintainers: > + - Philipp Zabel > + - Michael Tretter > + > +description: > + The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine > + that supports scaling, colorspace conversion, alpha blending, rotation, and > + pixel conversion via lookup table. Different versions are present on various > + i.MX SoCs from i.MX23 to i.MX7. > + > +properties: > + compatible: > + oneOf: > + - const: fsl,imx6ul-pxp > + - const: fsl,imx6ull-pxp > + - const: fsl,imx7d-pxp > + - items: > + - enum: > + - fsl,imx6sll-pxp > + - fsl,imx6sx-pxp > + - const: fsl,imx6ull-pxp > + > + reg: > + maxItems: 1 > + > + interrupts: > + minItems: 1 > + maxItems: 2 > + > + clocks: > + maxItems: 1 > + > + clock-names: > + const: axi > + > +required: > + - compatible > + - reg > + - interrupts > + - clocks > + - clock-names > + > +allOf: > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx6sx-pxp > + then: > + properties: > + interrupts: > + numItems: 1 > + else: > + properties: > + interrupts: > + numItems: 2 > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + pxp: pxp@21cc000 { > + compatible = "fsl,imx6ull-pxp"; > + reg = <0x021cc000 0x4000>; > + interrupts = , > + ; > + clock-names = "axi"; > + clocks = <&clks IMX6UL_CLK_PXP>; > + }; > diff --git a/Documentation/devicetree/bindings/media/fsl-pxp.txt b/Documentation/devicetree/bindings/media/fsl-pxp.txt > deleted file mode 100644 > index f8090e06530d..000000000000 > --- a/Documentation/devicetree/bindings/media/fsl-pxp.txt > +++ /dev/null > @@ -1,26 +0,0 @@ > -Freescale Pixel Pipeline > -======================== > - > -The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine > -that supports scaling, colorspace conversion, alpha blending, rotation, and > -pixel conversion via lookup table. Different versions are present on various > -i.MX SoCs from i.MX23 to i.MX7. > - > -Required properties: > -- compatible: should be "fsl,-pxp", where SoC can be one of imx23, imx28, > - imx6dl, imx6sl, imx6sll, imx6ul, imx6sx, imx6ull, or imx7d. > -- reg: the register base and size for the device registers > -- interrupts: the PXP interrupt, two interrupts for imx6ull and imx7d. > -- clock-names: should be "axi" > -- clocks: the PXP AXI clock > - > -Example: > - > -pxp@21cc000 { > - compatible = "fsl,imx6ull-pxp"; > - reg = <0x021cc000 0x4000>; > - interrupts = , > - ; > - clock-names = "axi"; > - clocks = <&clks IMX6UL_CLK_PXP>; > -}; > -- Regards, Laurent Pinchart