From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90B31C3DA78 for ; Sat, 14 Jan 2023 21:29:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229596AbjANV3i (ORCPT ); Sat, 14 Jan 2023 16:29:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53430 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbjANV3h (ORCPT ); Sat, 14 Jan 2023 16:29:37 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 91A767ABE; Sat, 14 Jan 2023 13:29:36 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C17FE4D4; Sat, 14 Jan 2023 22:29:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673731774; bh=8YockS1a/nL6zZeUd8QgQofn11d6xLguAesidUhrRqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SzNC+0QFERQZ9Al7qreW7CaemBjFs9+oJHRu3MSujJgQvSKXZYFpiAjo8N0aIbSR0 avxQCSWkV80c7Lce6csMUu8jUqT3elDZTMWnvTBTbKKUCCgYD9qYX02eRZmtEBQAl+ z1QyonD7r01gveaNak9sTnC3ytWll9N8iqYeKwiU= Date: Sat, 14 Jan 2023 23:29:34 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/16] media: imx-pxp: add support for i.MX7D Message-ID: References: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Michael, The whole series has been reviewed, and only the DT bindings need a small change. If you post a v2.1 of just that patch (--in-reply-to v2 and CC me, or I may not notice quickly), I can take the whole series and get it merged in v6.3. On Fri, Jan 13, 2023 at 10:54:07AM +0100, Michael Tretter wrote: > This is v2 of the series to add support for the PXP found on the i.MX7D to the > imx-pxp driver. > > The PXP on the i.MX7D has a few differences compared to the one on the > i.MX6ULL. Especially, it has more processing blocks and slightly different > multiplexers to route the data between the blocks. Therefore, the driver must > configure a different data path depending on the platform. > > While the PXP has a version register, the reported version is the same on the > i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to > change the driver behavior, but have to use the device tree compatible. The > driver still prints the found version to the log to help bringing up the PXP > on further platforms. > > The patches are inspired by some earlier patches [0] by Laurent to add PXP > support to the i.MX7d. Compared to the earlier patches, these patches add > different behavior depending on the platform. Furthermore, the patches disable > only the LUT block, but keep the rotator block enabled, as it may now be > configured via the V4L2 rotate control. > > In v2, I included Laurent's patch series [1], which was based on this series > anyway and added regmap support. > > Patch 1 converts the dt-binding to yaml. > > Patches 2 to 5 cleanup and refactor the driver in preparation of handling > different PXP versions. > > Patches 6 and 7 add the handling of different platforms and the i.MX7d > specific configuration. > > Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. > > Patches 9 to 15 are the cleanup and enhancement patches to add media > controller support, implement enum_framesizes, and add pxp_read/pxp_write > helpers. > > Patch 16 adds regmap support to the driver. > > Michael > > [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ > [1] https://lore.kernel.org/linux-media/20230112172507.30579-1-laurent.pinchart@ideasonboard.com > > --- > > Changelog > > v2: > > - fix device tree binding > - reduce log level of PXP version to debug > - drop fallback for missing pdata > - add cleanup and enhancement patches to series > - convert driver to regmap > > Signed-off-by: Michael Tretter > To: linux-media@vger.kernel.org > To: devicetree@vger.kernel.org > To: Philipp Zabel > To: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Fabio Estevam > Cc: Alexander Stein > Cc: kernel@pengutronix.de > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: Michael Tretter > > --- > Laurent Pinchart (7): > media: imx-pxp: Sort headers alphabetically > media: imx-pxp: Don't set bus_info manually in .querycap() > media: imx-pxp: Add media controller support > media: imx-pxp: Pass pixel format value to find_format() > media: imx-pxp: Implement frame size enumeration > media: imx-pxp: Introduce pxp_read() and pxp_write() wrappers > media: imx-pxp: Use non-threaded IRQ > > Michael Tretter (9): > dt-bindings: media: fsl-pxp: convert to yaml > media: imx-pxp: detect PXP version > media: imx-pxp: extract helper function to setup data path > media: imx-pxp: explicitly disable unused blocks > media: imx-pxp: disable LUT block > media: imx-pxp: make data_path_ctrl0 platform dependent > media: imx-pxp: add support for i.MX7D > ARM: dts: imx7d: add node for PXP > media: imx-pxp: convert to regmap > > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 +++++ > .../devicetree/bindings/media/fsl-pxp.txt | 26 -- > arch/arm/boot/dts/imx7d.dtsi | 9 + > drivers/media/platform/nxp/imx-pxp.c | 359 +++++++++++++++------ > 4 files changed, 355 insertions(+), 121 deletions(-) > --- > base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 > change-id: 20230112-imx-pxp-073008b3c857 -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D001BC46467 for ; Sat, 14 Jan 2023 21:31:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uYHqyZVY8EpldoQC6c50qEJ9zDlmtv83GnEyk5z9mmU=; b=Ff/SxUwaOqj/aN lyicAlTFfbnhO5H9TNgOd2aAV3lfG3ZqgijKP5mkDflA+uDjRvi8yKAEuSSCYO5Wg5k/LeJPyFm2N 3pE44G4iiNvDsxMq8j/1Adfw3JSx6fxU2CskeGzLxdAdINL7hDGESfm9eJ+WuXkMlqpv4j8MsS4lr 1UoNTLip86e/P3wAVxq2lAty3oK1TPp1GC5VYSHIrdIiTu3MMS16zIoyv3fAhKXqdxooO7wAxA5Rp uAngP7nkYG9UTWNsLOqqJBGzAPsKkyy2VO8ZChsLDAE71oKc+MM5/BVtBxJgm1ndBidU9gYMlFtAF KEHc3ql74QpmvPilEPtg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGo60-006U2u-UR; Sat, 14 Jan 2023 21:29:49 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pGo5u-006U1x-Kv for linux-arm-kernel@lists.infradead.org; Sat, 14 Jan 2023 21:29:44 +0000 Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C17FE4D4; Sat, 14 Jan 2023 22:29:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1673731774; bh=8YockS1a/nL6zZeUd8QgQofn11d6xLguAesidUhrRqw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SzNC+0QFERQZ9Al7qreW7CaemBjFs9+oJHRu3MSujJgQvSKXZYFpiAjo8N0aIbSR0 avxQCSWkV80c7Lce6csMUu8jUqT3elDZTMWnvTBTbKKUCCgYD9qYX02eRZmtEBQAl+ z1QyonD7r01gveaNak9sTnC3ytWll9N8iqYeKwiU= Date: Sat, 14 Jan 2023 23:29:34 +0200 From: Laurent Pinchart To: Michael Tretter Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , Alexander Stein , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 00/16] media: imx-pxp: add support for i.MX7D Message-ID: References: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230112-imx-pxp-v2-0-e2281da1db55@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230114_132942_856101_F338C13E X-CRM114-Status: GOOD ( 34.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Michael, The whole series has been reviewed, and only the DT bindings need a small change. If you post a v2.1 of just that patch (--in-reply-to v2 and CC me, or I may not notice quickly), I can take the whole series and get it merged in v6.3. On Fri, Jan 13, 2023 at 10:54:07AM +0100, Michael Tretter wrote: > This is v2 of the series to add support for the PXP found on the i.MX7D to the > imx-pxp driver. > > The PXP on the i.MX7D has a few differences compared to the one on the > i.MX6ULL. Especially, it has more processing blocks and slightly different > multiplexers to route the data between the blocks. Therefore, the driver must > configure a different data path depending on the platform. > > While the PXP has a version register, the reported version is the same on the > i.MX6ULL and the i.MX7D. Therefore, we cannot use the version register to > change the driver behavior, but have to use the device tree compatible. The > driver still prints the found version to the log to help bringing up the PXP > on further platforms. > > The patches are inspired by some earlier patches [0] by Laurent to add PXP > support to the i.MX7d. Compared to the earlier patches, these patches add > different behavior depending on the platform. Furthermore, the patches disable > only the LUT block, but keep the rotator block enabled, as it may now be > configured via the V4L2 rotate control. > > In v2, I included Laurent's patch series [1], which was based on this series > anyway and added regmap support. > > Patch 1 converts the dt-binding to yaml. > > Patches 2 to 5 cleanup and refactor the driver in preparation of handling > different PXP versions. > > Patches 6 and 7 add the handling of different platforms and the i.MX7d > specific configuration. > > Patch 8 adds the device tree node for the PXP to the i.MX7d device tree. > > Patches 9 to 15 are the cleanup and enhancement patches to add media > controller support, implement enum_framesizes, and add pxp_read/pxp_write > helpers. > > Patch 16 adds regmap support to the driver. > > Michael > > [0] https://lore.kernel.org/linux-media/20200510223100.11641-1-laurent.pinchart@ideasonboard.com/ > [1] https://lore.kernel.org/linux-media/20230112172507.30579-1-laurent.pinchart@ideasonboard.com > > --- > > Changelog > > v2: > > - fix device tree binding > - reduce log level of PXP version to debug > - drop fallback for missing pdata > - add cleanup and enhancement patches to series > - convert driver to regmap > > Signed-off-by: Michael Tretter > To: linux-media@vger.kernel.org > To: devicetree@vger.kernel.org > To: Philipp Zabel > To: Laurent Pinchart > Cc: Mauro Carvalho Chehab > Cc: Rob Herring > Cc: Krzysztof Kozlowski > Cc: Fabio Estevam > Cc: Alexander Stein > Cc: kernel@pengutronix.de > Cc: linux-imx@nxp.com > Cc: linux-arm-kernel@lists.infradead.org > Cc: Michael Tretter > > --- > Laurent Pinchart (7): > media: imx-pxp: Sort headers alphabetically > media: imx-pxp: Don't set bus_info manually in .querycap() > media: imx-pxp: Add media controller support > media: imx-pxp: Pass pixel format value to find_format() > media: imx-pxp: Implement frame size enumeration > media: imx-pxp: Introduce pxp_read() and pxp_write() wrappers > media: imx-pxp: Use non-threaded IRQ > > Michael Tretter (9): > dt-bindings: media: fsl-pxp: convert to yaml > media: imx-pxp: detect PXP version > media: imx-pxp: extract helper function to setup data path > media: imx-pxp: explicitly disable unused blocks > media: imx-pxp: disable LUT block > media: imx-pxp: make data_path_ctrl0 platform dependent > media: imx-pxp: add support for i.MX7D > ARM: dts: imx7d: add node for PXP > media: imx-pxp: convert to regmap > > .../devicetree/bindings/media/fsl,imx6ull-pxp.yaml | 82 +++++ > .../devicetree/bindings/media/fsl-pxp.txt | 26 -- > arch/arm/boot/dts/imx7d.dtsi | 9 + > drivers/media/platform/nxp/imx-pxp.c | 359 +++++++++++++++------ > 4 files changed, 355 insertions(+), 121 deletions(-) > --- > base-commit: b7bfaa761d760e72a969d116517eaa12e404c262 > change-id: 20230112-imx-pxp-073008b3c857 -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel