From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2CBFC54EBE for ; Mon, 16 Jan 2023 13:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231402AbjAPNr5 (ORCPT ); Mon, 16 Jan 2023 08:47:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231165AbjAPNrw (ORCPT ); Mon, 16 Jan 2023 08:47:52 -0500 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B7F261F939; Mon, 16 Jan 2023 05:47:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0HTUfVc3oaZYPyu8hVJiRYYIklNVSq9G9JrqltNQOXM=; b=RP2SFlEOO71CljwuB1Qv7OjmU2 IJYZFTHcIFP1VVxWt3NSd+fslR/AUTg+OtdKfy7ldH9E8mYWmFSrGOTR1K+1HHyDT8wY3PEXc31+E FtNkSzJtizDqPyB/RCTOite3k+4UYyQnJESYwx71VBYd7B+QJWwxc8JCNeqh9ip8luwR5xEhF1lGD IPUFoKIuBHFIKA0gGGSgAt1/A9kj0GHYxwZ2s+wXxWF//5X/5Q8dvFmkWgZUoEJqQxtLDxHpobXn8 09t8pWFNJEjsd8ytxoGBBrUeOW996pQ7PHQkvFJBprOWWDhKj5+GZ16hzsRM9u8a43jlqIXTyzLVo StJ17BKA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36128) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pHPph-00051t-EG; Mon, 16 Jan 2023 13:47:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pHPpb-00063u-18; Mon, 16 Jan 2023 13:47:23 +0000 Date: Mon, 16 Jan 2023 13:47:23 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Frank Wunderlich , Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <87o7qy39v5.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o7qy39v5.fsf@miraculix.mork.no> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 16, 2023 at 02:08:30PM +0100, Bjørn Mork wrote: > Frank Wunderlich writes: > > > apart from this little problem it works much better than it actually is so imho more > > people should test it on different platforms. > > Hello! I've been banging my head against an MT7986 board with two > Maxlinear GPY211C phys for a while. One of those phys is connected to > port 5 of the MT7531 switch. This is working perfectly. > > The other GPY211C is connected to the second MT7986 mac. This one is > giving me a headache... > > I can only get the port to work at 2500Mb/s. Changing the speed to > anything lower looks fine in ethtool etc, but traffic is blocked. My guess would be that the GPY PHY is using in-band SGMII negotiation (it sets VSPEC1_SGMII_ANEN_ANRS when entering SGMII mode and clears it in 2500base-X), but as the link is not using in-band mode on the PCS side, the PHY never sees its in-band negotiation complete, so the link between PCS and PHY never comes up. Both sides need to agree on that detail. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9C432C46467 for ; Mon, 16 Jan 2023 13:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=0HTUfVc3oaZYPyu8hVJiRYYIklNVSq9G9JrqltNQOXM=; b=nWHRuuKW7riP0uqJ5L1ZqF9lKV uDqXj7huFqKobO7Y3anC4G2DsVWpqaKZaOliv+8KEzNPtNhXBUWV2NuY6RjxZrwePfmM7Z+oteDts VPoiXqZ5MfQwBmel9ZNZCiMlHFcRDJpEtD1mc89FwhPoGLw4ESGt4gxU5xONhy+z08pcni24IdwJA oque2gRMP6mLLMul2O9/9DBl+1X/tktlzcPURuDc+DmNzGM5sZUQTDYEjK2UhwpEP+O64MFheOfMz naWSTmJtpvBllSy5qL2cwpdM7jL8WZoq0rSrUKdVNVI8Jar8a8q362zPmk/biJIGM1ViWuYDXizYT JB3BvWlg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPpx-00AZa4-1i; Mon, 16 Jan 2023 13:47:45 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPps-00AZTf-Ar; Mon, 16 Jan 2023 13:47:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0HTUfVc3oaZYPyu8hVJiRYYIklNVSq9G9JrqltNQOXM=; b=RP2SFlEOO71CljwuB1Qv7OjmU2 IJYZFTHcIFP1VVxWt3NSd+fslR/AUTg+OtdKfy7ldH9E8mYWmFSrGOTR1K+1HHyDT8wY3PEXc31+E FtNkSzJtizDqPyB/RCTOite3k+4UYyQnJESYwx71VBYd7B+QJWwxc8JCNeqh9ip8luwR5xEhF1lGD IPUFoKIuBHFIKA0gGGSgAt1/A9kj0GHYxwZ2s+wXxWF//5X/5Q8dvFmkWgZUoEJqQxtLDxHpobXn8 09t8pWFNJEjsd8ytxoGBBrUeOW996pQ7PHQkvFJBprOWWDhKj5+GZ16hzsRM9u8a43jlqIXTyzLVo StJ17BKA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36128) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pHPph-00051t-EG; Mon, 16 Jan 2023 13:47:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pHPpb-00063u-18; Mon, 16 Jan 2023 13:47:23 +0000 Date: Mon, 16 Jan 2023 13:47:23 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <87o7qy39v5.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87o7qy39v5.fsf@miraculix.mork.no> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_054740_410145_9D55B48A X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: netdev@vger.kernel.org, Sean Wang , linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Eric Dumazet , Alexander Couzens , John Crispin , Matthias Brugger , linux-mediatek@lists.infradead.org, Frank Wunderlich , Paolo Abeni , Mark Lee , linux-arm-kernel@lists.infradead.org, Felix Fietkau Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 02:08:30PM +0100, Bjørn Mork wrote: > Frank Wunderlich writes: > > > apart from this little problem it works much better than it actually is so imho more > > people should test it on different platforms. > > Hello! I've been banging my head against an MT7986 board with two > Maxlinear GPY211C phys for a while. One of those phys is connected to > port 5 of the MT7531 switch. This is working perfectly. > > The other GPY211C is connected to the second MT7986 mac. This one is > giving me a headache... > > I can only get the port to work at 2500Mb/s. Changing the speed to > anything lower looks fine in ethtool etc, but traffic is blocked. My guess would be that the GPY PHY is using in-band SGMII negotiation (it sets VSPEC1_SGMII_ANEN_ANRS when entering SGMII mode and clears it in 2500base-X), but as the link is not using in-band mode on the PCS side, the PHY never sees its in-band negotiation complete, so the link between PCS and PHY never comes up. Both sides need to agree on that detail. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2C827C46467 for ; Mon, 16 Jan 2023 13:49:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FW8nLINH58XQaDaJ4VsFKNTp9OziRMvftW44MyqMpIo=; b=NrDdgSUdO9JULl ajTkCHaot7n1b3UkmrOTOPuJf7IhBo3AV1cc7ecKddNWubniw1jjCxtw0XJx7Q4Oid74L6CTw/U56 Y2WmAixalm903RZFU3K96dTV+ccxw+fLjqgrRIYKgcEW8rjuJyTwtDwkiICbxSxoPdTOTsyxf+BWp 8t1FIdHzBZETkP0ZfGS9Nsg3epjw9suaBIQ8zAYWlvEe5+xjLmv58FD1pPaIw3rKzBxo7MkD2FLCz a73QYtbouIupKqOgIXc7MZv52rdMKrZhdIwMl8wyIKDQEer9XLKh7bQxU5lgaBEzNjtoxFjitPxHl 1auUwP+R7fC4Eb2W4xzg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPq9-00AZe7-Pc; Mon, 16 Jan 2023 13:47:59 +0000 Received: from pandora.armlinux.org.uk ([2001:4d48:ad52:32c8:5054:ff:fe00:142]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHPps-00AZTf-Ar; Mon, 16 Jan 2023 13:47:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To: Content-Transfer-Encoding:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=0HTUfVc3oaZYPyu8hVJiRYYIklNVSq9G9JrqltNQOXM=; b=RP2SFlEOO71CljwuB1Qv7OjmU2 IJYZFTHcIFP1VVxWt3NSd+fslR/AUTg+OtdKfy7ldH9E8mYWmFSrGOTR1K+1HHyDT8wY3PEXc31+E FtNkSzJtizDqPyB/RCTOite3k+4UYyQnJESYwx71VBYd7B+QJWwxc8JCNeqh9ip8luwR5xEhF1lGD IPUFoKIuBHFIKA0gGGSgAt1/A9kj0GHYxwZ2s+wXxWF//5X/5Q8dvFmkWgZUoEJqQxtLDxHpobXn8 09t8pWFNJEjsd8ytxoGBBrUeOW996pQ7PHQkvFJBprOWWDhKj5+GZ16hzsRM9u8a43jlqIXTyzLVo StJ17BKA==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:36128) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pHPph-00051t-EG; Mon, 16 Jan 2023 13:47:29 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1pHPpb-00063u-18; Mon, 16 Jan 2023 13:47:23 +0000 Date: Mon, 16 Jan 2023 13:47:23 +0000 From: "Russell King (Oracle)" To: =?iso-8859-1?Q?Bj=F8rn?= Mork Cc: Frank Wunderlich , Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <87o7qy39v5.fsf@miraculix.mork.no> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87o7qy39v5.fsf@miraculix.mork.no> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_054740_410145_9D55B48A X-CRM114-Status: GOOD ( 15.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 16, 2023 at 02:08:30PM +0100, Bj=F8rn Mork wrote: > Frank Wunderlich writes: > = > > apart from this little problem it works much better than it actually is= so imho more > > people should test it on different platforms. > = > Hello! I've been banging my head against an MT7986 board with two > Maxlinear GPY211C phys for a while. One of those phys is connected to > port 5 of the MT7531 switch. This is working perfectly. > = > The other GPY211C is connected to the second MT7986 mac. This one is > giving me a headache... > = > I can only get the port to work at 2500Mb/s. Changing the speed to > anything lower looks fine in ethtool etc, but traffic is blocked. My guess would be that the GPY PHY is using in-band SGMII negotiation (it sets VSPEC1_SGMII_ANEN_ANRS when entering SGMII mode and clears it in 2500base-X), but as the link is not using in-band mode on the PCS side, the PHY never sees its in-band negotiation complete, so the link between PCS and PHY never comes up. Both sides need to agree on that detail. -- = RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel