All of lore.kernel.org
 help / color / mirror / Atom feed
From: Francesco Dolcini <francesco@dolcini.it>
To: Marek Vasut <marex@denx.de>
Cc: Francesco Dolcini <francesco@dolcini.it>,
	Simon Glass <sjg@chromium.org>,
	u-boot@lists.denx.de,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Miquel Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH v1 2/3] colibri-imx7: specify MTD partitions on command line
Date: Mon, 16 Jan 2023 14:58:28 +0100	[thread overview]
Message-ID: <Y8VYBCOBkZt4uapB@francesco-nb.int.toradex.com> (raw)
In-Reply-To: <fcf6f125-ba63-14f5-f6d5-6a5bd6f5ba1f@denx.de>

On Sun, Jan 15, 2023 at 03:33:25PM +0100, Marek Vasut wrote:
> On 1/13/23 19:45, Francesco Dolcini wrote:
> > From: Francesco Dolcini <francesco.dolcini@toradex.com>
> > 
> > Disable fdt_fixup_mtdparts(), instead pass MTD partition on the command
> > line. This is the preferred method to be used when partitions are not
> > statically defined into the DTS according the Linux MTD subsystem
> > maintainer.
> 
> Do we really want to do this ?
> I thought passing the mtdparts via DT is the preferred way ?

Yes, to me it seems like the most robust approach to minimize chances
of regressions and boot issues.

With the current dts schema, that expects the partitions to not be
direct children of the nand controller node, but expecting having a
nand-chip, and partitions as a child of the nand-chip this is the most
likely approach to just works.

For example if I add a partition node to my DTS, older U-Boot will just
ignore it and add the partitions as children of the nand controller.
In this case the current parser will just fails leading to another
flavor of boot failure on our board.

In reality I cannot really tell which u-boot/kernel combination is going
to be used on our SOMs.

Said that, what would be the disadvantages of having the partitions on
the command line? Miquel?

Francesco


  reply	other threads:[~2023-01-16 13:58 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 18:45 [PATCH v1 0/3] fdt: Fix mtparts fixup Francesco Dolcini
2023-01-13 18:45 ` Francesco Dolcini
2023-01-13 18:45 ` [PATCH v1 1/3] fdt: validate/fix cells count on mtdpart fixup Francesco Dolcini
2023-01-13 18:45   ` Francesco Dolcini
2023-01-15 14:35   ` Marek Vasut
2023-01-15 14:35     ` Marek Vasut
2023-01-16 14:20     ` Francesco Dolcini
2023-01-16 14:20       ` Francesco Dolcini
2023-01-16 17:54       ` Marek Vasut
2023-01-16 17:54         ` Marek Vasut
2023-01-16 18:00         ` Francesco Dolcini
2023-01-16 18:00           ` Francesco Dolcini
2023-01-17  0:59           ` Marek Vasut
2023-01-17  0:59             ` Marek Vasut
2023-01-23  9:56             ` Miquel Raynal
2023-01-23  9:56               ` Miquel Raynal
2023-01-24  8:41               ` Francesco Dolcini
2023-01-24  8:41                 ` Francesco Dolcini
2023-01-24  8:58                 ` Miquel Raynal
2023-01-24  8:58                   ` Miquel Raynal
2023-01-24 10:24                   ` Francesco Dolcini
2023-01-24 10:24                     ` Francesco Dolcini
2023-01-13 18:45 ` [PATCH v1 2/3] colibri-imx7: specify MTD partitions on command line Francesco Dolcini
2023-01-15 14:33   ` Marek Vasut
2023-01-16 13:58     ` Francesco Dolcini [this message]
2023-01-23  9:58       ` Miquel Raynal
2023-01-13 18:45 ` [PATCH v1 3/3] colibri-imx6ull: " Francesco Dolcini
2023-01-13 19:34 ` [PATCH v1 0/3] fdt: Fix mtparts fixup Tom Rini
2023-01-13 19:34   ` Tom Rini
2023-01-23 10:06   ` Miquel Raynal
2023-01-23 10:06     ` Miquel Raynal
2023-01-23 20:01     ` Tom Rini
2023-01-23 20:01       ` Tom Rini
2023-02-23 10:23       ` Patrick DELAUNAY
2023-02-23 10:23         ` Patrick DELAUNAY
2023-02-23 22:35         ` Tom Rini
2023-02-23 22:35           ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8VYBCOBkZt4uapB@francesco-nb.int.toradex.com \
    --to=francesco@dolcini.it \
    --cc=francesco.dolcini@toradex.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=marex@denx.de \
    --cc=miquel.raynal@bootlin.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.