From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E99B7C54EBE for ; Mon, 16 Jan 2023 14:30:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rDqe1+4vulBPhcUqQGm3AHyG/Q+wektLn5ZQdFx5DRI=; b=ozQFpYay3uVWOu HYeu6KmgYhvNlTKQqvdn2fsSz1Ca1qvR9qYMVp0KOfrpdHGrSGrTl4lhe3MZc2Ph1W+fT3UWc2fit T6Nn9xdel97xMR+xJVAbXXJ0WweO+ZooAihiiV1DuCJuK/S8qjoQ8GPAyy2iTQa1/VxnfMtph5Cxd jtYMnmMvNLdV5pX2X3FQTulmWRpQXLCnarwVkLjTE9wBrcotSGsVfpJcKV6Gp9BTKcOWirly2ZqoM UYs7U3dZLqMuuGzW4ESFIQ5/jj1o5iVBrYLt5yqWbjdVrTnXQ7gB2uuAmuSsy3CtZaLm5Ja/JG5UP I9fpnSg2cXvQ2Ljg8C3g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHQTk-00Au4K-KS; Mon, 16 Jan 2023 14:28:53 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pHQTY-00Au0n-5f for linux-arm-kernel@lists.infradead.org; Mon, 16 Jan 2023 14:28:41 +0000 Received: by mail-ej1-x62b.google.com with SMTP id vw16so5361835ejc.12 for ; Mon, 16 Jan 2023 06:28:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VxLG6TTl8Ic/7g0hQk8ggT8NcHPanULLyMvVruCtN2c=; b=QGlGugyS3UvUwNLlIz8UrjuOagHJQAqHFl0b7LiY3pjSEWd3QV1zO3d7SD+ZdOrza/ x5G601a1q2QAghOuPl7OdIp9uPmU80fKtCLExlG0gqWjm6fUeq7GSy9iQGAcg40I4EQD uBAIPv9fIr6E02fF+8KfST95igZxAubbSqvFiLGzsFV1t2wHawhuQyiS4tuxLUNCZVcm IiZ/evYO0C57J+AqkIVIgcTDq3eESoliRyBmTsdEnB5TzNDp3BBNwGSSAMLmo2niFZ2R BjVB1PJEfyiH2hs5yn26f08V0UfgPzYpxG7tmnn7c0kQrvek5qNl7gTTU6p4wQQlV5rJ QJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VxLG6TTl8Ic/7g0hQk8ggT8NcHPanULLyMvVruCtN2c=; b=0QlJXbxDsTPjhn4SLk1HXJ61s2rN55sKLSC5P7JljNYOhvbPzIhrJVVNLF1j16YtP1 CC+6FUo7Ys29wpaevdbk5jdsKMw6q5eChsMhirfB6/E9IH1gO99Es8D0C9cA9w8bR5/A MEIZRcPItzNSyjJug9ZrAIvcmv1dNyXSoizGnM97NPoEwRQH6rfIgjlQ1JvCEcRFAEI3 72+I5ERPUiUS9xf+R9IQE352ifXhbLKUstvfAutLcmo/5Z8yWuW41728Jkx2hS+GORrO BjXnjOY1AXsA3FbIrgugPuiRVcBGvq/ssTHXJWHWlSblQzgEGnQqVESvu0heDXRcAhwS tjfg== X-Gm-Message-State: AFqh2kphPRhxS5wX3uMMJVdhTW74MJC/tQyRxDsEU5vofUvWnZETUTtU OFVZwTjqAnGAwxmU64F/0hGQCQ== X-Google-Smtp-Source: AMrXdXvhKj+dWSAovh86aIL0ls/STdzn8oZMPR+FmLegGDzAEOO/UU2HiZ10lUEtT+U1aacM+pz0zw== X-Received: by 2002:a17:906:5786:b0:7c0:e535:13fc with SMTP id k6-20020a170906578600b007c0e53513fcmr100863185ejq.37.1673879315637; Mon, 16 Jan 2023 06:28:35 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id lb14-20020a170907784e00b007c0fd177c0bsm11753152ejc.46.2023.01.16.06.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:28:35 -0800 (PST) Date: Mon, 16 Jan 2023 16:28:33 +0200 From: Abel Vesa To: Stephen Boyd Cc: LI Qingwu , abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 18701859600@163.com, bsp-development.geo@leica-geosystems.com, Marco Felsch Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE Message-ID: References: <20230111101030.686885-1-Qing-wu.Li@leica-geosystems.com.cn> <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230116_062840_257992_773F999C X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23-01-11 11:10:30, LI Qingwu wrote: > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h > but never assigned. It will cause the system to hang if using them. > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE > for backward compatibility. > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) > Reviewed-by: Marco Felsch > Reviewed-by: Abel Vesa > Signed-off-by: LI Qingwu Stephen, can you please pick this up yourself? Thanks! > --- > drivers/clk/imx/clk-imx8mp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 652ae58c2735..601eea7ab99d 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -522,6 +522,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_A53_SRC] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_A53_CG] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_M7_CORE] = imx8m_clk_hw_composite_core("m7_core", imx8mp_m7_sels, ccm_base + 0x8080); > + hws[IMX8MP_CLK_M7_DIV] = hws[IMX8MP_CLK_M7_CORE]; > + hws[IMX8MP_CLK_M7_SRC] = hws[IMX8MP_CLK_M7_CORE]; > hws[IMX8MP_CLK_ML_CORE] = imx8m_clk_hw_composite_core("ml_core", imx8mp_ml_sels, ccm_base + 0x8100); > hws[IMX8MP_CLK_GPU3D_CORE] = imx8m_clk_hw_composite_core("gpu3d_core", imx8mp_gpu3d_core_sels, ccm_base + 0x8180); > hws[IMX8MP_CLK_GPU3D_SHADER_CORE] = imx8m_clk_hw_composite("gpu3d_shader_core", imx8mp_gpu3d_shader_sels, ccm_base + 0x8200); > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2FDCC46467 for ; Mon, 16 Jan 2023 14:47:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231793AbjAPOrM (ORCPT ); Mon, 16 Jan 2023 09:47:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230072AbjAPOqx (ORCPT ); Mon, 16 Jan 2023 09:46:53 -0500 Received: from mail-ej1-x634.google.com (mail-ej1-x634.google.com [IPv6:2a00:1450:4864:20::634]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19ADE22A23 for ; Mon, 16 Jan 2023 06:28:37 -0800 (PST) Received: by mail-ej1-x634.google.com with SMTP id hw16so56647876ejc.10 for ; Mon, 16 Jan 2023 06:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VxLG6TTl8Ic/7g0hQk8ggT8NcHPanULLyMvVruCtN2c=; b=QGlGugyS3UvUwNLlIz8UrjuOagHJQAqHFl0b7LiY3pjSEWd3QV1zO3d7SD+ZdOrza/ x5G601a1q2QAghOuPl7OdIp9uPmU80fKtCLExlG0gqWjm6fUeq7GSy9iQGAcg40I4EQD uBAIPv9fIr6E02fF+8KfST95igZxAubbSqvFiLGzsFV1t2wHawhuQyiS4tuxLUNCZVcm IiZ/evYO0C57J+AqkIVIgcTDq3eESoliRyBmTsdEnB5TzNDp3BBNwGSSAMLmo2niFZ2R BjVB1PJEfyiH2hs5yn26f08V0UfgPzYpxG7tmnn7c0kQrvek5qNl7gTTU6p4wQQlV5rJ QJEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VxLG6TTl8Ic/7g0hQk8ggT8NcHPanULLyMvVruCtN2c=; b=j+Mu7d7agyGNH20k+fr6/BlGeAmCoobrKpJyefy3XJbk2YEqnwa2tPllrUfmtHS6EH 7EzmY0Xw/1N9JyWnhsMC3hhPi8+odouxSunuCPMLgJSVWWzE6mXJMxiDYdEPuTzRO4fP AXzmNxCuaXIAiIXO+SDxnVGxddxv7WFkbQUA0/JUmoTCPNcpfZG8rfI8RzO01x2tJ9lr tUSnfED1dub1n8qQ8Ug0JndoB5HdB8/uo2CBSKMv1ACgzrP0BKRCVGw+zM1ZQCNl7bG7 66psjqG0f6s0efuBXvzvN70fuGVJt5MUmU0fa/W3gdfovxQ/azfuUEuRBkF1JqiCFaCz TGAw== X-Gm-Message-State: AFqh2kqh2lK+eaf7qjbSqQHEtCVzh7Dhd4okkDSHPSNHeQcUYu+XHmuT N9NpAFiOb+Vg1UAYow637xxAHA== X-Google-Smtp-Source: AMrXdXvhKj+dWSAovh86aIL0ls/STdzn8oZMPR+FmLegGDzAEOO/UU2HiZ10lUEtT+U1aacM+pz0zw== X-Received: by 2002:a17:906:5786:b0:7c0:e535:13fc with SMTP id k6-20020a170906578600b007c0e53513fcmr100863185ejq.37.1673879315637; Mon, 16 Jan 2023 06:28:35 -0800 (PST) Received: from linaro.org ([94.52.112.99]) by smtp.gmail.com with ESMTPSA id lb14-20020a170907784e00b007c0fd177c0bsm11753152ejc.46.2023.01.16.06.28.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:28:35 -0800 (PST) Date: Mon, 16 Jan 2023 16:28:33 +0200 From: Abel Vesa To: Stephen Boyd Cc: LI Qingwu , abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 18701859600@163.com, bsp-development.geo@leica-geosystems.com, Marco Felsch Subject: Re: [PATCH V5 1/1] clk: imx8mp: Alias M7 SRC/DIV to M7 CORE Message-ID: References: <20230111101030.686885-1-Qing-wu.Li@leica-geosystems.com.cn> <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230111101030.686885-2-Qing-wu.Li@leica-geosystems.com.cn> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23-01-11 11:10:30, LI Qingwu wrote: > Defined IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV in imx8mp-clock.h > but never assigned. It will cause the system to hang if using them. > Alias IMX8MP_CLK_M7_SRC and IMX8MP_CLK_M7_DIV to IMX8MP_CLK_M7_CORE > for backward compatibility. > > Fixes: 8c83a8ff4dd9 (clk: imx8mp: use imx8m_clk_hw_composite_core to simplify code) > Reviewed-by: Marco Felsch > Reviewed-by: Abel Vesa > Signed-off-by: LI Qingwu Stephen, can you please pick this up yourself? Thanks! > --- > drivers/clk/imx/clk-imx8mp.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/clk/imx/clk-imx8mp.c b/drivers/clk/imx/clk-imx8mp.c > index 652ae58c2735..601eea7ab99d 100644 > --- a/drivers/clk/imx/clk-imx8mp.c > +++ b/drivers/clk/imx/clk-imx8mp.c > @@ -522,6 +522,8 @@ static int imx8mp_clocks_probe(struct platform_device *pdev) > hws[IMX8MP_CLK_A53_SRC] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_A53_CG] = hws[IMX8MP_CLK_A53_DIV]; > hws[IMX8MP_CLK_M7_CORE] = imx8m_clk_hw_composite_core("m7_core", imx8mp_m7_sels, ccm_base + 0x8080); > + hws[IMX8MP_CLK_M7_DIV] = hws[IMX8MP_CLK_M7_CORE]; > + hws[IMX8MP_CLK_M7_SRC] = hws[IMX8MP_CLK_M7_CORE]; > hws[IMX8MP_CLK_ML_CORE] = imx8m_clk_hw_composite_core("ml_core", imx8mp_ml_sels, ccm_base + 0x8100); > hws[IMX8MP_CLK_GPU3D_CORE] = imx8m_clk_hw_composite_core("gpu3d_core", imx8mp_gpu3d_core_sels, ccm_base + 0x8180); > hws[IMX8MP_CLK_GPU3D_SHADER_CORE] = imx8m_clk_hw_composite("gpu3d_shader_core", imx8mp_gpu3d_shader_sels, ccm_base + 0x8200); > -- > 2.25.1 >