All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Andy Gross <agross@kernel.org>,
	abel.vesa@linaro.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	devicetree@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH v2 0/2] arm64: dts: qcom: sm8550: Add PCIe HC and PHY support
Date: Thu, 19 Jan 2023 08:33:20 +0100	[thread overview]
Message-ID: <Y8jyQAR7fF1NRmwu@hovoldconsulting.com> (raw)
In-Reply-To: <167408614065.2989059.2950818972854332656.b4-ty@kernel.org>

On Wed, Jan 18, 2023 at 05:55:31PM -0600, Bjorn Andersson wrote:
> On Thu, 19 Jan 2023 01:05:24 +0200, Abel Vesa wrote:
> > This patchset adds PCIe controllers and PHYs support to SM8550 platform
> > and enables them on the MTP board.
> > 
> > The v1 was here:
> > https://lore.kernel.org/all/20221116130430.2812173-1-abel.vesa@linaro.org/
> > 
> > Changes since v1:
> >  * ordered pcie related nodes alphabetically in MTP dts
> >  * dropped the pipe_mux, phy_pipe and ref clocks from the pcie nodes
> >  * dropped the child node from the phy nodes, like Johan suggested,
> >    and updated to use the sc8280xp binding scheme
> >  * changed "pcie_1_nocsr_com_phy_reset" 2nd reset name of pcie1_phy
> >    to "nocsr"
> >  * reordered all pcie nodes properties to look similar to the ones
> >    from sc8280xp
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/2] arm64: dts: qcom: sm8550: Add PCIe PHYs and controllers nodes
>       commit: 7d1158c984d37e79ab8bb55ab152a0b35566cb89
> [2/2] arm64: dts: qcom: sm8550-mtp: Add PCIe PHYs and controllers nodes
>       commit: 1eeef306b5d80494cdb149f058013c3ab43984b4

I believe there were still some changes needed to the controller
and PHY bindings so this should not have been merged.

	https://lore.kernel.org/all/Y8fuUI4xaNkADkWl@hovoldconsulting.com/
	https://lore.kernel.org/lkml/Y8giHJMtPu4wTlmA@hovoldconsulting.com/

Perhaps in the future you can send the dts changes along with the (PHY)
driver changes so that they can be kept in lock-step and avoid this.

Johan

  reply	other threads:[~2023-01-19  7:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-18 23:05 [PATCH v2 0/2] arm64: dts: qcom: sm8550: Add PCIe HC and PHY support Abel Vesa
2023-01-18 23:05 ` [PATCH v2 1/2] arm64: dts: qcom: sm8550: Add PCIe PHYs and controllers nodes Abel Vesa
2023-01-18 23:05 ` [PATCH v2 2/2] arm64: dts: qcom: sm8550-mtp: " Abel Vesa
2023-01-18 23:55 ` [PATCH v2 0/2] arm64: dts: qcom: sm8550: Add PCIe HC and PHY support Bjorn Andersson
2023-01-19  7:33   ` Johan Hovold [this message]
2023-01-19 12:09     ` Abel Vesa
2023-01-19 12:29       ` Krzysztof Kozlowski
2023-01-19 12:50         ` Abel Vesa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y8jyQAR7fF1NRmwu@hovoldconsulting.com \
    --to=johan@kernel.org \
    --cc=abel.vesa@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.