From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 88BBDC00A5A for ; Thu, 19 Jan 2023 13:01:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pIUWn-0000ZZ-LU; Thu, 19 Jan 2023 08:00:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIUWj-0000YL-Rq for qemu-devel@nongnu.org; Thu, 19 Jan 2023 08:00:22 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pIUWh-0003BX-Mg for qemu-devel@nongnu.org; Thu, 19 Jan 2023 08:00:21 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1674133218; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zwwNL5zn8vvXomLDLi6XD5qYYx7MgjF6CLpGfz8AfM8=; b=CA3eaEF8GmmbLEPxFM3QOrLBzY6WkWEWPZopJvjb3DGF/U0PnDqeubTKRtvUv5enK3H6Ve xrZeYquh/BQ/6/L/gz0eWEmKpRFdtTi8Fi9Qq7N/89vXCQZdJJ12HX8jt/zkvJ0VaWei7w z6QLkzg13XSyDA+QBsdpkwhFKx6PpjQ= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-644-K-4gzRc3NUSUkIbROsf6Bw-1; Thu, 19 Jan 2023 08:00:13 -0500 X-MC-Unique: K-4gzRc3NUSUkIbROsf6Bw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 86D2C2A5956E; Thu, 19 Jan 2023 13:00:12 +0000 (UTC) Received: from redhat.com (unknown [10.39.194.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id DD57D40C6EC4; Thu, 19 Jan 2023 13:00:10 +0000 (UTC) Date: Thu, 19 Jan 2023 14:00:09 +0100 From: Kevin Wolf To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: qemu-devel@nongnu.org, Eric Blake , qemu-block@nongnu.org, Vladimir Sementsov-Ogievskiy , qemu-trivial@nongnu.org, Hanna Reitz Subject: Re: [PATCH-for-8.0] block/nbd: Add missing include Message-ID: References: <20221125175328.48539-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221125175328.48539-1-philmd@linaro.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Received-SPF: pass client-ip=170.10.133.124; envelope-from=kwolf@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Am 25.11.2022 um 18:53 hat Philippe Mathieu-Daudé geschrieben: > The inlined nbd_readXX() functions call beXX_to_cpu(), themselves > declared in . This fixes when refactoring: > > In file included from ../../block/nbd.c:44: > include/block/nbd.h: In function 'nbd_read16': > include/block/nbd.h:383:12: error: implicit declaration of function 'be16_to_cpu' [-Werror=implicit-function-declaration] > 383 | *val = be##bits##_to_cpu(*val); \ > | ^~ > include/block/nbd.h:387:1: note: in expansion of macro 'DEF_NBD_READ_N' > 387 | DEF_NBD_READ_N(16) /* Defines nbd_read16(). */ > | ^~~~~~~~~~~~~~ > > Signed-off-by: Philippe Mathieu-Daudé Thanks, applied to the block branch. Kevin