From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 858CFC636D6 for ; Fri, 3 Feb 2023 15:24:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232834AbjBCPYb (ORCPT ); Fri, 3 Feb 2023 10:24:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41438 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232391AbjBCPYK (ORCPT ); Fri, 3 Feb 2023 10:24:10 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B648DAF0F0; Fri, 3 Feb 2023 07:22:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=u7jwLMXldmeJxhCcGr/15aDobf0TWv+r93C3ZJojfIk=; b=3pb3nUWrNv8EtAjlU3Jf2bufFz wpolZXfSNmIA+jXRDuE07Cza6yeXZB0ys4qHd43GYco99oA6Ipt7PE2lJ8GnT5M4E1RYinv1+/AGE FcU/UPOrwdC+sfK0C7yyQenTc1QxZ4yrFboXQhQN/hTFhZ1Unmg9PjQJ+3C7QzjGEDMY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pNxsp-0041JE-Vy; Fri, 03 Feb 2023 16:21:47 +0100 Date: Fri, 3 Feb 2023 16:21:47 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH 7/9] net: pcs: add driver for MediaTek SGMII PCS Message-ID: References: <30f3ff512a2082ba4cf58bf6098f2ed776051976.1675407169.git.daniel@makrotopia.org> <20230203150014.ugkasp4rq5arqs6s@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203150014.ugkasp4rq5arqs6s@skbuf> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 03, 2023 at 05:00:14PM +0200, Vladimir Oltean wrote: > On Fri, Feb 03, 2023 at 03:14:29PM +0100, Andrew Lunn wrote: > > > index 6e7e6c346a3e..cf65646656e9 100644 > > > --- a/drivers/net/pcs/Kconfig > > > +++ b/drivers/net/pcs/Kconfig > > > @@ -18,6 +18,12 @@ config PCS_LYNX > > > This module provides helpers to phylink for managing the Lynx PCS > > > which is part of the Layerscape and QorIQ Ethernet SERDES. > > > > > > +config PCS_MTK > > > + tristate > > > + help > > > + This module provides helpers to phylink for managing the LynxI PCS > > > + which is part of MediaTek's SoC and Ethernet switch ICs. > > > > You should probably have a more specific name, for when MTK produces a > > new PCS which is completely different. > > > > Also, how similar is this LynxI PCS to the Lynx PCS? > > Probably not very similar. Here's the Mediatek 32-bit memory map, > translated by me to a 16-bit MDIO memory map: Thanks. Given the similarities in the name, i had to ask... Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01F89C61DA4 for ; Fri, 3 Feb 2023 15:27:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OliHjI/6bDqbU/daOMJBdQrSivzOqj15FvfYLMnJ4gQ=; b=fBA/AzPGsfcbJ/ KAoEJIwmi1H84rHs3WuzmDd2EEJlJI2M2ZoqBKaSoghQ4BjfOoUgSep/FYaSnUbDPFxRu24DwHI9j Bj6N24oDS5Ce+LzdECOu5Uoj445RdzVNImr0QBhtbD+mwDI/+IDiACtrrg7rNKn3PqRr6xZnQe9qL 4OB7l+dqq+CYvuKJBysNV6A0+neG7oCM+qfv0aYB4X0UWmmr5eOnsdoftIhVky7BgWOkMTeapG2cM dsEjVfyejOqTSMs4Kv9sNAG2i5uKGhSMiFvRz5YZCoMAUhDy/FTrYAba4yrkgkBK5j4axP5o3hlI0 Trigc4Ej8gAcw4W52YaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxx4-002iUP-4n; Fri, 03 Feb 2023 15:26:10 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxsz-002fzb-R9; Fri, 03 Feb 2023 15:21:59 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=u7jwLMXldmeJxhCcGr/15aDobf0TWv+r93C3ZJojfIk=; b=3pb3nUWrNv8EtAjlU3Jf2bufFz wpolZXfSNmIA+jXRDuE07Cza6yeXZB0ys4qHd43GYco99oA6Ipt7PE2lJ8GnT5M4E1RYinv1+/AGE FcU/UPOrwdC+sfK0C7yyQenTc1QxZ4yrFboXQhQN/hTFhZ1Unmg9PjQJ+3C7QzjGEDMY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pNxsp-0041JE-Vy; Fri, 03 Feb 2023 16:21:47 +0100 Date: Fri, 3 Feb 2023 16:21:47 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: Daniel Golle , netdev@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Russell King , Heiner Kallweit , Lorenzo Bianconi , Mark Lee , John Crispin , Felix Fietkau , AngeloGioacchino Del Regno , Matthias Brugger , DENG Qingfang , Landen Chao , Sean Wang , Paolo Abeni , Jakub Kicinski , Eric Dumazet , "David S. Miller" , Florian Fainelli , Jianhui Zhao , =?iso-8859-1?Q?Bj=F8rn?= Mork Subject: Re: [PATCH 7/9] net: pcs: add driver for MediaTek SGMII PCS Message-ID: References: <30f3ff512a2082ba4cf58bf6098f2ed776051976.1675407169.git.daniel@makrotopia.org> <20230203150014.ugkasp4rq5arqs6s@skbuf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230203150014.ugkasp4rq5arqs6s@skbuf> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_072157_901743_D4A7B2F4 X-CRM114-Status: GOOD ( 15.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Feb 03, 2023 at 05:00:14PM +0200, Vladimir Oltean wrote: > On Fri, Feb 03, 2023 at 03:14:29PM +0100, Andrew Lunn wrote: > > > index 6e7e6c346a3e..cf65646656e9 100644 > > > --- a/drivers/net/pcs/Kconfig > > > +++ b/drivers/net/pcs/Kconfig > > > @@ -18,6 +18,12 @@ config PCS_LYNX > > > This module provides helpers to phylink for managing the Lynx PCS > > > which is part of the Layerscape and QorIQ Ethernet SERDES. > > > > > > +config PCS_MTK > > > + tristate > > > + help > > > + This module provides helpers to phylink for managing the LynxI PCS > > > + which is part of MediaTek's SoC and Ethernet switch ICs. > > > > You should probably have a more specific name, for when MTK produces a > > new PCS which is completely different. > > > > Also, how similar is this LynxI PCS to the Lynx PCS? > > Probably not very similar. Here's the Mediatek 32-bit memory map, > translated by me to a 16-bit MDIO memory map: Thanks. Given the similarities in the name, i had to ask... Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel