From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26E07C636D4 for ; Fri, 3 Feb 2023 15:43:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233134AbjBCPn4 (ORCPT ); Fri, 3 Feb 2023 10:43:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232760AbjBCPny (ORCPT ); Fri, 3 Feb 2023 10:43:54 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0F1D1991C9; Fri, 3 Feb 2023 07:43:53 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 832D461F78; Fri, 3 Feb 2023 15:43:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D950C433D2; Fri, 3 Feb 2023 15:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675439031; bh=QzHwbvdzJR6mErN/zIzcOVMcsP1F30dlSQclZPv72B4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UbbF0xAiNC89xQ5+9sm34iQzWVPMfZowuzZgFzPT78pXxWNr3UFbXVVm5h1k7/keE P7OTOFCzKnTTDat8F/503u13jEbmpfO+tQ6wrCAFGmPvc1rg4YULTP1EGhSyPDPzAl 3DwuvvXHuNYiY89ygTOx8ZOF9A0RcDozTJd6TYPBEYk4QTrObN33bDKP4MBEy0UjSg 0PSggRFRKSNjTasaEZjN9qt8dIbOR91ty9xFG911bVUyH5jmIAvhxs9pYH5FENsVgF 2iIWuZ2SCvgulp0GRkV+bqS0gOBwEqvnalCjQRTyMsx2g+G8m/V2TidcSjigpGKEh4 6JSDIghYRoOqQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B472405BE; Fri, 3 Feb 2023 12:43:48 -0300 (-03) Date: Fri, 3 Feb 2023 12:43:48 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers Subject: Re: [PATCH v1] perf pmu: Fix aarch64 build Message-ID: References: <20230203014014.75720-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Fri, Feb 03, 2023 at 11:43:23AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > > > > > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > > > > > > > > > > > ARM64 overrides a weak function but a previous change had broken the > > > > > > build. > > > > > > > > > > > > Fixes: 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") > > > > > > > > > > As 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") is > > > > > only on tmp.perf/core then it may be best to just squash this fix into > > > > > that. > > > > > > > > Yeah, that was my intention, I'll fold it there to keep bisection, > > > > thanks for fixing it so fast, I'll double check on my rk3399 board and > > > > on again on the cross-build container. > > > > > > Nope, that is not what I reported yesterday, trying to build it on the > > > rk3399 board: > > > > Sorry, pulled the trigger too soon, this is _before_ applying your fix, > > I should't multitask too much :-\ > > > > I'll double check now, > > Ok, now it is exploding at: > > pmu-events/pmu-events.c: In function ‘decompress’: > pmu-events/pmu-events.c:3598:11: error: ‘struct pmu_event’ has no member named ‘metric_name’ > 3598 | pe->metric_name = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3600:11: error: ‘struct pmu_event’ has no member named ‘metric_group’ > 3600 | pe->metric_group = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3614:11: error: ‘struct pmu_event’ has no member named ‘metric_constraint’ > 3614 | pe->metric_constraint = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3616:11: error: ‘struct pmu_event’ has no member named ‘metric_expr’ > 3616 | pe->metric_expr = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c: At top level: > pmu-events/pmu-events.c:3637:32: error: no previous prototype for ‘perf_pmu__find_table’ [-Werror=missing-prototypes] > 3637 | const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) > | ^~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:98: /tmp/build/perf/pmu-events/pmu-events.o] Error 1 > make[2]: *** [Makefile.perf:676: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2 > make[2]: *** Waiting for unfinished jobs.... > CC /tmp/build/perf/builtin-ftrace.o I tried bisecting, but at this cset: acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1 d22e569cd33d (HEAD) perf pmu-events: Separate the metrics from events for no jevents acme@roc-rk3399-pc:~/git/perf$ I'm getting this: CC /tmp/build/perf/pmu-events/pmu-events.o pmu-events/pmu-events.c:3637:32: error: no previous prototype for ‘perf_pmu__find_table’ [-Werror=missing-prototypes] 3637 | const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) | ^~~~~~~~~~~~~~~~~~~~ CC /tmp/build/perf/builtin-ftrace.o CC /tmp/build/perf/builtin-help.o CC /tmp/build/perf/builtin-buildid-list.o cc1: all warnings being treated as errors make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/pmu-events/pmu-events.o] Error 1 make[2]: *** [Makefile.perf:676: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2 make[2]: *** Waiting for unfinished jobs.... CC /tmp/build/perf/builtin-buildid-cache.o CC /tmp/build/perf/tests/attr.o arch/arm64/util/pmu.c: In function ‘pmu_events_table__find’: arch/arm64/util/pmu.c:35:24: error: implicit declaration of function ‘perf_pmu__find_table’; did you mean ‘perf_pmu__find_by_type’? [-Werror=implicit-function-declaration] 35 | return perf_pmu__find_table(pmu); | ^~~~~~~~~~~~~~~~~~~~ | perf_pmu__find_by_type arch/arm64/util/pmu.c:35:24: error: returning ‘int’ from a function with return type ‘const struct pmu_events_table *’ makes pointer from integer without a cast [-Werror=int-conversion] 35 | return perf_pmu__find_table(pmu); | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/arch/arm64/util/pmu.o] Error 1 make[5]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: util] Error 2 make[4]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: arm64] Error 2 make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: arch] Error 2 make[3]: *** Waiting for unfinished jobs.... CC /tmp/build/perf/tests/vmlinux-kallsyms.o ----- I'm building with: acme@roc-rk3399-pc:~/git/perf$ alias m alias m='make -k BUILD_BPF_SKEL=1 CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin && git status && perf test python' acme@roc-rk3399-pc:~/git/perf$ rm -rf /tmp/build/$(basename $(pwd)) ; mkdir -p /tmp/build/$(basename $(pwd)) ; m To then go back to: > pmu-events/pmu-events.c:3616:11: error: ‘struct pmu_event’ has no member named ‘metric_expr’ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B1563C61DA4 for ; Fri, 3 Feb 2023 15:44:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ef+D8SmA43PyEz1shM+CZ5RFW0+2zsUQkTunYer5njg=; b=dWNnG84Q+C687s 4VHRHV4tBGMsGcTpOMWuh3s83lUMuD3CxyvxB03zFUbmJ7c0G1U8AJlmNMjK5MFXfPqTIAZSxr8Md +xKVC85fhZiKGMVy6S35Ys6O80FkNZFcvM7XmxFCzrDHW+Ff1UZMw0JxtEYVuiaEOUycuXU3b19hH FExY7QULQmmrwca+k2LwBPlZa0nXzL1Ytms9mxS+UFHrA/oWhsGgH/EoriAuVhfHuGpsw5jQpKAW5 mrksRTyihNcAPu9jstWbAqySjrhR4z+zV3earGktu42ZHZ/qUZooc62U7AQi9X2CiJAh9Aj6QklqS 73l1IfxgrWdprDGpYyjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyEF-002oOK-PN; Fri, 03 Feb 2023 15:43:55 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyEE-002oNY-Ic for linux-arm-kernel@bombadil.infradead.org; Fri, 03 Feb 2023 15:43:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=aOIhYKLkyg1C4r6vPgwwsXkhJ4T8iVX9iyUz41R8NIM=; b=QTKg3DeiCVcHv7wGAYtKBSG0p6 eZUje8hgEBfA5uxh2QRYi9vowUlyqrUUZOROAB+pK4F3/KtqhEQ8UTImiKwBmExTD7MsXuWlxaEmQ B+2uQ8RmyujWSjVoILp3WAjLQaB6RkrPVIKW2UGyLlepIKq9Ej8ZfWqeKTI0NY8xpSyT5kam6IlyA S+x3ToxkxECBwvzEhbM1XnUSDgLFNVPGYAXkzOSqm+/2v/IRV4UXfJxz1uENcjw6+z784SKZLVNNS gCllRZFU40lBnh86+gu4hq9bTKj4kUcu5fjDzzGSCxuG8IbelCLM217I2jZRvJoYIsRzTjaELDBHA HRazrAYQ==; Received: from [187.19.237.165] (helo=quaco.ghostprotocols.net) by casper.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNyEA-00EQ29-V3; Fri, 03 Feb 2023 15:43:51 +0000 Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B472405BE; Fri, 3 Feb 2023 12:43:48 -0300 (-03) Date: Fri, 3 Feb 2023 12:43:48 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Cc: John Garry , Will Deacon , James Clark , Mike Leach , Leo Yan , Peter Zijlstra , Ingo Molnar , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , Kan Liang , Kim Phillips , Florian Fischer , Ravi Bangoria , Xing Zhengjun , Rob Herring , Kang Minchul , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Sandipan Das , Jing Zhang , linuxppc-dev@lists.ozlabs.org, Kajol Jain , Stephane Eranian , Perry Taylor , Caleb Biggers Subject: Re: [PATCH v1] perf pmu: Fix aarch64 build Message-ID: References: <20230203014014.75720-1-irogers@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org RW0gRnJpLCBGZWIgMDMsIDIwMjMgYXQgMTE6NDM6MjNBTSAtMDMwMCwgQXJuYWxkbyBDYXJ2YWxo byBkZSBNZWxvIGVzY3JldmV1Ogo+IEVtIEZyaSwgRmViIDAzLCAyMDIzIGF0IDExOjM2OjMwQU0g LTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUgTWVsbyBlc2NyZXZldToKPiA+IEVtIEZyaSwgRmVi IDAzLCAyMDIzIGF0IDExOjM1OjI5QU0gLTAzMDAsIEFybmFsZG8gQ2FydmFsaG8gZGUgTWVsbyBl c2NyZXZldToKPiA+ID4gRW0gRnJpLCBGZWIgMDMsIDIwMjMgYXQgMTE6MTc6MzhBTSAtMDMwMCwg QXJuYWxkbyBDYXJ2YWxobyBkZSBNZWxvIGVzY3JldmV1Ogo+ID4gPiA+IEVtIFRodSwgRmViIDAy LCAyMDIzIGF0IDA1OjQxOjIyUE0gLTA4MDAsIElhbiBSb2dlcnMgZXNjcmV2ZXU6Cj4gPiA+ID4g PiBPbiBUaHUsIEZlYiAyLCAyMDIzIGF0IDU6NDAgUE0gSWFuIFJvZ2VycyA8aXJvZ2Vyc0Bnb29n bGUuY29tPiB3cm90ZToKPiA+ID4gPiA+ID4KPiA+ID4gPiA+ID4gQVJNNjQgb3ZlcnJpZGVzIGEg d2VhayBmdW5jdGlvbiBidXQgYSBwcmV2aW91cyBjaGFuZ2UgaGFkIGJyb2tlbiB0aGUKPiA+ID4g PiA+ID4gYnVpbGQuCj4gPiA+ID4gPiA+Cj4gPiA+ID4gPiA+IEZpeGVzOiA4Y2VmZWI4YmQzMzYg KCJwZXJmIHBtdS1ldmVudHM6IEludHJvZHVjZSBwbXVfbWV0cmljc190YWJsZSIpCj4gPiA+ID4g PiAKPiA+ID4gPiA+IEFzIDhjZWZlYjhiZDMzNiAoInBlcmYgcG11LWV2ZW50czogSW50cm9kdWNl IHBtdV9tZXRyaWNzX3RhYmxlIikgaXMKPiA+ID4gPiA+IG9ubHkgb24gdG1wLnBlcmYvY29yZSB0 aGVuIGl0IG1heSBiZSBiZXN0IHRvIGp1c3Qgc3F1YXNoIHRoaXMgZml4IGludG8KPiA+ID4gPiA+ IHRoYXQuCj4gPiA+ID4gCj4gPiA+ID4gWWVhaCwgdGhhdCB3YXMgbXkgaW50ZW50aW9uLCBJJ2xs IGZvbGQgaXQgdGhlcmUgdG8ga2VlcCBiaXNlY3Rpb24sCj4gPiA+ID4gdGhhbmtzIGZvciBmaXhp bmcgaXQgc28gZmFzdCwgSSdsbCBkb3VibGUgY2hlY2sgb24gbXkgcmszMzk5IGJvYXJkIGFuZAo+ ID4gPiA+IG9uIGFnYWluIG9uIHRoZSBjcm9zcy1idWlsZCBjb250YWluZXIuCj4gPiA+IAo+ID4g PiBOb3BlLCB0aGF0IGlzIG5vdCB3aGF0IEkgcmVwb3J0ZWQgeWVzdGVyZGF5LCB0cnlpbmcgdG8g YnVpbGQgaXQgb24gdGhlCj4gPiA+IHJrMzM5OSBib2FyZDoKPiA+IAo+ID4gU29ycnksIHB1bGxl ZCB0aGUgdHJpZ2dlciB0b28gc29vbiwgdGhpcyBpcyBfYmVmb3JlXyBhcHBseWluZyB5b3VyIGZp eCwKPiA+IEkgc2hvdWxkJ3QgbXVsdGl0YXNrIHRvbyBtdWNoIDotXAo+ID4gCj4gPiBJJ2xsIGRv dWJsZSBjaGVjayBub3csIAo+IAo+IE9rLCBub3cgaXQgaXMgZXhwbG9kaW5nIGF0Ogo+IAo+IHBt dS1ldmVudHMvcG11LWV2ZW50cy5jOiBJbiBmdW5jdGlvbiDigJhkZWNvbXByZXNz4oCZOgo+IHBt dS1ldmVudHMvcG11LWV2ZW50cy5jOjM1OTg6MTE6IGVycm9yOiDigJhzdHJ1Y3QgcG11X2V2ZW50 4oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYbWV0cmljX25hbWXigJkKPiAgMzU5OCB8ICAgICAg ICAgcGUtPm1ldHJpY19uYW1lID0gKCpwID09ICdcMCcgPyBOVUxMIDogcCk7Cj4gICAgICAgfCAg ICAgICAgICAgXn4KPiBwbXUtZXZlbnRzL3BtdS1ldmVudHMuYzozNjAwOjExOiBlcnJvcjog4oCY c3RydWN0IHBtdV9ldmVudOKAmSBoYXMgbm8gbWVtYmVyIG5hbWVkIOKAmG1ldHJpY19ncm91cOKA mQo+ICAzNjAwIHwgICAgICAgICBwZS0+bWV0cmljX2dyb3VwID0gKCpwID09ICdcMCcgPyBOVUxM IDogcCk7Cj4gICAgICAgfCAgICAgICAgICAgXn4KPiBwbXUtZXZlbnRzL3BtdS1ldmVudHMuYzoz NjE0OjExOiBlcnJvcjog4oCYc3RydWN0IHBtdV9ldmVudOKAmSBoYXMgbm8gbWVtYmVyIG5hbWVk IOKAmG1ldHJpY19jb25zdHJhaW504oCZCj4gIDM2MTQgfCAgICAgICAgIHBlLT5tZXRyaWNfY29u c3RyYWludCA9ICgqcCA9PSAnXDAnID8gTlVMTCA6IHApOwo+ICAgICAgIHwgICAgICAgICAgIF5+ Cj4gcG11LWV2ZW50cy9wbXUtZXZlbnRzLmM6MzYxNjoxMTogZXJyb3I6IOKAmHN0cnVjdCBwbXVf ZXZlbnTigJkgaGFzIG5vIG1lbWJlciBuYW1lZCDigJhtZXRyaWNfZXhwcuKAmQo+ICAzNjE2IHwg ICAgICAgICBwZS0+bWV0cmljX2V4cHIgPSAoKnAgPT0gJ1wwJyA/IE5VTEwgOiBwKTsKPiAgICAg ICB8ICAgICAgICAgICBefgo+IHBtdS1ldmVudHMvcG11LWV2ZW50cy5jOiBBdCB0b3AgbGV2ZWw6 Cj4gcG11LWV2ZW50cy9wbXUtZXZlbnRzLmM6MzYzNzozMjogZXJyb3I6IG5vIHByZXZpb3VzIHBy b3RvdHlwZSBmb3Ig4oCYcGVyZl9wbXVfX2ZpbmRfdGFibGXigJkgWy1XZXJyb3I9bWlzc2luZy1w cm90b3R5cGVzXQo+ICAzNjM3IHwgY29uc3Qgc3RydWN0IHBtdV9ldmVudHNfdGFibGUgKnBlcmZf cG11X19maW5kX3RhYmxlKHN0cnVjdCBwZXJmX3BtdSAqcG11KQo+ICAgICAgIHwgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+Cj4gY2MxOiBhbGwgd2Fy bmluZ3MgYmVpbmcgdHJlYXRlZCBhcyBlcnJvcnMKPiBtYWtlWzNdOiAqKiogWy9ob21lL2FjbWUv Z2l0L3BlcmYvdG9vbHMvYnVpbGQvTWFrZWZpbGUuYnVpbGQ6OTg6IC90bXAvYnVpbGQvcGVyZi9w bXUtZXZlbnRzL3BtdS1ldmVudHMub10gRXJyb3IgMQo+IG1ha2VbMl06ICoqKiBbTWFrZWZpbGUu cGVyZjo2NzY6IC90bXAvYnVpbGQvcGVyZi9wbXUtZXZlbnRzL3BtdS1ldmVudHMtaW4ub10gRXJy b3IgMgo+IG1ha2VbMl06ICoqKiBXYWl0aW5nIGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCj4gICBD QyAgICAgIC90bXAvYnVpbGQvcGVyZi9idWlsdGluLWZ0cmFjZS5vCgpJIHRyaWVkIGJpc2VjdGlu ZywgYnV0IGF0IHRoaXMgY3NldDoKCmFjbWVAcm9jLXJrMzM5OS1wYzp+L2dpdC9wZXJmJCBnaXQg bG9nIC0tb25lbGluZSAtMQpkMjJlNTY5Y2QzM2QgKEhFQUQpIHBlcmYgcG11LWV2ZW50czogU2Vw YXJhdGUgdGhlIG1ldHJpY3MgZnJvbSBldmVudHMgZm9yIG5vIGpldmVudHMKYWNtZUByb2Mtcmsz Mzk5LXBjOn4vZ2l0L3BlcmYkCgpJJ20gZ2V0dGluZyB0aGlzOgoKICBDQyAgICAgIC90bXAvYnVp bGQvcGVyZi9wbXUtZXZlbnRzL3BtdS1ldmVudHMubwpwbXUtZXZlbnRzL3BtdS1ldmVudHMuYzoz NjM3OjMyOiBlcnJvcjogbm8gcHJldmlvdXMgcHJvdG90eXBlIGZvciDigJhwZXJmX3BtdV9fZmlu ZF90YWJsZeKAmSBbLVdlcnJvcj1taXNzaW5nLXByb3RvdHlwZXNdCiAzNjM3IHwgY29uc3Qgc3Ry dWN0IHBtdV9ldmVudHNfdGFibGUgKnBlcmZfcG11X19maW5kX3RhYmxlKHN0cnVjdCBwZXJmX3Bt dSAqcG11KQogICAgICB8ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+ fn5+fn5+fn5+fgogIENDICAgICAgL3RtcC9idWlsZC9wZXJmL2J1aWx0aW4tZnRyYWNlLm8KICBD QyAgICAgIC90bXAvYnVpbGQvcGVyZi9idWlsdGluLWhlbHAubwogIENDICAgICAgL3RtcC9idWls ZC9wZXJmL2J1aWx0aW4tYnVpbGRpZC1saXN0Lm8KY2MxOiBhbGwgd2FybmluZ3MgYmVpbmcgdHJl YXRlZCBhcyBlcnJvcnMKbWFrZVszXTogKioqIFsvaG9tZS9hY21lL2dpdC9wZXJmL3Rvb2xzL2J1 aWxkL01ha2VmaWxlLmJ1aWxkOjk3OiAvdG1wL2J1aWxkL3BlcmYvcG11LWV2ZW50cy9wbXUtZXZl bnRzLm9dIEVycm9yIDEKbWFrZVsyXTogKioqIFtNYWtlZmlsZS5wZXJmOjY3NjogL3RtcC9idWls ZC9wZXJmL3BtdS1ldmVudHMvcG11LWV2ZW50cy1pbi5vXSBFcnJvciAyCm1ha2VbMl06ICoqKiBX YWl0aW5nIGZvciB1bmZpbmlzaGVkIGpvYnMuLi4uCiAgQ0MgICAgICAvdG1wL2J1aWxkL3BlcmYv YnVpbHRpbi1idWlsZGlkLWNhY2hlLm8KCjxTTklQPgoKICBDQyAgICAgIC90bXAvYnVpbGQvcGVy Zi90ZXN0cy9hdHRyLm8KYXJjaC9hcm02NC91dGlsL3BtdS5jOiBJbiBmdW5jdGlvbiDigJhwbXVf ZXZlbnRzX3RhYmxlX19maW5k4oCZOgphcmNoL2FybTY0L3V0aWwvcG11LmM6MzU6MjQ6IGVycm9y OiBpbXBsaWNpdCBkZWNsYXJhdGlvbiBvZiBmdW5jdGlvbiDigJhwZXJmX3BtdV9fZmluZF90YWJs ZeKAmTsgZGlkIHlvdSBtZWFuIOKAmHBlcmZfcG11X19maW5kX2J5X3R5cGXigJk/IFstV2Vycm9y PWltcGxpY2l0LWZ1bmN0aW9uLWRlY2xhcmF0aW9uXQogICAzNSB8ICAgICAgICAgICAgICAgICBy ZXR1cm4gcGVyZl9wbXVfX2ZpbmRfdGFibGUocG11KTsKICAgICAgfCAgICAgICAgICAgICAgICAg ICAgICAgIF5+fn5+fn5+fn5+fn5+fn5+fn5+CiAgICAgIHwgICAgICAgICAgICAgICAgICAgICAg ICBwZXJmX3BtdV9fZmluZF9ieV90eXBlCmFyY2gvYXJtNjQvdXRpbC9wbXUuYzozNToyNDogZXJy b3I6IHJldHVybmluZyDigJhpbnTigJkgZnJvbSBhIGZ1bmN0aW9uIHdpdGggcmV0dXJuIHR5cGUg 4oCYY29uc3Qgc3RydWN0IHBtdV9ldmVudHNfdGFibGUgKuKAmSBtYWtlcyBwb2ludGVyIGZyb20g aW50ZWdlciB3aXRob3V0IGEgY2FzdCBbLVdlcnJvcj1pbnQtY29udmVyc2lvbl0KICAgMzUgfCAg ICAgICAgICAgICAgICAgcmV0dXJuIHBlcmZfcG11X19maW5kX3RhYmxlKHBtdSk7CiAgICAgIHwg ICAgICAgICAgICAgICAgICAgICAgICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+CmNjMTogYWxs IHdhcm5pbmdzIGJlaW5nIHRyZWF0ZWQgYXMgZXJyb3JzCm1ha2VbNl06ICoqKiBbL2hvbWUvYWNt ZS9naXQvcGVyZi90b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDo5NzogL3RtcC9idWlsZC9wZXJm L2FyY2gvYXJtNjQvdXRpbC9wbXUub10gRXJyb3IgMQptYWtlWzVdOiAqKiogWy9ob21lL2FjbWUv Z2l0L3BlcmYvdG9vbHMvYnVpbGQvTWFrZWZpbGUuYnVpbGQ6MTM5OiB1dGlsXSBFcnJvciAyCm1h a2VbNF06ICoqKiBbL2hvbWUvYWNtZS9naXQvcGVyZi90b29scy9idWlsZC9NYWtlZmlsZS5idWls ZDoxMzk6IGFybTY0XSBFcnJvciAyCm1ha2VbM106ICoqKiBbL2hvbWUvYWNtZS9naXQvcGVyZi90 b29scy9idWlsZC9NYWtlZmlsZS5idWlsZDoxMzk6IGFyY2hdIEVycm9yIDIKbWFrZVszXTogKioq IFdhaXRpbmcgZm9yIHVuZmluaXNoZWQgam9icy4uLi4KICBDQyAgICAgIC90bXAvYnVpbGQvcGVy Zi90ZXN0cy92bWxpbnV4LWthbGxzeW1zLm8KCi0tLS0tCgpJJ20gYnVpbGRpbmcgd2l0aDoKCgph Y21lQHJvYy1yazMzOTktcGM6fi9naXQvcGVyZiQgYWxpYXMgbQphbGlhcyBtPSdtYWtlIC1rIEJV SUxEX0JQRl9TS0VMPTEgQ09SRVNJR0hUPTEgTz0vdG1wL2J1aWxkL3BlcmYgLUMgdG9vbHMvcGVy ZiBpbnN0YWxsLWJpbiAmJiBnaXQgc3RhdHVzICYmIHBlcmYgdGVzdCBweXRob24nCmFjbWVAcm9j LXJrMzM5OS1wYzp+L2dpdC9wZXJmJCBybSAtcmYgL3RtcC9idWlsZC8kKGJhc2VuYW1lICQocHdk KSkgOyBta2RpciAtcCAvdG1wL2J1aWxkLyQoYmFzZW5hbWUgJChwd2QpKSA7IG0KCgpUbyB0aGVu IGdvIGJhY2sgdG86Cgo+IHBtdS1ldmVudHMvcG11LWV2ZW50cy5jOjM2MTY6MTE6IGVycm9yOiDi gJhzdHJ1Y3QgcG11X2V2ZW504oCZIGhhcyBubyBtZW1iZXIgbmFtZWQg4oCYbWV0cmljX2V4cHLi gJkKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51 eC1hcm0ta2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h cm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE0BBC61DA4 for ; Fri, 3 Feb 2023 15:44:51 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4P7g2V1YsQz3f7J for ; Sat, 4 Feb 2023 02:44:50 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UbbF0xAi; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.org (client-ip=139.178.84.217; helo=dfw.source.kernel.org; envelope-from=acme@kernel.org; receiver=) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=UbbF0xAi; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4P7g1Q6Zz4z3cGk for ; Sat, 4 Feb 2023 02:43:54 +1100 (AEDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7AACE61F77; Fri, 3 Feb 2023 15:43:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7D950C433D2; Fri, 3 Feb 2023 15:43:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675439031; bh=QzHwbvdzJR6mErN/zIzcOVMcsP1F30dlSQclZPv72B4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UbbF0xAiNC89xQ5+9sm34iQzWVPMfZowuzZgFzPT78pXxWNr3UFbXVVm5h1k7/keE P7OTOFCzKnTTDat8F/503u13jEbmpfO+tQ6wrCAFGmPvc1rg4YULTP1EGhSyPDPzAl 3DwuvvXHuNYiY89ygTOx8ZOF9A0RcDozTJd6TYPBEYk4QTrObN33bDKP4MBEy0UjSg 0PSggRFRKSNjTasaEZjN9qt8dIbOR91ty9xFG911bVUyH5jmIAvhxs9pYH5FENsVgF 2iIWuZ2SCvgulp0GRkV+bqS0gOBwEqvnalCjQRTyMsx2g+G8m/V2TidcSjigpGKEh4 6JSDIghYRoOqQ== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id 4B472405BE; Fri, 3 Feb 2023 12:43:48 -0300 (-03) Date: Fri, 3 Feb 2023 12:43:48 -0300 From: Arnaldo Carvalho de Melo To: Ian Rogers Subject: Re: [PATCH v1] perf pmu: Fix aarch64 build Message-ID: References: <20230203014014.75720-1-irogers@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Url: http://acmel.wordpress.com X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Kang Minchul , Sandipan Das , Peter Zijlstra , Perry Taylor , Stephane Eranian , linux-kernel@vger.kernel.org, James Clark , Kim Phillips , Will Deacon , Kan Liang , Rob Herring , Alexander Shishkin , Ingo Molnar , Xing Zhengjun , Mike Leach , John Garry , Kajol Jain , Namhyung Kim , Caleb Biggers , linux-arm-kernel@lists.infradead.org, Ravi Bangoria , Florian Fischer , Adrian Hunter , linux-perf-users@vger.kernel.org, Jiri Olsa , Leo Yan , linuxppc-dev@lists.ozlabs.org, Jing Zhang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Em Fri, Feb 03, 2023 at 11:43:23AM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Feb 03, 2023 at 11:36:30AM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Fri, Feb 03, 2023 at 11:35:29AM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Fri, Feb 03, 2023 at 11:17:38AM -0300, Arnaldo Carvalho de Melo escreveu: > > > > Em Thu, Feb 02, 2023 at 05:41:22PM -0800, Ian Rogers escreveu: > > > > > On Thu, Feb 2, 2023 at 5:40 PM Ian Rogers wrote: > > > > > > > > > > > > ARM64 overrides a weak function but a previous change had broken the > > > > > > build. > > > > > > > > > > > > Fixes: 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") > > > > > > > > > > As 8cefeb8bd336 ("perf pmu-events: Introduce pmu_metrics_table") is > > > > > only on tmp.perf/core then it may be best to just squash this fix into > > > > > that. > > > > > > > > Yeah, that was my intention, I'll fold it there to keep bisection, > > > > thanks for fixing it so fast, I'll double check on my rk3399 board and > > > > on again on the cross-build container. > > > > > > Nope, that is not what I reported yesterday, trying to build it on the > > > rk3399 board: > > > > Sorry, pulled the trigger too soon, this is _before_ applying your fix, > > I should't multitask too much :-\ > > > > I'll double check now, > > Ok, now it is exploding at: > > pmu-events/pmu-events.c: In function ‘decompress’: > pmu-events/pmu-events.c:3598:11: error: ‘struct pmu_event’ has no member named ‘metric_name’ > 3598 | pe->metric_name = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3600:11: error: ‘struct pmu_event’ has no member named ‘metric_group’ > 3600 | pe->metric_group = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3614:11: error: ‘struct pmu_event’ has no member named ‘metric_constraint’ > 3614 | pe->metric_constraint = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c:3616:11: error: ‘struct pmu_event’ has no member named ‘metric_expr’ > 3616 | pe->metric_expr = (*p == '\0' ? NULL : p); > | ^~ > pmu-events/pmu-events.c: At top level: > pmu-events/pmu-events.c:3637:32: error: no previous prototype for ‘perf_pmu__find_table’ [-Werror=missing-prototypes] > 3637 | const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) > | ^~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:98: /tmp/build/perf/pmu-events/pmu-events.o] Error 1 > make[2]: *** [Makefile.perf:676: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2 > make[2]: *** Waiting for unfinished jobs.... > CC /tmp/build/perf/builtin-ftrace.o I tried bisecting, but at this cset: acme@roc-rk3399-pc:~/git/perf$ git log --oneline -1 d22e569cd33d (HEAD) perf pmu-events: Separate the metrics from events for no jevents acme@roc-rk3399-pc:~/git/perf$ I'm getting this: CC /tmp/build/perf/pmu-events/pmu-events.o pmu-events/pmu-events.c:3637:32: error: no previous prototype for ‘perf_pmu__find_table’ [-Werror=missing-prototypes] 3637 | const struct pmu_events_table *perf_pmu__find_table(struct perf_pmu *pmu) | ^~~~~~~~~~~~~~~~~~~~ CC /tmp/build/perf/builtin-ftrace.o CC /tmp/build/perf/builtin-help.o CC /tmp/build/perf/builtin-buildid-list.o cc1: all warnings being treated as errors make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/pmu-events/pmu-events.o] Error 1 make[2]: *** [Makefile.perf:676: /tmp/build/perf/pmu-events/pmu-events-in.o] Error 2 make[2]: *** Waiting for unfinished jobs.... CC /tmp/build/perf/builtin-buildid-cache.o CC /tmp/build/perf/tests/attr.o arch/arm64/util/pmu.c: In function ‘pmu_events_table__find’: arch/arm64/util/pmu.c:35:24: error: implicit declaration of function ‘perf_pmu__find_table’; did you mean ‘perf_pmu__find_by_type’? [-Werror=implicit-function-declaration] 35 | return perf_pmu__find_table(pmu); | ^~~~~~~~~~~~~~~~~~~~ | perf_pmu__find_by_type arch/arm64/util/pmu.c:35:24: error: returning ‘int’ from a function with return type ‘const struct pmu_events_table *’ makes pointer from integer without a cast [-Werror=int-conversion] 35 | return perf_pmu__find_table(pmu); | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: all warnings being treated as errors make[6]: *** [/home/acme/git/perf/tools/build/Makefile.build:97: /tmp/build/perf/arch/arm64/util/pmu.o] Error 1 make[5]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: util] Error 2 make[4]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: arm64] Error 2 make[3]: *** [/home/acme/git/perf/tools/build/Makefile.build:139: arch] Error 2 make[3]: *** Waiting for unfinished jobs.... CC /tmp/build/perf/tests/vmlinux-kallsyms.o ----- I'm building with: acme@roc-rk3399-pc:~/git/perf$ alias m alias m='make -k BUILD_BPF_SKEL=1 CORESIGHT=1 O=/tmp/build/perf -C tools/perf install-bin && git status && perf test python' acme@roc-rk3399-pc:~/git/perf$ rm -rf /tmp/build/$(basename $(pwd)) ; mkdir -p /tmp/build/$(basename $(pwd)) ; m To then go back to: > pmu-events/pmu-events.c:3616:11: error: ‘struct pmu_event’ has no member named ‘metric_expr’