From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Jeff LaBundy <jeff@labundy.com>
Cc: robh+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] Input: iqs626a - drop unused device node references
Date: Fri, 3 Feb 2023 17:21:55 -0800 [thread overview]
Message-ID: <Y92zM/SpazGv6CpN@google.com> (raw)
In-Reply-To: <Y9RQVe/V1Hnw1oly@nixie71>
On Fri, Jan 27, 2023 at 04:29:41PM -0600, Jeff LaBundy wrote:
> Each call to device/fwnode_get_named_child_node() must be matched
> with a call to fwnode_handle_put() once the corresponding node is
> no longer in use. This ensures a reference count remains balanced
> in the case of dynamic device tree support.
>
> Currently, the driver never calls fwnode_handle_put(); this patch
> adds the missing calls. Because fwnode_handle_put() does not take
> a const *fwnode_handle, the const qualifier is removed across all
> corresponding *fwnode_handle instances.
>
> As part of this change, trackpad channel touch thresholds and ATI
> base values are now specified under single trackpad channel child
> nodes. This enhancement moves both properties to scalar values as
> opposed to arrays, making their types consistent across bindings.
>
> Fixes: f1d2809de97a ("Input: Add support for Azoteq IQS626A")
> Signed-off-by: Jeff LaBundy <jeff@labundy.com>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2023-02-04 1:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 22:28 [PATCH v2 0/2] Miscellaneous fixes for Azoteq IQS626A Jeff LaBundy
2023-01-27 22:29 ` [PATCH v2 1/2] Input: iqs626a - drop unused device node references Jeff LaBundy
2023-02-04 1:21 ` Dmitry Torokhov [this message]
2023-01-27 22:30 ` [PATCH v2 2/2] dt-bindings: input: iqs626a: Redefine trackpad property types Jeff LaBundy
2023-01-30 21:23 ` Rob Herring
2023-02-04 1:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y92zM/SpazGv6CpN@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jeff@labundy.com \
--cc=linux-input@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.