From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F048C636BD for ; Wed, 25 Jan 2023 14:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235684AbjAYOju (ORCPT ); Wed, 25 Jan 2023 09:39:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235664AbjAYOjt (ORCPT ); Wed, 25 Jan 2023 09:39:49 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8D9F5B93; Wed, 25 Jan 2023 06:39:22 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 401B061494; Wed, 25 Jan 2023 14:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29564C433EF; Wed, 25 Jan 2023 14:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674657511; bh=IoSzOBYb/BV5JDLbRJWFIgSOplOI4fyYUdKcUEbQnYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=noibiVqfCvyFZg2ChVkUuFfQ6DRsQ8wekHQa2Gk352QS4PwyKuDa55AhvQAUIm13Q vn9QAG8SPB9/a7oZ+v/x7EytPKNQlJ4wboXRe0OX40yGABLZW1ZhmBe/EaUYTah0A/ 7GoO4F+taI2Z+4FlF8mHesav5c5G0dIhiR64XQTc= Date: Wed, 25 Jan 2023 15:38:29 +0100 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Vinod Koul , Jonathan Corbet , Madalin Bucur , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , UNGLinuxDriver@microchip.com, Thierry Reding , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jonathan Hunter , Kishon Vijay Abraham I , Alan Stern , Krzysztof Kozlowski , Alim Akhtar , Siddharth Vadapalli , Russell King , linux-phy@lists.infradead.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 8/9] usb: host: ehci-exynos: Convert to devm_of_phy_optional_get() Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org On Tue, Jan 24, 2023 at 07:37:27PM +0100, Geert Uytterhoeven wrote: > Use the new devm_of_phy_optional_get() helper instead of open-coding the > same operation. > > As devm_of_phy_optional_get() returns NULL if either the PHY cannot be > found, or if support for the PHY framework is not enabled, it is no > longer needed to check for -ENODEV or -ENOSYS. > > This lets us drop several checks for IS_ERR(), as phy_power_{on,off}() > handle NULL parameters fine. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E7F93C54EAA for ; Wed, 25 Jan 2023 14:43:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BOphstvCAAMWXMUchRn59GbkbbQztyEltcTDcsQnYuc=; b=GGO4XuCAlv7JPy Bg2KaiThOnYNi06PEDIZSxS+q9cf0dZOZXBYQ+pK1bj0zWWf2TGs1bT5NFsLS/sInt6YjJnxACbp4 xR+OQzE7nP94M1I4/8bTMyuAQELsKX9IzBBbLLpQuMOHMnbf5Ifhh3e0PnWpyqj1fTtJblY+D22k7 3/LL0kD2+2c9smtZIqxadDFkb+55buYZD/7QICLDSc54z7oX2Lvx/3aEYuDvL3xn3ZogJXmD+8vId Gbhqot790Cu501Edbose2RJ6ibheYzM6SzrOAS6uTXE6PTD9MfgYoahNV6HJ9UmhmylwRZNAuI1AX n5Vn3e0Y+DIRMZaHweFQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgyQ-007ctK-6Z; Wed, 25 Jan 2023 14:42:02 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgv3-007bCl-AW; Wed, 25 Jan 2023 14:38:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 02FC4B81A10; Wed, 25 Jan 2023 14:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29564C433EF; Wed, 25 Jan 2023 14:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674657511; bh=IoSzOBYb/BV5JDLbRJWFIgSOplOI4fyYUdKcUEbQnYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=noibiVqfCvyFZg2ChVkUuFfQ6DRsQ8wekHQa2Gk352QS4PwyKuDa55AhvQAUIm13Q vn9QAG8SPB9/a7oZ+v/x7EytPKNQlJ4wboXRe0OX40yGABLZW1ZhmBe/EaUYTah0A/ 7GoO4F+taI2Z+4FlF8mHesav5c5G0dIhiR64XQTc= Date: Wed, 25 Jan 2023 15:38:29 +0100 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Vinod Koul , Jonathan Corbet , Madalin Bucur , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , UNGLinuxDriver@microchip.com, Thierry Reding , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jonathan Hunter , Kishon Vijay Abraham I , Alan Stern , Krzysztof Kozlowski , Alim Akhtar , Siddharth Vadapalli , Russell King , linux-phy@lists.infradead.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 8/9] usb: host: ehci-exynos: Convert to devm_of_phy_optional_get() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_063833_536850_626E2711 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 24, 2023 at 07:37:27PM +0100, Geert Uytterhoeven wrote: > Use the new devm_of_phy_optional_get() helper instead of open-coding the > same operation. > > As devm_of_phy_optional_get() returns NULL if either the PHY cannot be > found, or if support for the PHY framework is not enabled, it is no > longer needed to check for -ENODEV or -ENOSYS. > > This lets us drop several checks for IS_ERR(), as phy_power_{on,off}() > handle NULL parameters fine. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DD03BC54E94 for ; Wed, 25 Jan 2023 14:42:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GdPUDGEKJMh5iMLt06pbdWaYN8A3P8+BT7URQwsfLv0=; b=D4srfdvTzIYNlD hIrQ7cqKJ2utuEh3/tXYkArHamnutOkJyUKf7MbB4zaKCcACKSN7y5Iwxwc9/ivCc/J+zcseYBo4K eGV8gjKlJISLGbIrbl3rYothJhUoaPPqSwh6wt2zeCzp03gpNw9MmrK5oRlrbNThCKbJPByG+01Dw rliaTxt7H5KuDeQiepqM65VsWzYts3++CLPJVGsXyR9WCIEu9bIVE+KACrD7oNLT0Qdjjj9iGK3rq FdsoufPrFmR/zb1rkWTqqoGZkmX8LMXSMFQ8XRv80/NXOmmWYsnHuc/9KgNUojY/NJF+FCr1wZKgt CMfQzMRQokn/Zvqjw4Iw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgz0-007dAP-NB; Wed, 25 Jan 2023 14:42:38 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pKgv3-007bCl-AW; Wed, 25 Jan 2023 14:38:34 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 02FC4B81A10; Wed, 25 Jan 2023 14:38:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 29564C433EF; Wed, 25 Jan 2023 14:38:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1674657511; bh=IoSzOBYb/BV5JDLbRJWFIgSOplOI4fyYUdKcUEbQnYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=noibiVqfCvyFZg2ChVkUuFfQ6DRsQ8wekHQa2Gk352QS4PwyKuDa55AhvQAUIm13Q vn9QAG8SPB9/a7oZ+v/x7EytPKNQlJ4wboXRe0OX40yGABLZW1ZhmBe/EaUYTah0A/ 7GoO4F+taI2Z+4FlF8mHesav5c5G0dIhiR64XQTc= Date: Wed, 25 Jan 2023 15:38:29 +0100 From: Greg Kroah-Hartman To: Geert Uytterhoeven Cc: Vinod Koul , Jonathan Corbet , Madalin Bucur , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Horatiu Vultur , UNGLinuxDriver@microchip.com, Thierry Reding , Lorenzo Pieralisi , Rob Herring , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Bjorn Helgaas , Jonathan Hunter , Kishon Vijay Abraham I , Alan Stern , Krzysztof Kozlowski , Alim Akhtar , Siddharth Vadapalli , Russell King , linux-phy@lists.infradead.org, linux-doc@vger.kernel.org, netdev@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH v2 8/9] usb: host: ehci-exynos: Convert to devm_of_phy_optional_get() Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230125_063833_536850_626E2711 X-CRM114-Status: GOOD ( 14.22 ) X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-phy" Errors-To: linux-phy-bounces+linux-phy=archiver.kernel.org@lists.infradead.org On Tue, Jan 24, 2023 at 07:37:27PM +0100, Geert Uytterhoeven wrote: > Use the new devm_of_phy_optional_get() helper instead of open-coding the > same operation. > > As devm_of_phy_optional_get() returns NULL if either the PHY cannot be > found, or if support for the PHY framework is not enabled, it is no > longer needed to check for -ENODEV or -ENOSYS. > > This lets us drop several checks for IS_ERR(), as phy_power_{on,off}() > handle NULL parameters fine. > > Signed-off-by: Geert Uytterhoeven > Reviewed-by: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman -- linux-phy mailing list linux-phy@lists.infradead.org https://lists.infradead.org/mailman/listinfo/linux-phy