From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3C84C54E94 for ; Wed, 25 Jan 2023 21:39:39 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pKnUG-0007Vk-FF; Wed, 25 Jan 2023 16:39:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pKnUE-0007UV-P0; Wed, 25 Jan 2023 16:39:18 -0500 Received: from mail-qv1-xf2f.google.com ([2607:f8b0:4864:20::f2f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pKnUC-0004jC-CA; Wed, 25 Jan 2023 16:39:18 -0500 Received: by mail-qv1-xf2f.google.com with SMTP id s4so58019qvo.3; Wed, 25 Jan 2023 13:39:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :sender:from:to:cc:subject:date:message-id:reply-to; bh=6v6Xza/pe11vFWzZLH5bPRVIjL8MQtTpVsaqMSJjZ3k=; b=Hr0g0tzE1MwM6ziSNJK+o6t5euVLVMt+MAJFIuOE6rwu3ozgwGw99jVA2qKH6/MrXb P/3t1P7mMiNYbCELlnM3OPCdDv2UI+MGz//vZJPZXwjS6IrvElpklBl8gkN1n1hRgLeZ WRu8RG5WCbGJbKcHO2UED5BYDZFv/EQxHGFsQ8jA3rO1fZCXR3R8cDtb3iyHMNeqCsUM GnrggVPdfC2MXDwds2GjXHblsmCha51kqeUyXpuGacJ/T/U1vGmkFKZfWcPZquClYoYY ynsg+UPt3BO3isLevqEHLykukZ76laAVbynV8F/0fZApCZpNA0P7Xf1BXyiRO4oY7IW6 4vug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6v6Xza/pe11vFWzZLH5bPRVIjL8MQtTpVsaqMSJjZ3k=; b=lwnl8dmB2oEam44lVewh3f+w9jdoK83uqtdE0/ZvctpM1wx4EPT83BjPkd3+U5Ijrd TwYOJUOp/rUowsNIOGtt9/0kfWUu3meNmVr90C0zwcWiyZjw6ciO5aGABGW4N4ptDvnZ VvuxKBUNZV7TbPHuQkRpdiEZuDxwyuSx8YbBq2cxYDVMhVxKj2JmBUBZRNKv8IymHgdi WTBxYn6d0jDheMoFEFbvtTtAVYI1YrEIsghVlWuj2RryA0jQNBuquHVxvrkOGxYS0oM+ oZ4t7M4yx5yIWeXyqd2kS8cDMg4okSOrh1mS3/klaukXJHeo2dU1qog/tLTpr2NWmY8y /+wg== X-Gm-Message-State: AO0yUKV1uJfoWUKjHNJJ+nCWlS81+mIMlgAtGiQrWJcE6D8+qqXsL/75 uP8gkoVI//3WV3wyjpdaxYRbrmqB+w== X-Google-Smtp-Source: AK7set+9yP7bXil1MDiXaICvwH8IY4jF8bPC5kAjnYB+RNin7lfkQz4SUBVEzutA6CsBnuxdjN/Rfw== X-Received: by 2002:a0c:e54d:0:b0:537:7dbd:687b with SMTP id n13-20020a0ce54d000000b005377dbd687bmr144131qvm.49.1674682754789; Wed, 25 Jan 2023 13:39:14 -0800 (PST) Received: from serve.minyard.net ([47.189.91.183]) by smtp.gmail.com with ESMTPSA id dx14-20020a05620a608e00b006b95b0a714esm4246786qkb.17.2023.01.25.13.39.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Jan 2023 13:39:14 -0800 (PST) Received: from minyard.net (unknown [IPv6:2001:470:b8f6:1b:7b7c:de0b:9a93:f5c2]) by serve.minyard.net (Postfix) with ESMTPSA id 1249F1800BF; Wed, 25 Jan 2023 21:39:13 +0000 (UTC) Date: Wed, 25 Jan 2023 15:39:11 -0600 From: Corey Minyard To: Peter Delevoryas Cc: clg@kaod.org, peter.maydell@linaro.org, andrew@aj.id.au, joel@jms.id.au, hskinnemoen@google.com, kfting@nuvoton.com, qemu-arm@nongnu.org, qemu-devel@nongnu.org, philmd@linaro.org Subject: Re: [PATCH v4 4/5] hw/arm/aspeed: Add aspeed_eeprom.c Message-ID: References: <20230118024214.14413-1-peter@pjd.dev> <20230118024214.14413-5-peter@pjd.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230118024214.14413-5-peter@pjd.dev> Received-SPF: pass client-ip=2607:f8b0:4864:20::f2f; envelope-from=tcminyard@gmail.com; helo=mail-qv1-xf2f.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.091, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: minyard@acm.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Tue, Jan 17, 2023 at 06:42:13PM -0800, Peter Delevoryas wrote: > - Create aspeed_eeprom.c and aspeed_eeprom.h > - Include aspeed_eeprom.c in CONFIG_ASPEED meson source files > - Include aspeed_eeprom.h in aspeed.c > - Add fby35_bmc_fruid data > - Use new at24c_eeprom_init_rom helper to initialize BMC FRUID EEPROM with data > from aspeed_eeprom.c Reviewed-by: Corey Minyard > > wget https://github.com/facebook/openbmc/releases/download/openbmc-e2294ff5d31d/fby35.mtd > qemu-system-aarch64 -machine fby35-bmc -nographic -mtdblock fby35.mtd > ... > user: root > pass: 0penBmc > ... > root@bmc-oob:~# fruid-util bb > > FRU Information : Baseboard > --------------- : ------------------ > Chassis Type : Rack Mount Chassis > Chassis Part Number : N/A > Chassis Serial Number : N/A > Board Mfg Date : Fri Jan 7 10:30:00 2022 > Board Mfg : XXXXXX > Board Product : Management Board wBMC > Board Serial : XXXXXXXXXXXXX > Board Part Number : XXXXXXXXXXXXXX > Board FRU ID : 1.0 > Board Custom Data 1 : XXXXXXXXX > Board Custom Data 2 : XXXXXXXXXXXXXXXXXX > Product Manufacturer : XXXXXX > Product Name : Yosemite V3.5 EVT2 > Product Part Number : XXXXXXXXXXXXXX > Product Version : EVT2 > Product Serial : XXXXXXXXXXXXX > Product Asset Tag : XXXXXXX > Product FRU ID : 1.0 > Product Custom Data 1 : XXXXXXXXX > Product Custom Data 2 : N/A > root@bmc-oob:~# fruid-util bmc > > FRU Information : BMC > --------------- : ------------------ > Board Mfg Date : Mon Jan 10 21:42:00 2022 > Board Mfg : XXXXXX > Board Product : BMC Storage Module > Board Serial : XXXXXXXXXXXXX > Board Part Number : XXXXXXXXXXXXXX > Board FRU ID : 1.0 > Board Custom Data 1 : XXXXXXXXX > Board Custom Data 2 : XXXXXXXXXXXXXXXXXX > Product Manufacturer : XXXXXX > Product Name : Yosemite V3.5 EVT2 > Product Part Number : XXXXXXXXXXXXXX > Product Version : EVT2 > Product Serial : XXXXXXXXXXXXX > Product Asset Tag : XXXXXXX > Product FRU ID : 1.0 > Product Custom Data 1 : XXXXXXXXX > Product Custom Data 2 : Config A > root@bmc-oob:~# fruid-util nic > > FRU Information : NIC > --------------- : ------------------ > Board Mfg Date : Tue Nov 2 08:51:00 2021 > Board Mfg : XXXXXXXX > Board Product : Mellanox ConnectX-6 DX OCP3.0 > Board Serial : XXXXXXXXXXXXXXXXXXXXXXXX > Board Part Number : XXXXXXXXXXXXXXXXXXXXX > Board FRU ID : FRU Ver 0.02 > Product Manufacturer : XXXXXXXX > Product Name : Mellanox ConnectX-6 DX OCP3.0 > Product Part Number : XXXXXXXXXXXXXXXXXXXXX > Product Version : A9 > Product Serial : XXXXXXXXXXXXXXXXXXXXXXXX > Product Custom Data 3 : ConnectX-6 DX > > Signed-off-by: Peter Delevoryas > Reviewed-by: Cédric Le Goater > Reviewed-by: Joel Stanley > --- > hw/arm/aspeed.c | 10 ++++-- > hw/arm/aspeed_eeprom.c | 78 ++++++++++++++++++++++++++++++++++++++++++ > hw/arm/aspeed_eeprom.h | 16 +++++++++ > hw/arm/meson.build | 1 + > 4 files changed, 102 insertions(+), 3 deletions(-) > create mode 100644 hw/arm/aspeed_eeprom.c > create mode 100644 hw/arm/aspeed_eeprom.h > > diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c > index c929c61d582a..382965f82c38 100644 > --- a/hw/arm/aspeed.c > +++ b/hw/arm/aspeed.c > @@ -14,6 +14,7 @@ > #include "hw/arm/boot.h" > #include "hw/arm/aspeed.h" > #include "hw/arm/aspeed_soc.h" > +#include "hw/arm/aspeed_eeprom.h" > #include "hw/i2c/i2c_mux_pca954x.h" > #include "hw/i2c/smbus_eeprom.h" > #include "hw/misc/pca9552.h" > @@ -940,9 +941,12 @@ static void fby35_i2c_init(AspeedMachineState *bmc) > > at24c_eeprom_init(i2c[4], 0x51, 128 * KiB); > at24c_eeprom_init(i2c[6], 0x51, 128 * KiB); > - at24c_eeprom_init(i2c[8], 0x50, 32 * KiB); > - at24c_eeprom_init(i2c[11], 0x51, 128 * KiB); > - at24c_eeprom_init(i2c[11], 0x54, 128 * KiB); > + at24c_eeprom_init_rom(i2c[8], 0x50, 32 * KiB, fby35_nic_fruid, > + sizeof(fby35_nic_fruid)); > + at24c_eeprom_init_rom(i2c[11], 0x51, 128 * KiB, fby35_bb_fruid, > + sizeof(fby35_bb_fruid)); > + at24c_eeprom_init_rom(i2c[11], 0x54, 128 * KiB, fby35_bmc_fruid, > + sizeof(fby35_bmc_fruid)); > > /* > * TODO: There is a multi-master i2c connection to an AST1030 MiniBMC on > diff --git a/hw/arm/aspeed_eeprom.c b/hw/arm/aspeed_eeprom.c > new file mode 100644 > index 000000000000..9d0700d4b709 > --- /dev/null > +++ b/hw/arm/aspeed_eeprom.c > @@ -0,0 +1,78 @@ > +/* > + * Copyright (c) Meta Platforms, Inc. and affiliates. > + * > + * SPDX-License-Identifier: GPL-2.0-only > + */ > + > +#include "aspeed_eeprom.h" > + > +const uint8_t fby35_nic_fruid[] = { > + 0x01, 0x00, 0x00, 0x01, 0x0f, 0x20, 0x00, 0xcf, 0x01, 0x0e, 0x19, 0xd7, > + 0x5e, 0xcf, 0xc8, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xdd, > + 0x4d, 0x65, 0x6c, 0x6c, 0x61, 0x6e, 0x6f, 0x78, 0x20, 0x43, 0x6f, 0x6e, > + 0x6e, 0x65, 0x63, 0x74, 0x58, 0x2d, 0x36, 0x20, 0x44, 0x58, 0x20, 0x4f, > + 0x43, 0x50, 0x33, 0x2e, 0x30, 0xd8, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd5, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0xcc, 0x46, 0x52, 0x55, 0x20, 0x56, 0x65, 0x72, > + 0x20, 0x30, 0x2e, 0x30, 0x32, 0xc0, 0xc0, 0xc0, 0xc1, 0x00, 0x00, 0x2f, > + 0x01, 0x11, 0x19, 0xc8, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0xdd, 0x4d, 0x65, 0x6c, 0x6c, 0x61, 0x6e, 0x6f, 0x78, 0x20, 0x43, 0x6f, > + 0x6e, 0x6e, 0x65, 0x63, 0x74, 0x58, 0x2d, 0x36, 0x20, 0x44, 0x58, 0x20, > + 0x4f, 0x43, 0x50, 0x33, 0x2e, 0x30, 0xd5, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0xd3, 0x41, 0x39, 0x20, 0x20, 0x20, 0x20, 0x20, > + 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, 0x20, > + 0xd8, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0xc0, 0xc0, 0xc0, 0xc0, 0xcd, 0x43, 0x6f, 0x6e, 0x6e, 0x65, 0x63, > + 0x74, 0x58, 0x2d, 0x36, 0x20, 0x44, 0x58, 0xc1, 0x00, 0x00, 0x00, 0x00, > + 0x00, 0x00, 0x00, 0xdb, 0xc0, 0x82, 0x30, 0x15, 0x79, 0x7f, 0xa6, 0x00, > + 0x01, 0x18, 0x0b, 0xff, 0x08, 0x00, 0xff, 0xff, 0x64, 0x00, 0x00, 0x00, > + 0x00, 0x03, 0x20, 0x01, 0xff, 0xff, 0x04, 0x46, 0x00, 0xff, 0xff, 0xff, > + 0xff, 0xff, 0xff, 0xff, 0x01, 0x81, 0x09, 0x15, 0xb3, 0x10, 0x1d, 0x00, > + 0x24, 0x15, 0xb3, 0x00, 0x02, 0xeb, 0x8a, 0x95, 0x5c, > +}; > + > +const uint8_t fby35_bb_fruid[] = { > + 0x01, 0x00, 0x01, 0x03, 0x10, 0x00, 0x00, 0xeb, 0x01, 0x02, 0x17, 0xc3, > + 0x4e, 0x2f, 0x41, 0xc3, 0x4e, 0x2f, 0x41, 0xc1, 0x00, 0x00, 0x00, 0x23, > + 0x01, 0x0d, 0x00, 0xb6, 0xd2, 0xd0, 0xc6, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0xd5, 0x4d, 0x61, 0x6e, 0x61, 0x67, 0x65, 0x6d, 0x65, 0x6e, 0x74, > + 0x20, 0x42, 0x6f, 0x61, 0x72, 0x64, 0x20, 0x77, 0x42, 0x4d, 0x43, 0xcd, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0xce, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31, 0x2e, 0x30, 0xc9, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0xc1, 0x00, 0x00, 0x00, 0x00, 0x00, 0xa8, 0x01, 0x0c, 0x00, 0xc6, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x59, 0x6f, 0x73, 0x65, 0x6d, > + 0x69, 0x74, 0x65, 0x20, 0x56, 0x33, 0x2e, 0x35, 0x20, 0x45, 0x56, 0x54, > + 0x32, 0xce, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0xc4, 0x45, 0x56, 0x54, 0x32, 0xcd, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc7, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31, 0x2e, 0x30, 0xc9, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x4e, 0x2f, > + 0x41, 0xc1, 0x00, 0x00, 0x00, 0x00, 0x00, 0x43, > +}; > + > +const uint8_t fby35_bmc_fruid[] = { > + 0x01, 0x00, 0x00, 0x01, 0x0d, 0x00, 0x00, 0xf1, 0x01, 0x0c, 0x00, 0x36, > + 0xe6, 0xd0, 0xc6, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x42, 0x4d, > + 0x43, 0x20, 0x53, 0x74, 0x6f, 0x72, 0x61, 0x67, 0x65, 0x20, 0x4d, 0x6f, > + 0x64, 0x75, 0x6c, 0x65, 0xcd, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xce, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31, 0x2e, > + 0x30, 0xc9, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc1, 0x39, 0x01, 0x0c, 0x00, 0xc6, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xd2, 0x59, 0x6f, 0x73, 0x65, 0x6d, > + 0x69, 0x74, 0x65, 0x20, 0x56, 0x33, 0x2e, 0x35, 0x20, 0x45, 0x56, 0x54, > + 0x32, 0xce, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0xc4, 0x45, 0x56, 0x54, 0x32, 0xcd, 0x58, 0x58, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc7, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc3, 0x31, 0x2e, 0x30, 0xc9, > + 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0x58, 0xc8, 0x43, 0x6f, > + 0x6e, 0x66, 0x69, 0x67, 0x20, 0x41, 0xc1, 0x45, > +}; > diff --git a/hw/arm/aspeed_eeprom.h b/hw/arm/aspeed_eeprom.h > new file mode 100644 > index 000000000000..bc4475a85f24 > --- /dev/null > +++ b/hw/arm/aspeed_eeprom.h > @@ -0,0 +1,16 @@ > +/* > + * Copyright (c) Meta Platforms, Inc. and affiliates. > + * > + * SPDX-License-Identifier: GPL-2.0-only > + */ > + > +#ifndef ASPEED_EEPROM_H > +#define ASPEED_EEPROM_H > + > +#include "qemu/osdep.h" > + > +extern const uint8_t fby35_nic_fruid[309]; > +extern const uint8_t fby35_bb_fruid[224]; > +extern const uint8_t fby35_bmc_fruid[200]; > + > +#endif > diff --git a/hw/arm/meson.build b/hw/arm/meson.build > index 76d4d650e42e..f70e8cfd4545 100644 > --- a/hw/arm/meson.build > +++ b/hw/arm/meson.build > @@ -53,6 +53,7 @@ arm_ss.add(when: 'CONFIG_ASPEED_SOC', if_true: files( > 'aspeed.c', > 'aspeed_ast2600.c', > 'aspeed_ast10x0.c', > + 'aspeed_eeprom.c', > 'fby35.c')) > arm_ss.add(when: 'CONFIG_MPS2', if_true: files('mps2.c')) > arm_ss.add(when: 'CONFIG_MPS2', if_true: files('mps2-tz.c')) > -- > 2.39.0 > >