From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: "Arnd Bergmann" <arnd@kernel.org>,
"Alexander Aring" <alex.aring@gmail.com>,
"Stefan Schmidt" <stefan@datenfreihafen.org>,
linux-gpio@vger.kernel.org, "Arnd Bergmann" <arnd@arndb.de>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-wpan@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH] at86rf230: convert to gpio descriptors
Date: Thu, 26 Jan 2023 16:24:24 +0200 [thread overview]
Message-ID: <Y9KNGPTGK/Os4gZe@smile.fi.intel.com> (raw)
In-Reply-To: <20230126151243.3acc1fe2@xps-13>
On Thu, Jan 26, 2023 at 03:12:43PM +0100, Miquel Raynal wrote:
> arnd@kernel.org wrote on Thu, 26 Jan 2023 14:51:23 +0100:
...
> > There are no remaining in-tree users of the platform_data,
> > so this driver can be converted to using the simpler gpiod
> > interfaces.
> >
> > Any out-of-tree users that rely on the platform data can
> > provide the data using the device_property and gpio_lookup
> > interfaces instead.
[...]
> > @@ -1682,7 +1650,7 @@ MODULE_DEVICE_TABLE(spi, at86rf230_device_id);
> > static struct spi_driver at86rf230_driver = {
> > .id_table = at86rf230_device_id,
> > .driver = {
> > - .of_match_table = of_match_ptr(at86rf230_of_match),
> > + .of_match_table = at86rf230_of_match,linux-gnueabihf embed a C library which relies on kernel headers (for example, to provide an open API which translates to an open syscall), for exam
>
> Looks like an unrelated change? Or is it a consequence of "not having
> any in-tree users of platform_data" that plays a role here?
This enables this driver to work on ACPI-based platforms without needed the
legacy platform data. Dunno if it will be ever the case, but still...
> Anyhow, the changes in the driver look good, so:
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thank you!
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-01-26 14:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 13:51 [PATCH] at86rf230: convert to gpio descriptors Arnd Bergmann
2023-01-26 14:12 ` Miquel Raynal
2023-01-26 14:24 ` Andy Shevchenko [this message]
2023-01-26 14:39 ` Arnd Bergmann
2023-01-26 14:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y9KNGPTGK/Os4gZe@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alex.aring@gmail.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.